diff mbox

mmc: core: Update the ext-csd.rev check for eMMC5.1

Message ID 1369129124-31128-1-git-send-email-yuvaraj.cd@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yuvaraj CD May 21, 2013, 9:38 a.m. UTC
With the new eMMC5.1 spec,there is a new EXT_CSD register with
the revision number(EXT_CSD_REV) 7.This patch updates the check
for ext-csd.rev number as 7.

Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
---
 drivers/mmc/core/mmc.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Doug Anderson May 23, 2013, 12:06 a.m. UTC | #1
Yavaraj,

On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
> With the new eMMC5.1 spec,there is a new EXT_CSD register with
> the revision number(EXT_CSD_REV) 7.This patch updates the check
> for ext-csd.rev number as 7.
>
> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
> ---
>  drivers/mmc/core/mmc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks reasonable.

Reviewed-by: Doug Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Doug Anderson May 23, 2013, 12:08 a.m. UTC | #2
Correction,

On Wed, May 22, 2013 at 5:06 PM, Doug Anderson <dianders@google.com> wrote:
> Yavaraj,
>
> On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>> With the new eMMC5.1 spec,there is a new EXT_CSD register with
>> the revision number(EXT_CSD_REV) 7.This patch updates the check
>> for ext-csd.rev number as 7.
>>
>> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>> ---
>>  drivers/mmc/core/mmc.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks reasonable.
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>

...with the caveat the Alim's email address be corrected.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chris Ball June 27, 2013, 2:39 p.m. UTC | #3
Hi,

On Wed, May 22 2013, Doug Anderson wrote:
> Correction,
>
> On Wed, May 22, 2013 at 5:06 PM, Doug Anderson <dianders@google.com> wrote:
>> Yavaraj,
>>
>> On Tue, May 21, 2013 at 2:38 AM, Yuvaraj Kumar C D <yuvaraj.cd@gmail.com> wrote:
>>> With the new eMMC5.1 spec,there is a new EXT_CSD register with
>>> the revision number(EXT_CSD_REV) 7.This patch updates the check
>>> for ext-csd.rev number as 7.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akthar@samsung.com>
>>> Signed-off-by: Yuvaraj Kumar C D <yuvaraj.cd@samsung.com>
>>> ---
>>>  drivers/mmc/core/mmc.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Looks reasonable.
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> ...with the caveat the Alim's email address be corrected.
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>

Thanks, pushed to mmc-next for 3.11 with the corrected signoff.

- Chris.
diff mbox

Patch

diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 0cbd1ef..73f58e0 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -293,7 +293,7 @@  static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
 	}
 
 	card->ext_csd.rev = ext_csd[EXT_CSD_REV];
-	if (card->ext_csd.rev > 6) {
+	if (card->ext_csd.rev > 7) {
 		pr_err("%s: unrecognised EXT_CSD revision %d\n",
 			mmc_hostname(card->host), card->ext_csd.rev);
 		err = -EINVAL;