Patchworkβ [04/18] ctags: usability fix

login
register
about
Submitter Andrew Morton
Date 2009-09-18 19:49:24
Message ID <200909181949.n8IJnO6j018883@imap1.linux-foundation.org>
Download mbox | patch
Permalink /patch/48619/
State New
Headers show

Comments

Andrew Morton - 2009-09-18 19:49:24
From: Stefani Seibold <stefani@seibold.net>

The tag file generated by the tags.sh script has some issue.

First:
  The identifier-list miss the
  DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL
  special handling, which can result in a wrong tag, not to jump to the
  right variable definition or function implementation.

Second:
  It makes no real sense to include function prototypes and external and
  forward variable declarations, because jumping to a tag will sometimes
  go to this and not to the real definition and implementation. The information
  about the declaration is still there at the definition and implementation
  place.

So this patch make it lot easier to navigate through the kernel source
tree using vi.

Signed-off-by: Stefani Seibold <stefani@seibold.net>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
Cc: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 scripts/tags.sh |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch

diff -puN scripts/tags.sh~ctags-usability-fix scripts/tags.sh
--- a/scripts/tags.sh~ctags-usability-fix
+++ a/scripts/tags.sh
@@ -101,7 +101,8 @@  exuberant()
 	-I ____cacheline_aligned_in_smp                         \
 	-I ____cacheline_internodealigned_in_smp                \
 	-I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL                      \
-	--extra=+f --c-kinds=+px                                \
+	-I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \
+	--extra=+f --c-kinds=-px                                \
 	--regex-asm='/^ENTRY\(([^)]*)\).*/\1/'                  \
 	--regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/'