Patchworkβ [1/6] pciehp: disable DLL state changed event notification

login
register
about
Submitter Kenji Kaneshige
Date 2009-10-05 08:40:02
Message ID <4AC9B0E2.1090809@jp.fujitsu.com>
Download mbox | patch
Permalink /patch/51704/
State Accepted
Headers show

Comments

Kenji Kaneshige - 2009-10-05 08:40:02
Current pciehp doesn't handle Data Link Layer State Changed Event
notification. So it needs to be disabled at initialization time,
otherwise other event notifications are not generated.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>

---
 drivers/pci/hotplug/pciehp_hpc.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)


--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Jesse Barnes - 2009-11-04 17:02:47
On Mon, 05 Oct 2009 17:40:02 +0900
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com> wrote:

> Current pciehp doesn't handle Data Link Layer State Changed Event
> notification. So it needs to be disabled at initialization time,
> otherwise other event notifications are not generated.
> 
> Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
> 
> ---
>  drivers/pci/hotplug/pciehp_hpc.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Index: 20090928/drivers/pci/hotplug/pciehp_hpc.c
> ===================================================================
> --- 20090928.orig/drivers/pci/hotplug/pciehp_hpc.c
> +++ 20090928/drivers/pci/hotplug/pciehp_hpc.c
> @@ -866,7 +866,8 @@ static void pcie_disable_notification(st
>  	u16 mask;
>  	mask = (PCI_EXP_SLTCTL_PDCE | PCI_EXP_SLTCTL_ABPE |
>  		PCI_EXP_SLTCTL_MRLSCE | PCI_EXP_SLTCTL_PFDE |
> -		PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE);
> +		PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE |
> +		PCI_EXP_SLTCTL_DLLSCE);
>  	if (pcie_write_cmd(ctrl, 0, mask))
>  		ctrl_warn(ctrl, "Cannot disable software
> notification\n"); }

Applied this series, thanks Kenji-san.

Jesse
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

Index: 20090928/drivers/pci/hotplug/pciehp_hpc.c
===================================================================
--- 20090928.orig/drivers/pci/hotplug/pciehp_hpc.c
+++ 20090928/drivers/pci/hotplug/pciehp_hpc.c
@@ -866,7 +866,8 @@  static void pcie_disable_notification(st
 	u16 mask;
 	mask = (PCI_EXP_SLTCTL_PDCE | PCI_EXP_SLTCTL_ABPE |
 		PCI_EXP_SLTCTL_MRLSCE | PCI_EXP_SLTCTL_PFDE |
-		PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE);
+		PCI_EXP_SLTCTL_HPIE | PCI_EXP_SLTCTL_CCIE |
+		PCI_EXP_SLTCTL_DLLSCE);
 	if (pcie_write_cmd(ctrl, 0, mask))
 		ctrl_warn(ctrl, "Cannot disable software notification\n");
 }