Patchworkβ Boot-time crash from "PCI/x86: detect host bridge config space size w/o using quirks"

login
register
about
Submitter Yinghai Lu
Date 2009-10-11 10:06:05
Message ID <4AD1AE0D.1030007@kernel.org>
Download mbox | patch
Permalink /patch/52995/
State Superseded
Headers show

Comments

Yinghai Lu - 2009-10-11 10:06:05
Brad Spengler wrote:
> I'm running an SGI 750 (Itanium 1), and have spent all day git-bisecting 
> the patches between 2.6.29 and 2.6.30 (having tried all kernels from 
> 2.6.26 to 2.6.31) and found that your patch:
> http://patchwork.kernel.org/patch/19486/
> causes the crash I observed, which I've taken a picture of here:
> http://yfrog.com/3oimg1457uj
> 
> Let me know if you need any additional information or need me to test a 
> fix you'll submit to LKML.

can you check if this debug patch?

YH

--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 8105e32..4e6a896 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -903,10 +903,6 @@  int pci_cfg_space_size(struct pci_dev *dev)
 	u32 status;
 	u16 class;
 
-	class = dev->class >> 8;
-	if (class == PCI_CLASS_BRIDGE_HOST)
-		return pci_cfg_space_size_ext(dev);
-
 	pos = pci_find_capability(dev, PCI_CAP_ID_EXP);
 	if (!pos) {
 		pos = pci_find_capability(dev, PCI_CAP_ID_PCIX);