Patchworkβ pci/dmar: fix section mismatch in dmar_ir_support()

login
register
about
Submitter Stephen Boyd
Date 2009-10-12 04:20:49
Message ID <1255321249-25546-1-git-send-email-bebarino@gmail.com>
Download mbox | patch
Permalink /patch/53048/
State Not Applicable
Headers show

Comments

Stephen Boyd - 2009-10-12 04:20:49
dmar_ir_support() references dmar_tbl which is annotated with
__initdata. The only caller of dmar_ir_support() is
intr_remapping_supported() also annotated with __init. Therefore add the
__init annotation to dmar_ir_support().

WARNING: drivers/pci/built-in.o(.text+0xa110): Section mismatch in
reference from the function dmar_ir_support() to the variable
.init.data:dmar_tbl
The function dmar_ir_support() references
the variable __initdata dmar_tbl.
This is often because dmar_ir_support lacks a __initdata
annotation or the annotation of dmar_tbl is wrong.
---

I sent this a week back but it looks like it didn't stick. Hopefully it
does this time.

 drivers/pci/dmar.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Patch

diff --git a/drivers/pci/dmar.c b/drivers/pci/dmar.c
index 14bbaa1..fbca5e7 100644
--- a/drivers/pci/dmar.c
+++ b/drivers/pci/dmar.c
@@ -1327,7 +1327,7 @@  int dmar_reenable_qi(struct intel_iommu *iommu)
 /*
  * Check interrupt remapping support in DMAR table description.
  */
-int dmar_ir_support(void)
+int __init dmar_ir_support(void)
 {
 	struct acpi_table_dmar *dmar;
 	dmar = (struct acpi_table_dmar *)dmar_tbl;