| Submitter | Michael Tokarev |
|---|---|
| Date | 2009-10-12 08:41:42 |
| Message ID | <4AD2EBC6.1000505@msgid.tls.msk.ru> |
| Download | mbox | patch |
| Permalink | /patch/53076/ |
| State | New |
| Headers | show |
Comments
On Mon, Oct 12, 2009 at 4:41 PM, Michael Tokarev <mjt@tls.msk.ru> wrote: > Sam Ravnborg wrote: >> >> Hi Linus. >> >> A few kbuild related fixes. > > [] >> >> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users > > As has been discussed previously (and Sam has been CC'ed), the fix > is still incorrect. It replaces "echo -ne" with "/bin/echo -ne", > but neither of the two are guaranteed to support the necessary > arguments and necessary (hexadecimal) escape sequences. What should > be used here is printf(1). The trivial patch below (on top of these > kbuild changes) fixes this issue. > > Thanks. > > /mjt > > Signed-Off-By: Michael Tokarev <mjt@tls.msk.ru> > Sorry, I just saw this email. Hmm, printf(1) should be more portable than echo(1), I checked your patch, how about using 'printf "%b" ' instead? Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Oct 12, 2009 at 12:41:42PM +0400, Michael Tokarev wrote: > Sam Ravnborg wrote: >> Hi Linus. >> >> A few kbuild related fixes. > [] >> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users > > As has been discussed previously (and Sam has been CC'ed), the fix > is still incorrect. In the thread hpa asked for a patch at least twice. Only after I submitted -fixes to Linus it shows up. Bad timing. And please - do not even think of asking me to do it. You guys are the one that see the issue, who know how to fix it, and knows how to check that the fix really works. In other words - provide a patch next time you are asked to do so. I'm off for much needed vacation rest of the week and may rememeber to handle the patch when I get back... Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sam Ravnborg wrote: > On Mon, Oct 12, 2009 at 12:41:42PM +0400, Michael Tokarev wrote: >> Sam Ravnborg wrote: >>> Hi Linus. >>> >>> A few kbuild related fixes. >> [] >>> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users >> As has been discussed previously (and Sam has been CC'ed), the fix >> is still incorrect. > > In the thread hpa asked for a patch at least twice. > Only after I submitted -fixes to Linus it shows up. > > Bad timing. > > And please - do not even think of asking me to do it. How many patches should one send? How many trees one should compare against and send different patch for, in case such an obvious trivial cases? If I'll provide this against mainline, it wont apply to Sam's tree. If against Sam's tree, it wont apply to mainline. And for such trivial cases, it's just amusing to expect full patch. It's not bad timing. I needed to know which damn tree I should diff against. In Sam's pull request I found the - hopefully - correct tree. Please don't even think I will be submitting something like this again. I spent half a week debugging a mysterious issue, and I provided at least information in hope it will be useful to someone with the same issue. And it turns out that by doing so, *I* owe something to everyone else. It's not how things works, or SHOULD work. Thanks. /mjt > You guys are the one that see the issue, who know how to fix it, > and knows how to check that the fix really works. > > In other words - provide a patch next time you are asked to do so. > > I'm off for much needed vacation rest of the week and > may rememeber to handle the patch when I get back... > > Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Oct 13, 2009 at 11:19:52PM +0400, Michael Tokarev wrote: > Sam Ravnborg wrote: >> On Mon, Oct 12, 2009 at 12:41:42PM +0400, Michael Tokarev wrote: >>> Sam Ravnborg wrote: >>>> Hi Linus. >>>> >>>> A few kbuild related fixes. >>> [] >>>> - Fix use of echo -ne. Is caused issues for ubuntu (IIRC) users >>> As has been discussed previously (and Sam has been CC'ed), the fix >>> is still incorrect. >> >> In the thread hpa asked for a patch at least twice. >> Only after I submitted -fixes to Linus it shows up. >> >> Bad timing. >> >> And please - do not even think of asking me to do it. > > How many patches should one send? How many trees one should > compare against and send different patch for, in case such > an obvious trivial cases? If I'll provide this against > mainline, it wont apply to Sam's tree. mainline - a replacement patch would have been what I had expected to see. I took you patch and gave it a hopefully proper subject and applied it to kbuild-fixes.git. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Sam Ravnborg wrote: > On Tue, Oct 13, 2009 at 11:19:52PM +0400, Michael Tokarev wrote: >> Sam Ravnborg wrote: [] >>> And please - do not even think of asking me to do it. >> How many patches should one send? How many trees one should >> compare against and send different patch for, in case such >> an obvious trivial cases? If I'll provide this against >> mainline, it wont apply to Sam's tree. > mainline - a replacement patch would have been > what I had expected to see. That's what I didn't think of. Due to the "trivialness" of the whole thing (it's easier to go edit the target file directly than to apply patches), and because.. well.. it didn't occur to me ;) > I took you patch and gave it a hopefully proper > subject and applied it to kbuild-fixes.git. Thank you Sam. /mjt -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index ffdafb2..d9f0cb8 100644 --- a/scripts/Makefile.lib +++ b/scripts/Makefile.lib @@ -208,7 +208,7 @@ cmd_gzip = (cat $(filter-out FORCE,$^) | gzip -f -9 > $@) || \ # Bzip2 and LZMA do not include size in file... so we have to fake that; # append the size as a 32-bit littleendian number as gzip does. -size_append = /bin/echo -ne $(shell \ +size_append = printf $(shell \ dec_size=0; \ for F in $1; do \ fsize=$$(stat -c "%s" $$F); \