Patchworkβ [6/6] davinci: DA850/OMAP-L138: rearrange include file order in da850.c

login
register
about
Submitter Nori, Sekhar
Date 2009-10-22 09:42:18
Message ID <1256204538-20794-6-git-send-email-nsekhar@ti.com>
Download mbox | patch
Permalink /patch/55282/
State New
Headers show

Comments

Nori, Sekhar - 2009-10-22 09:42:18
commit c735eeb86fedb0e81e6eb2cef75a6048b6263c58 changed the order
of platform_device.h inclusion in da850.c. Rearrange to keep all
includes from linux/ together

Signed-off-by: Sekhar Nori <nsekhar@ti.com>
---
 arch/arm/mach-davinci/da850.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Sergei Shtylyov - 2009-10-22 13:19:20
Hello.

Sekhar Nori wrote:

> commit c735eeb86fedb0e81e6eb2cef75a6048b6263c58 changed the order

    Linus has asked people to cite the commit summary after the commit SHA1 
in parens.

> of platform_device.h inclusion in da850.c. Rearrange to keep all
> includes from linux/ together

    Hm, it wasn't a part of my original patch... ah, I undestand: Kevin had 
to add it back. Not sure why he hasn't put it into the proper "group" though...

> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
> ---
>  arch/arm/mach-davinci/da850.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
> index c2d2724..0804ea5 100644
> --- a/arch/arm/mach-davinci/da850.c
> +++ b/arch/arm/mach-davinci/da850.c
> @@ -15,6 +15,7 @@
>  #include <linux/clk.h>
>  #include <linux/cpufreq.h>
>  #include <linux/regulator/consumer.h>
> +#include <linux/platform_device.h>
>  
>  #include <asm/mach/map.h>
>  
> @@ -25,7 +26,6 @@
>  #include <mach/time.h>
>  #include <mach/da8xx.h>
>  #include <mach/cpufreq.h>
> -#include <linux/platform_device.h>
>  
>  #include "clock.h"
>  #include "mux.h"

WBR, Sergei
Kevin Hilman - 2009-11-02 19:20:21
Sergei Shtylyov <sshtylyov@ru.mvista.com> writes:

> Hello.
>
> Sekhar Nori wrote:
>
>> commit c735eeb86fedb0e81e6eb2cef75a6048b6263c58 changed the order
>
>    Linus has asked people to cite the commit summary after the commit
> SHA1 in parens.
>
>> of platform_device.h inclusion in da850.c. Rearrange to keep all
>> includes from linux/ together
>
>    Hm, it wasn't a part of my original patch... ah, I undestand: Kevin
> had to add it back. Not sure why he hasn't put it into the proper
> "group" though...

My bad.  I'll fixup in davinci-next so this patch won't be needed.

Kevin

>> Signed-off-by: Sekhar Nori <nsekhar@ti.com>
>> ---
>>  arch/arm/mach-davinci/da850.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
>> index c2d2724..0804ea5 100644
>> --- a/arch/arm/mach-davinci/da850.c
>> +++ b/arch/arm/mach-davinci/da850.c
>> @@ -15,6 +15,7 @@
>>  #include <linux/clk.h>
>>  #include <linux/cpufreq.h>
>>  #include <linux/regulator/consumer.h>
>> +#include <linux/platform_device.h>
>>   #include <asm/mach/map.h>
>>  @@ -25,7 +26,6 @@
>>  #include <mach/time.h>
>>  #include <mach/da8xx.h>
>>  #include <mach/cpufreq.h>
>> -#include <linux/platform_device.h>
>>   #include "clock.h"
>>  #include "mux.h"
>
> WBR, Sergei
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Patch

diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da850.c
index c2d2724..0804ea5 100644
--- a/arch/arm/mach-davinci/da850.c
+++ b/arch/arm/mach-davinci/da850.c
@@ -15,6 +15,7 @@ 
 #include <linux/clk.h>
 #include <linux/cpufreq.h>
 #include <linux/regulator/consumer.h>
+#include <linux/platform_device.h>
 
 #include <asm/mach/map.h>
 
@@ -25,7 +26,6 @@ 
 #include <mach/time.h>
 #include <mach/da8xx.h>
 #include <mach/cpufreq.h>
-#include <linux/platform_device.h>
 
 #include "clock.h"
 #include "mux.h"