| Submitter | Roel Kluin |
|---|---|
| Date | 2009-11-01 13:18:16 |
| Message ID | <4AED8A98.6040205@gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/56864/ |
| State | Awaiting Upstream, archived |
| Delegated to: | Tony Lindgren |
| Headers | show |
Comments
* Roel Kluin <roel.kluin@gmail.com> [091101 05:07]: > The index `cs' is signed, test whether it is negative before > we release gpmc_cs_mem[cs]. > > Signed-off-by: Roel Kluin <roel.kluin@gmail.com> > --- > Found by code analysis, is it required? Looks like a valid check to me. Acked-by: Tony Lindgren <tony@atomide.com> > > diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c > index 1587682..c892a54 100644 > --- a/arch/arm/mach-omap2/gpmc.c > +++ b/arch/arm/mach-omap2/gpmc.c > @@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request); > void gpmc_cs_free(int cs) > { > spin_lock(&gpmc_mem_lock); > - if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { > + if (cs >= GPMC_CS_NUM || cs < 0 || !gpmc_cs_reserved(cs)) { > printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); > BUG(); > spin_unlock(&gpmc_mem_lock); -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/arch/arm/mach-omap2/gpmc.c b/arch/arm/mach-omap2/gpmc.c index 1587682..c892a54 100644 --- a/arch/arm/mach-omap2/gpmc.c +++ b/arch/arm/mach-omap2/gpmc.c @@ -378,7 +378,7 @@ EXPORT_SYMBOL(gpmc_cs_request); void gpmc_cs_free(int cs) { spin_lock(&gpmc_mem_lock); - if (cs >= GPMC_CS_NUM || !gpmc_cs_reserved(cs)) { + if (cs >= GPMC_CS_NUM || cs < 0 || !gpmc_cs_reserved(cs)) { printk(KERN_ERR "Trying to free non-reserved GPMC CS%d\n", cs); BUG(); spin_unlock(&gpmc_mem_lock);
The index `cs' is signed, test whether it is negative before we release gpmc_cs_mem[cs]. Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- Found by code analysis, is it required? -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html