| Submitter | manjugk manjugk |
|---|---|
| Date | 2009-11-02 07:56:03 |
| Message ID | <1257148563-18604-1-git-send-email-manjugk@ti.com> |
| Download | mbox | patch |
| Permalink | /patch/56946/ |
| State | Rejected |
| Delegated to: | Kevin Hilman |
| Headers | show |
Comments
It looks like config issue with git-send-email on my system. Here is Patch Description: The CONFIG_DEBUG_FS is not enabled in omap_zoom2_defconfig which is breaking zoom2 defconfig build in linux-omap-pm(pm branch). This patch fixes build issue and kernel booting is also tested on zoom2. > -----Original Message----- > From: G, Manjunath Kondaiah > Sent: Monday, November 02, 2009 1:26 PM > To: linux-omap@vger.kernel.org > Cc: khilman@deeprootsystems.com; G, Manjunath Kondaiah > Subject: [PATCH] [OMAP3_PM] Fix zoom2 defconfig build > > From: Manjunatha GK <manjugk@ti.com> > > > Signed-off-by: Manjunatha GK <manjugk@ti.com> > --- > arch/arm/configs/omap_zoom2_defconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/configs/omap_zoom2_defconfig > b/arch/arm/configs/omap_zoom2_defconfig > index f1739fa..8ca835a 100644 > --- a/arch/arm/configs/omap_zoom2_defconfig > +++ b/arch/arm/configs/omap_zoom2_defconfig > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y > CONFIG_FRAME_WARN=1024 > CONFIG_MAGIC_SYSRQ=y > # CONFIG_UNUSED_SYMBOLS is not set > -# CONFIG_DEBUG_FS is not set > +CONFIG_DEBUG_FS=y > # CONFIG_HEADERS_CHECK is not set > CONFIG_DEBUG_KERNEL=y > # CONFIG_DEBUG_SHIRQ is not set > -- > 1.6.0.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2009-11-02 at 13:26 +0530, manjugk@ti.com wrote: > From: Manjunatha GK <manjugk@ti.com> > > > Signed-off-by: Manjunatha GK <manjugk@ti.com> > --- > arch/arm/configs/omap_zoom2_defconfig | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/configs/omap_zoom2_defconfig b/arch/arm/configs/omap_zoom2_defconfig > index f1739fa..8ca835a 100644 > --- a/arch/arm/configs/omap_zoom2_defconfig > +++ b/arch/arm/configs/omap_zoom2_defconfig > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y > CONFIG_FRAME_WARN=1024 > CONFIG_MAGIC_SYSRQ=y > # CONFIG_UNUSED_SYMBOLS is not set > -# CONFIG_DEBUG_FS is not set > +CONFIG_DEBUG_FS=y > # CONFIG_HEADERS_CHECK is not set > CONFIG_DEBUG_KERNEL=y > # CONFIG_DEBUG_SHIRQ is not set It is nicer to provide the build failure log. But if this is a build failure, this means there is a problem with Kconfig dependency, which should be fixed properly, not hidden.
DQo+ID4gLS0tIGEvYXJjaC9hcm0vY29uZmlncy9vbWFwX3pvb20yX2RlZmNvbmZpZw0KPiA+ICsr KyBiL2FyY2gvYXJtL2NvbmZpZ3Mvb21hcF96b29tMl9kZWZjb25maWcNCj4gPiBAQCAtMTM1MCw3 ICsxMzUwLDcgQEAgQ09ORklHX0VOQUJMRV9NVVNUX0NIRUNLPXkNCj4gPiAgQ09ORklHX0ZSQU1F X1dBUk49MTAyNA0KPiA+ICBDT05GSUdfTUFHSUNfU1lTUlE9eQ0KPiA+ICAjIENPTkZJR19VTlVT RURfU1lNQk9MUyBpcyBub3Qgc2V0DQo+ID4gLSMgQ09ORklHX0RFQlVHX0ZTIGlzIG5vdCBzZXQN Cj4gPiArQ09ORklHX0RFQlVHX0ZTPXkNCj4gPiAgIyBDT05GSUdfSEVBREVSU19DSEVDSyBpcyBu b3Qgc2V0DQo+ID4gIENPTkZJR19ERUJVR19LRVJORUw9eQ0KPiA+ICAjIENPTkZJR19ERUJVR19T SElSUSBpcyBub3Qgc2V0DQo+IA0KPiBJdCBpcyBuaWNlciB0byBwcm92aWRlIHRoZSBidWlsZCBm YWlsdXJlIGxvZy4gQnV0IGlmIHRoaXMgaXMgYSBidWlsZA0KPiBmYWlsdXJlLCB0aGlzIG1lYW5z IHRoZXJlIGlzIGEgcHJvYmxlbSB3aXRoIEtjb25maWcgZGVwZW5kZW5jeSwgd2hpY2gNCj4gc2hv dWxkIGJlIGZpeGVkIHByb3Blcmx5LCBub3QgaGlkZGVuLg0KDQpIZXJlIGlzIGJ1aWxkIGZhaWx1 cmUgbG9nOg0KICBNT0RQT1NUIHZtbGludXgubw0KV0FSTklORzogbW9kcG9zdDogRm91bmQgMSBz ZWN0aW9uIG1pc21hdGNoKGVzKS4NClRvIHNlZSBmdWxsIGRldGFpbHMgYnVpbGQgeW91ciBrZXJu ZWwgd2l0aDoNCidtYWtlIENPTkZJR19ERUJVR19TRUNUSU9OX01JU01BVENIPXknDQogIEdFTiAg ICAgLnZlcnNpb24NCiAgQ0hLICAgICBpbmNsdWRlL2xpbnV4L2NvbXBpbGUuaA0KICBVUEQgICAg IGluY2x1ZGUvbGludXgvY29tcGlsZS5oDQogIENDICAgICAgaW5pdC92ZXJzaW9uLm8NCiAgTEQg ICAgICBpbml0L2J1aWx0LWluLm8NCiAgTEQgICAgICAudG1wX3ZtbGludXgxDQphcmNoL2FybS9t YWNoLW9tYXAyL2J1aWx0LWluLm86IEluIGZ1bmN0aW9uIGBvbWFwX3NyYW1faWRsZSc6DQovaG9t ZS9tYW5qdS9jbG9uZXMvZ2l0L2xpbnV4LW9tYXAtcG0vYXJjaC9hcm0vbWFjaC1vbWFwMi9wbTM0 eHguYzo0NDE6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYHBtX2RiZ19yZWdzZXRfc2F2ZScNCi9o b21lL21hbmp1L2Nsb25lcy9naXQvbGludXgtb21hcC1wbS9hcmNoL2FybS9tYWNoLW9tYXAyL3Bt MzR4eC5jOjQ1MjogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgcG1fZGJnX3JlZ3NldF9zYXZlJw0K YXJjaC9hcm0vbWFjaC1vbWFwMi9idWlsdC1pbi5vOiBJbiBmdW5jdGlvbiBgY29uZmlndXJlX3Zj JzoNCi9ob21lL21hbmp1L2Nsb25lcy9naXQvbGludXgtb21hcC1wbS9hcmNoL2FybS9tYWNoLW9t YXAyL3BtMzR4eC5jOjEyMjY6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYHBtX2RiZ19yZWdzZXRf aW5pdCcNCi9ob21lL21hbmp1L2Nsb25lcy9naXQvbGludXgtb21hcC1wbS9hcmNoL2FybS9tYWNo LW9tYXAyL3BtMzR4eC5jOjEyMjc6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYHBtX2RiZ19yZWdz ZXRfaW5pdCcNCm1ha2U6ICoqKiBbLnRtcF92bWxpbnV4MV0gRXJyb3IgMQ0KDQpUaGUgYWJvdmUg dHdvIEFQSSdzIGFyZSB1bmRlciBDT05GSUdfREVCVUdfRlMgZmxhZyBpbiBhcmNoL2FybS9tYWNo LW9tYXAyL3BtLWRlYnVnLmMNCg0KLU1hbmp1bmF0aA0K -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Nov 02, 2009 at 10:00:23AM +0100, ext G, Manjunath Kondaiah wrote: > > > > --- a/arch/arm/configs/omap_zoom2_defconfig > > > +++ b/arch/arm/configs/omap_zoom2_defconfig > > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y > > > CONFIG_FRAME_WARN=1024 > > > CONFIG_MAGIC_SYSRQ=y > > > # CONFIG_UNUSED_SYMBOLS is not set > > > -# CONFIG_DEBUG_FS is not set > > > +CONFIG_DEBUG_FS=y > > > # CONFIG_HEADERS_CHECK is not set > > > CONFIG_DEBUG_KERNEL=y > > > # CONFIG_DEBUG_SHIRQ is not set > > > > It is nicer to provide the build failure log. But if this is a build > > failure, this means there is a problem with Kconfig dependency, which > > should be fixed properly, not hidden. > > Here is build failure log: > MODPOST vmlinux.o > WARNING: modpost: Found 1 section mismatch(es). > To see full details build your kernel with: > 'make CONFIG_DEBUG_SECTION_MISMATCH=y' > GEN .version > CHK include/linux/compile.h > UPD include/linux/compile.h > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save' > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save' > arch/arm/mach-omap2/built-in.o: In function `configure_vc': > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init' > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init' > make: *** [.tmp_vmlinux1] Error 1 > > The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c so the right fix would be to change the ifdef to something saner. Probably on the header file something like: #if defined(CONFIG_PM_DEBUG) && defined(CONFIG_DEBUG_FS)
On Mon, 2009-11-02 at 14:30 +0530, G, Manjunath Kondaiah wrote: > > > --- a/arch/arm/configs/omap_zoom2_defconfig > > > +++ b/arch/arm/configs/omap_zoom2_defconfig > > > @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y > > > CONFIG_FRAME_WARN=1024 > > > CONFIG_MAGIC_SYSRQ=y > > > # CONFIG_UNUSED_SYMBOLS is not set > > > -# CONFIG_DEBUG_FS is not set > > > +CONFIG_DEBUG_FS=y > > > # CONFIG_HEADERS_CHECK is not set > > > CONFIG_DEBUG_KERNEL=y > > > # CONFIG_DEBUG_SHIRQ is not set > > > > It is nicer to provide the build failure log. But if this is a build > > failure, this means there is a problem with Kconfig dependency, which > > should be fixed properly, not hidden. > > Here is build failure log: > MODPOST vmlinux.o > WARNING: modpost: Found 1 section mismatch(es). > To see full details build your kernel with: > 'make CONFIG_DEBUG_SECTION_MISMATCH=y' > GEN .version > CHK include/linux/compile.h > UPD include/linux/compile.h > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > arch/arm/mach-omap2/built-in.o: In function `omap_sram_idle': > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:441: undefined reference to `pm_dbg_regset_save' > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:452: undefined reference to `pm_dbg_regset_save' > arch/arm/mach-omap2/built-in.o: In function `configure_vc': > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1226: undefined reference to `pm_dbg_regset_init' > /home/manju/clones/git/linux-omap-pm/arch/arm/mach-omap2/pm34xx.c:1227: undefined reference to `pm_dbg_regset_init' > make: *** [.tmp_vmlinux1] Error 1 > > The above two API's are under CONFIG_DEBUG_FS flag in arch/arm/mach-omap2/pm-debug.c OK, but why do you send a band-aid to fix this, instead of a real fix?
Patch
diff --git a/arch/arm/configs/omap_zoom2_defconfig b/arch/arm/configs/omap_zoom2_defconfig index f1739fa..8ca835a 100644 --- a/arch/arm/configs/omap_zoom2_defconfig +++ b/arch/arm/configs/omap_zoom2_defconfig @@ -1350,7 +1350,7 @@ CONFIG_ENABLE_MUST_CHECK=y CONFIG_FRAME_WARN=1024 CONFIG_MAGIC_SYSRQ=y # CONFIG_UNUSED_SYMBOLS is not set -# CONFIG_DEBUG_FS is not set +CONFIG_DEBUG_FS=y # CONFIG_HEADERS_CHECK is not set CONFIG_DEBUG_KERNEL=y # CONFIG_DEBUG_SHIRQ is not set