Patchworkβ [1/1] perf symbols: Initialize dso->loaded

login
register
about
Submitter Arnaldo Carvalho de Melo
Date 2009-11-03 17:52:18
Message ID <1257270738-5669-1-git-send-email-acme@infradead.org>
Download mbox | patch
Permalink /patch/57345/
State New
Headers show

Comments

Arnaldo Carvalho de Melo - 2009-11-03 17:52:18
From: Arnaldo Carvalho de Melo <acme@redhat.com>

Brown paper bag bug introduced in:

66bd8424cc05e800db384053bf7ab967e4658468

Without this we were not loading any symtabs that happened to be on a
DSO for which the allocated memory for ->loaded was !0.

Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/symbol.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Patch

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index ec99d79..ac94d7b 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -121,6 +121,7 @@  struct dso *dso__new(const char *name)
 		self->find_symbol = dso__find_symbol;
 		self->slen_calculated = 0;
 		self->origin = DSO__ORIG_NOT_FOUND;
+		self->loaded = false;
 	}
 
 	return self;