Patchworkβ [tip:perf/core] perf symbols: Initialize dso->loaded

login
register
about
Submitter Arnaldo Carvalho de Melo
Date 2009-11-03 17:57:50
Message ID <tip-6d7aa9d721c8c640066142fd9534afcdf68d7f9d@git.kernel.org>
Download mbox | patch
Permalink /patch/57348/
State New
Headers show

Comments

Arnaldo Carvalho de Melo - 2009-11-03 17:57:50
Commit-ID:  6d7aa9d721c8c640066142fd9534afcdf68d7f9d
Gitweb:     http://git.kernel.org/tip/6d7aa9d721c8c640066142fd9534afcdf68d7f9d
Author:     Arnaldo Carvalho de Melo <acme@redhat.com>
AuthorDate: Tue, 3 Nov 2009 15:52:18 -0200
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Tue, 3 Nov 2009 18:56:06 +0100

perf symbols: Initialize dso->loaded

Brown paper bag bug introduced in:

 66bd8424cc05e800db384053bf7ab967e4658468 ("perf tools: Delay
 loading symtabs till we hit a map with it")

Without this we were not loading any symtabs that happened to be
on a DSO for which the allocated memory for ->loaded was !0.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <1257270738-5669-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 tools/perf/util/symbol.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Patch

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index cf2c7f7..93c49f4 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -121,6 +121,7 @@  struct dso *dso__new(const char *name)
 		self->find_symbol = dso__find_symbol;
 		self->slen_calculated = 0;
 		self->origin = DSO__ORIG_NOT_FOUND;
+		self->loaded = false;
 	}
 
 	return self;