| Submitter | vikram pandita |
|---|---|
| Date | 2009-11-03 21:20:09 |
| Message ID | <1257283215-6448-3-git-send-email-vikram.pandita@ti.com> |
| Download | mbox | patch |
| Permalink | /patch/57374/ |
| State | Superseded, archived |
| Delegated to: | Tony Lindgren |
| Headers | show |
Comments
Vikram Pandita had written, on 11/03/2009 03:20 PM, the following: [...] > diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h > index e22f575..49b38f0 100644 > --- a/arch/arm/plat-omap/include/plat/uncompress.h > +++ b/arch/arm/plat-omap/include/plat/uncompress.h > @@ -44,8 +44,10 @@ static void putc(int c) > uart = (volatile u8 *)(OMAP_UART3_BASE); > #elif defined(CONFIG_OMAP_LL_DEBUG_UART2) > uart = (volatile u8 *)(OMAP_UART2_BASE); > -#else > +#elif defined(CONFIG_OMAP_LL_DEBUG_UART1) > uart = (volatile u8 *)(OMAP_UART1_BASE); > +#elif defined(CONFIG_OMAP_LL_DEBUG_NONE) > + return; what is the default? an #else missing? maybe, we might want to use: #else return; also I am not clear about #ifdef CONFIG_MACH_OMAP_PALMTE return #endif Vs this -> should'nt PALMTE also use this instead? unrelated.. purpose of #ifdef CONFIG_ARCH_OMAP in arch/arm/plat-omap/include/plat/uncompress.h is'nt it already OMAP?
Patch
diff --git a/arch/arm/plat-omap/Kconfig b/arch/arm/plat-omap/Kconfig index 64b3f52..c912e0e 100644 --- a/arch/arm/plat-omap/Kconfig +++ b/arch/arm/plat-omap/Kconfig @@ -176,6 +176,9 @@ config OMAP_LL_DEBUG_UART2 config OMAP_LL_DEBUG_UART3 bool "UART3" +config OMAP_LL_DEBUG_NONE + bool "None" + endchoice config OMAP_SERIAL_WAKE diff --git a/arch/arm/plat-omap/include/plat/uncompress.h b/arch/arm/plat-omap/include/plat/uncompress.h index e22f575..49b38f0 100644 --- a/arch/arm/plat-omap/include/plat/uncompress.h +++ b/arch/arm/plat-omap/include/plat/uncompress.h @@ -44,8 +44,10 @@ static void putc(int c) uart = (volatile u8 *)(OMAP_UART3_BASE); #elif defined(CONFIG_OMAP_LL_DEBUG_UART2) uart = (volatile u8 *)(OMAP_UART2_BASE); -#else +#elif defined(CONFIG_OMAP_LL_DEBUG_UART1) uart = (volatile u8 *)(OMAP_UART1_BASE); +#elif defined(CONFIG_OMAP_LL_DEBUG_NONE) + return; #endif #ifdef CONFIG_ARCH_OMAP1
Zoom2/Zoom3 kind of boards do not use omap uarts these boards should not have DEBUG_LL writing to omap uarts Signed-off-by: Vikram Pandita <vikram.pandita@ti.com> --- arch/arm/plat-omap/Kconfig | 3 +++ arch/arm/plat-omap/include/plat/uncompress.h | 4 +++- 2 files changed, 6 insertions(+), 1 deletions(-)