| Submitter | Michael Goldish |
|---|---|
| Date | 2009-11-05 10:01:12 |
| Message ID | <1257415272-9423-7-git-send-email-mgoldish@redhat.com> |
| Download | mbox | patch |
| Permalink | /patch/57867/ |
| State | New |
| Headers | show |
Comments
On Thu, Nov 05, 2009 at 12:01:12PM +0200, Michael Goldish wrote: > This should slow the rate of accumulation of monitor files in /tmp. Hi Michael, I recommend we use TCP as monitor dev of VM. Two reasons: 1) we don't need to add extra code to remove monitor files 2) it's necessary for some users want to implement client-side migration. What do you think? ;-) > > Signed-off-by: Michael Goldish <mgoldish@redhat.com> > --- > client/tests/kvm/kvm_vm.py | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py > index 5781dbc..62a10b9 100755 > --- a/client/tests/kvm/kvm_vm.py > +++ b/client/tests/kvm/kvm_vm.py > @@ -578,6 +578,10 @@ class VM: > finally: > if self.process: > self.process.close() > + try: > + os.unlink(self.monitor_file_name) > + except OSError: > + pass > > > def is_alive(self): > -- > 1.5.4.1 > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Patch
diff --git a/client/tests/kvm/kvm_vm.py b/client/tests/kvm/kvm_vm.py index 5781dbc..62a10b9 100755 --- a/client/tests/kvm/kvm_vm.py +++ b/client/tests/kvm/kvm_vm.py @@ -578,6 +578,10 @@ class VM: finally: if self.process: self.process.close() + try: + os.unlink(self.monitor_file_name) + except OSError: + pass def is_alive(self):
This should slow the rate of accumulation of monitor files in /tmp. Signed-off-by: Michael Goldish <mgoldish@redhat.com> --- client/tests/kvm/kvm_vm.py | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)