| Submitter | Thiago Farina |
|---|---|
| Date | 2009-11-07 01:45:05 |
| Message ID | <a4c8a6d00911061745s4508d997v684683a1dbad821d@mail.gmail.com> |
| Download | mbox | patch |
| Permalink | /patch/58286/ |
| State | New |
| Headers | show |
Comments
On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: > *apdbg.c: use NULL pointer instead of 0 integer. > > Signed-off-by: Thiago Farina <tfransosi@gmail.com> Still doesn't apply, I don't know what you are doing wrong here :( odd. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Hi Greg, On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: >> *apdbg.c: use NULL pointer instead of 0 integer. >> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> > > Still doesn't apply, I don't know what you are doing wrong here :( > > odd. How are you applying it? I can try reproduce here and figure out what is wrong :/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote: > Hi Greg, > > On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: > > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: > >> *apdbg.c: use NULL pointer instead of 0 integer. > >> > >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> > > > > Still doesn't apply, I don't know what you are doing wrong here :( > > > > odd. > > How are you applying it? 'patch -p1 < your_email' > I can try reproduce here and figure out what is wrong :/ Please do. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg@kroah.com> wrote: > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote: >> Hi Greg, >> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: >> >> *apdbg.c: use NULL pointer instead of 0 integer. >> >> >> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> >> > >> > Still doesn't apply, I don't know what you are doing wrong here :( >> > >> > odd. >> >> How are you applying it? > > 'patch -p1 < your_email' Are you getting something like: "Hmm... Ignoring the trailing garbage." ? The output for me was this: ... Patching file drivers/staging/otus/apdbg.c using Plan A... Hunk #1 succeeded at 109. Hunk #2 succeeded at 123. Hmm... Ignoring the trailing garbage. done -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote: > On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg@kroah.com> wrote: > > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote: > >> Hi Greg, > >> > >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: > >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: > >> >> *apdbg.c: use NULL pointer instead of 0 integer. > >> >> > >> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> > >> > > >> > Still doesn't apply, I don't know what you are doing wrong here :( > >> > > >> > odd. > >> > >> How are you applying it? > > > > 'patch -p1 < your_email' > > Are you getting something like: "Hmm... Ignoring the trailing garbage." ? > > The output for me was this: > ... > Patching file drivers/staging/otus/apdbg.c using Plan A... > Hunk #1 succeeded at 109. > Hunk #2 succeeded at 123. > Hmm... Ignoring the trailing garbage. > done Are you appling this to the linux-next tree? Or Linus's tree? I just get a failure against linux-next. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Fri, Nov 20, 2009 at 6:15 PM, Greg KH <greg@kroah.com> wrote: > On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote: >> On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg@kroah.com> wrote: >> > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote: >> >> Hi Greg, >> >> >> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: >> >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: >> >> >> *apdbg.c: use NULL pointer instead of 0 integer. >> >> >> >> >> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> >> >> > >> >> > Still doesn't apply, I don't know what you are doing wrong here :( >> >> > >> >> > odd. >> >> >> >> How are you applying it? >> > >> > 'patch -p1 < your_email' >> >> Are you getting something like: "Hmm... Ignoring the trailing garbage." ? >> >> The output for me was this: >> ... >> Patching file drivers/staging/otus/apdbg.c using Plan A... >> Hunk #1 succeeded at 109. >> Hunk #2 succeeded at 123. >> Hmm... Ignoring the trailing garbage. >> done > > Are you appling this to the linux-next tree? Or Linus's tree? I just > get a failure against linux-next. I'm applying it to the Linus's tree. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
On Fri, Nov 20, 2009 at 07:22:59PM -0200, Thiago Farina wrote: > On Fri, Nov 20, 2009 at 6:15 PM, Greg KH <greg@kroah.com> wrote: > > On Fri, Nov 20, 2009 at 06:09:09PM -0200, Thiago Farina wrote: > >> On Fri, Nov 20, 2009 at 5:22 PM, Greg KH <greg@kroah.com> wrote: > >> > On Fri, Nov 20, 2009 at 05:18:09PM -0200, Thiago Farina wrote: > >> >> Hi Greg, > >> >> > >> >> On Thu, Nov 19, 2009 at 5:34 PM, Greg KH <greg@kroah.com> wrote: > >> >> > On Fri, Nov 06, 2009 at 11:45:05PM -0200, Thiago Farina wrote: > >> >> >> *apdbg.c: use NULL pointer instead of 0 integer. > >> >> >> > >> >> >> Signed-off-by: Thiago Farina <tfransosi@gmail.com> > >> >> > > >> >> > Still doesn't apply, I don't know what you are doing wrong here :( > >> >> > > >> >> > odd. > >> >> > >> >> How are you applying it? > >> > > >> > 'patch -p1 < your_email' > >> > >> Are you getting something like: "Hmm... Ignoring the trailing garbage." ? > >> > >> The output for me was this: > >> ... > >> Patching file drivers/staging/otus/apdbg.c using Plan A... > >> Hunk #1 succeeded at 109. > >> Hunk #2 succeeded at 123. > >> Hmm... Ignoring the trailing garbage. > >> done > > > > Are you appling this to the linux-next tree? Or Linus's tree? I just > > get a failure against linux-next. > > I'm applying it to the Linus's tree. Please generate it against linux-next, as there are already otus patches in my tree, which is included in the linux-next snapshots. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Patch
diff --git a/drivers/staging/otus/apdbg.c b/drivers/staging/otus/apdbg.c index d3e2f62..70a40b8 100644 --- a/drivers/staging/otus/apdbg.c +++ b/drivers/staging/otus/apdbg.c @@ -109,7 +109,7 @@ int set_ioctl(int sock, struct ifreq *req) int read_reg(int sock, struct ifreq *req) { - struct zdap_ioctl *zdreq = 0; + struct zdap_ioctl *zdreq = NULL; if (!set_ioctl(sock, req)) return -1; @@ -123,7 +123,7 @@ int read_reg(int sock, struct ifreq *req) int read_mem(int sock, struct ifreq *req) { - struct zdap_ioctl *zdreq = 0; + struct zdap_ioctl *zdreq = NULL; int i; if (!set_ioctl(sock, req))
*apdbg.c: use NULL pointer instead of 0 integer. Signed-off-by: Thiago Farina <tfransosi@gmail.com> --- drivers/staging/otus/apdbg.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/