[RFCv2,0/5] Using l_notice for low level IWD state information

Message

James Prestwood Feb. 15, 2024, 1:53 p.m. UTC

v2:
 * Removed use of station_debug_event for notice logs
 * Added iwd_notice to wrap l_notice:
     1. To aid in enforcement of the formatting
     2. To make it easier to enforce proper notice use during patch
        review, so people aren't calling l_notice directly.
   If we want a separate header for this thats fine, I just put it in
   iwd.h for now.
 * Made notice events constant defines. Using enums would be nice but
   in order to specify and event + formatting string constant strings
   were the only simple way to do that without reading in each
   argument via va_args. If anyone has better ideas I'm open to them.
 * Please don't merge this, I still want to get more events added and
   make sure its as easy as possible to write tooling before we
   upstream. With this RFC I merely wanted to get feedback on how
   we should do this, not necissarily specifics on what events we
   should/shouldn't be logging.

James Prestwood (5):
  main: add runtime flag for setting the logger
  iwd: add iwd_notice for special event/state type of logging
  doc: document use of l_log APIs
  station: use iwd_notice for state/event information
  netdev: add notice events for connection timeouts

 doc/coding-style.txt | 15 +++++++++++++++
 src/iwd.h            | 13 +++++++++++++
 src/main.c           | 14 ++++++++++++--
 src/netdev.c         |  7 ++++---
 src/station.c        | 32 +++++++++++++++++++++++++-------
 5 files changed, 69 insertions(+), 12 deletions(-)