diff mbox series

client: avoid segfault in iwctl quit

Message ID 20230502084831.60016-1-ronan@rjp.ie (mailing list archive)
State New
Headers show
Series client: avoid segfault in iwctl quit | expand

Checks

Context Check Description
tedd_an/pre-ci_am fail error: patch failed: client/display.c:890 error: client/display.c: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch

Commit Message

Ronan Pigott May 2, 2023, 8:48 a.m. UTC 
iwctl quit (running quit non-interactively) isn't a useful command,
but it shouldn't segfault. Let's avoid calling readline functions if
we haven't initialized readline in this run.
---
 client/display.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Denis Kenzior May 7, 2023, 11:03 p.m. UTC | #1 
Hi Ronan,

On 5/2/23 03:48, Ronan Pigott wrote:
> iwctl quit (running quit non-interactively) isn't a useful command,
> but it shouldn't segfault. Let's avoid calling readline functions if
> we haven't initialized readline in this run.
> ---
>   client/display.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Regards,
-Denis
diff mbox series

Patch

diff --git a/client/display.c b/client/display.c
index 59086642c273..8b06ff58384b 100644
--- a/client/display.c
+++ b/client/display.c
@@ -890,7 +890,8 @@  void display_agent_prompt_release(const char *label)
 
 void display_quit(void)
 {
-	rl_crlf();
+	if (command_is_interactive_mode())
+		rl_crlf();
 }
 
 static void window_change_signal_handler(void *user_data)