mbox series

[v4,0/4] Add a property to turn off the max touch controller if not used

Message ID 20240417090527.15357-1-eichest@gmail.com (mailing list archive)
Headers show
Series Add a property to turn off the max touch controller if not used | expand

Message

Stefan Eichenberger April 17, 2024, 9:05 a.m. UTC
Our hardware has a shared regulator that powers various peripherals such
as the display, touch, USB hub, etc. Since the Maxtouch controller
doesn't currently allow it to be turned off, this regulator has to stay
on when not used. This increases the overall power consumption. In order
to turn off the controller when the system does not use it, this series
adds a device tree property to the maxtouch driver that allows the
controller to be turned off completely and ensurs that it can resume
from the power off state.

Changes since v3:
- Move the power on part to mxt_start and the power off part to
  mxt_stop. This allows to turn the touch controller off even when not
  in use and not only when being suspended (Dmitry)

Changes since v2:
- Add Reviewed-by tags from Linus and Krzysztof to the dt-bindings patch

Changes since v1:
- Rename the property and change the description (Krzysztof, Linus,
Dmitry, Conor)

Stefan Eichenberger (4):
  Input: atmel_mxt_ts - add power off and power on functions
  Input: atmel_mxt_ts - move calls to register the input device to
    separate function
  dt-bindings: input: atmel,maxtouch: add poweroff-sleep property
  Input: atmel_mxt_ts - add support for poweroff-sleep

 .../bindings/input/atmel,maxtouch.yaml        |   6 +
 drivers/input/touchscreen/atmel_mxt_ts.c      | 162 +++++++++++++-----
 2 files changed, 124 insertions(+), 44 deletions(-)

Comments

João Paulo Gonçalves April 17, 2024, 11:12 a.m. UTC | #1
> Our hardware has a shared regulator that powers various peripherals such
> as the display, touch, USB hub, etc. Since the Maxtouch controller
> doesn't currently allow it to be turned off, this regulator has to stay
> on when not used. This increases the overall power consumption. In order
> to turn off the controller when the system does not use it, this series
> adds a device tree property to the maxtouch driver that allows the
> controller to be turned off completely and ensurs that it can resume
> from the power off state.
>
> Changes since v3:
> - Move the power on part to mxt_start and the power off part to
>   mxt_stop. This allows to turn the touch controller off even when not
>   in use and not only when being suspended (Dmitry)
>
> Changes since v2:
> - Add Reviewed-by tags from Linus and Krzysztof to the dt-bindings patch
>
> Changes since v1:
> - Rename the property and change the description (Krzysztof, Linus,
> Dmitry, Conor)
>
> Stefan Eichenberger (4):
>   Input: atmel_mxt_ts - add power off and power on functions
>   Input: atmel_mxt_ts - move calls to register the input device to
>     separate function
>   dt-bindings: input: atmel,maxtouch: add poweroff-sleep property
>   Input: atmel_mxt_ts - add support for poweroff-sleep
>
>  .../bindings/input/atmel,maxtouch.yaml        |   6 +
>  drivers/input/touchscreen/atmel_mxt_ts.c      | 162 +++++++++++++-----
>  2 files changed, 124 insertions(+), 44 deletions(-)
>
> --
> 2.40.1
>

Reviewed-by: Joao Paulo Goncalves <joao.goncalves@toradex.com>

Regards,
Joao Paulo