| Message ID | 5b4831407a68c22fbc63c7d29dd608ebfdd4cef2.1649443080.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" | expand |
On 08/04/2022 20:37, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: rtc@10003000: compatible: 'oneOf' conditional failed, one must be fixed: > ['ingenic,jz4780-rtc'] is too short > 'ingenic,jz4780-rtc' is not one of ['ingenic,jz4740-rtc', 'ingenic,jz4760-rtc'] > 'ingenic,jz4725b-rtc' was expected > From schema: Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml Why? Maybe the schema is wrong. These devices might not be compatible. Best regards, Krzysztof
> Am 09.04.2022 um 13:14 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 08/04/2022 20:37, H. Nikolaus Schaller wrote: >> arch/mips/boot/dts/ingenic/ci20.dtb: rtc@10003000: compatible: 'oneOf' conditional failed, one must be fixed: >> ['ingenic,jz4780-rtc'] is too short >> 'ingenic,jz4780-rtc' is not one of ['ingenic,jz4740-rtc', 'ingenic,jz4760-rtc'] >> 'ingenic,jz4725b-rtc' was expected >> From schema: Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml > > Why? Maybe the schema is wrong. These devices might not be compatible. Here you may be right that the .yaml is wrong. Paul?
diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi index b5299eaffb84a..2021836983c96 100644 --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi @@ -145,7 +145,8 @@ ost: timer@e0 { }; rtc_dev: rtc@10003000 { - compatible = "ingenic,jz4780-rtc"; + compatible = "ingenic,jz4780-rtc", + "ingenic,jz4760-rtc"; reg = <0x10003000 0x4c>; interrupt-parent = <&intc>;
arch/mips/boot/dts/ingenic/ci20.dtb: rtc@10003000: compatible: 'oneOf' conditional failed, one must be fixed: ['ingenic,jz4780-rtc'] is too short 'ingenic,jz4780-rtc' is not one of ['ingenic,jz4740-rtc', 'ingenic,jz4760-rtc'] 'ingenic,jz4725b-rtc' was expected From schema: Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/boot/dts/ingenic/jz4780.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)