Message ID | 20210721151620.2373500-1-arnd@kernel.org (mailing list archive) |
---|---|
State | Queued |
Headers | show |
Series | ARM: ixp4xx: goramo_mlr depends on old PCI driver | expand |
On Wed, Jul 21, 2021 at 5:16 PM Arnd Bergmann <arnd@kernel.org> wrote: > From: Arnd Bergmann <arnd@arndb.de> > > When this driver is disabled, the board file fails to build, > so add a dependency: > > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit': > arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration] > 472 | ixp4xx_pci_preinit(); > | ^~~~~~~~~~~~~~~~~~ > | iop3xx_pci_preinit > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit': > arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration] > 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) { > | ^~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function) > 231 | .start = IXP4XX_UART1_BASE_PHYS, > | ^~~~~~~~~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init': > arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration] > 376 | ixp4xx_sys_init(); > | ^~~~~~~~~~~~~~~ > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: soc@kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Ooops Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
From: Arnd Bergmann <arnd@arndb.de> On Wed, 21 Jul 2021 17:16:04 +0200, Arnd Bergmann wrote: > When this driver is disabled, the board file fails to build, > so add a dependency: > > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_preinit': > arch/arm/mach-ixp4xx/goramo_mlr.c:472:9: error: implicit declaration of function 'ixp4xx_pci_preinit'; did you mean 'iop3xx_pci_preinit'? [-Werror=implicit-function-declaration] > 472 | ixp4xx_pci_preinit(); > | ^~~~~~~~~~~~~~~~~~ > | iop3xx_pci_preinit > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_pci_postinit': > arch/arm/mach-ixp4xx/goramo_mlr.c:481:22: error: implicit declaration of function 'ixp4xx_pci_read' [-Werror=implicit-function-declaration] > 481 | if (!ixp4xx_pci_read(addr, NP_CMD_CONFIGREAD, &value)) { > | ^~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/goramo_mlr.c:231:35: error: 'IXP4XX_UART1_BASE_PHYS' undeclared here (not in a function) > 231 | .start = IXP4XX_UART1_BASE_PHYS, > | ^~~~~~~~~~~~~~~~~~~~~~ > arch/arm/mach-ixp4xx/goramo_mlr.c: In function 'gmlr_init': > arch/arm/mach-ixp4xx/goramo_mlr.c:376:9: error: implicit declaration of function 'ixp4xx_sys_init' [-Werror=implicit-function-declaration] > 376 | ixp4xx_sys_init(); > | ^~~~~~~~~~~~~~~ Applied to arm/fixes, thanks! [1/1] ARM: ixp4xx: goramo_mlr depends on old PCI driver commit: 796a8c85b1216618258e08b463d3bef0d7123760 Arnd
diff --git a/arch/arm/mach-ixp4xx/Kconfig b/arch/arm/mach-ixp4xx/Kconfig index bf14d65120b9..34a1c7742088 100644 --- a/arch/arm/mach-ixp4xx/Kconfig +++ b/arch/arm/mach-ixp4xx/Kconfig @@ -91,6 +91,7 @@ config MACH_IXDP465 config MACH_GORAMO_MLR bool "GORAMO Multi Link Router" + depends on IXP4XX_PCI_LEGACY help Say 'Y' here if you want your kernel to support GORAMO MultiLink router.