diff mbox series

watchdog: it87_wdt: add IT8613 ID

Message ID 3bc0a1c2d768b23a0cd6e9f5fa0c0b5577427668.camel@wefi.net (mailing list archive)
State New
Headers show
Series watchdog: it87_wdt: add IT8613 ID | expand

Commit Message

Werner Fischer Sept. 25, 2023, 1:09 p.m. UTC
This patch adds watchdog support for the ITE IT8613 watchdog.
IT8613 watchdog works in the same way as the other watchdogs supported
by it87_wdt.

Before this patch, IT8613 watchdog is not supported. After a modprobe,
dmesg reports:
  it87_wdt: Unknown Chip found, Chip 8613 Revision 000c
With this patch, modprobe it87_wdt recognizes the watchdog as the dmesg
output shows:
  it87_wdt: Chip IT8613 revision 12 initialized. timeout=60 sec (nowayout=0 testmode=0)

Watchdog tests on a LES v4 have been successful, the watchdog works as
expected with this patch [1].

[1] https://www.thomas-krenn.com/en/wiki/Watchdog#LES_v4

Signed-off-by: Werner Fischer <devlists@wefi.net>
---

Comments

Guenter Roeck Sept. 25, 2023, 4:33 p.m. UTC | #1
On Mon, Sep 25, 2023 at 03:09:46PM +0200, Werner Fischer wrote:
> This patch adds watchdog support for the ITE IT8613 watchdog.
> IT8613 watchdog works in the same way as the other watchdogs supported
> by it87_wdt.
> 
> Before this patch, IT8613 watchdog is not supported. After a modprobe,
> dmesg reports:
>   it87_wdt: Unknown Chip found, Chip 8613 Revision 000c
> With this patch, modprobe it87_wdt recognizes the watchdog as the dmesg
> output shows:
>   it87_wdt: Chip IT8613 revision 12 initialized. timeout=60 sec (nowayout=0 testmode=0)
> 
> Watchdog tests on a LES v4 have been successful, the watchdog works as
> expected with this patch [1].
> 
> [1] https://www.thomas-krenn.com/en/wiki/Watchdog#LES_v4
> 
> Signed-off-by: Werner Fischer <devlists@wefi.net>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
> 
> --- a/drivers/watchdog/it87_wdt.c	2023-09-25 15:03:52.986033681 +0200
> +++ b/drivers/watchdog/it87_wdt.c	2023-09-25 15:03:36.046415573 +0200
> @@ -13,9 +13,9 @@
>   *		    http://www.ite.com.tw/
>   *
>   *	Support of the watchdog timers, which are available on
> - *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
> - *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
> - *	IT8772, IT8783 and IT8784.
> + *	IT8607, IT8613, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665,
> + *	IT8686, IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726,
> + *	IT8728, IT8772, IT8783 and IT8784.
>   */
>  
>  #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> @@ -50,6 +50,7 @@
>  /* Chip Id numbers */
>  #define NO_DEV_ID	0xffff
>  #define IT8607_ID	0x8607
> +#define IT8613_ID	0x8613
>  #define IT8620_ID	0x8620
>  #define IT8622_ID	0x8622
>  #define IT8625_ID	0x8625
> @@ -277,6 +278,7 @@
>  		max_units = 65535;
>  		break;
>  	case IT8607_ID:
> +	case IT8613_ID:
>  	case IT8620_ID:
>  	case IT8622_ID:
>  	case IT8625_ID:
>
diff mbox series

Patch

--- a/drivers/watchdog/it87_wdt.c	2023-09-25 15:03:52.986033681 +0200
+++ b/drivers/watchdog/it87_wdt.c	2023-09-25 15:03:36.046415573 +0200
@@ -13,9 +13,9 @@ 
  *		    http://www.ite.com.tw/
  *
  *	Support of the watchdog timers, which are available on
- *	IT8607, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665, IT8686,
- *	IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726, IT8728,
- *	IT8772, IT8783 and IT8784.
+ *	IT8607, IT8613, IT8620, IT8622, IT8625, IT8628, IT8655, IT8665,
+ *	IT8686, IT8702, IT8712, IT8716, IT8718, IT8720, IT8721, IT8726,
+ *	IT8728, IT8772, IT8783 and IT8784.
  */
 
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
@@ -50,6 +50,7 @@ 
 /* Chip Id numbers */
 #define NO_DEV_ID	0xffff
 #define IT8607_ID	0x8607
+#define IT8613_ID	0x8613
 #define IT8620_ID	0x8620
 #define IT8622_ID	0x8622
 #define IT8625_ID	0x8625
@@ -277,6 +278,7 @@ 
 		max_units = 65535;
 		break;
 	case IT8607_ID:
+	case IT8613_ID:
 	case IT8620_ID:
 	case IT8622_ID:
 	case IT8625_ID: