| Message ID | 1418655734-32475-1-git-send-email-kris@konagma.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Krzysztof Konopko <kris@konagma.com> writes: > Some struct fields in wifi.h are meant to be __le16 but were declared as > unsigned short. This was reported by sparse: > > rtw_wlan_util.c:538:24: warning: cast to restricted __le16 > rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 > rtw_wlan_util.c:1546:25: warning: cast to restricted __le16 > > This patch updates the types of the fields in `AC_param` and > `ADDBA_request` structs to be consistent with relevant structs in > include/linux/ieee80211.h. > > Signed-off-by: Krzysztof Konopko <kris@konagma.com> > --- > drivers/staging/rtl8723au/include/wifi.h | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Well the u8 change is really in the nit picking space, but I am fine with that too. Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com> > > diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h > index fd3da3b..25d573c 100644 > --- a/drivers/staging/rtl8723au/include/wifi.h > +++ b/drivers/staging/rtl8723au/include/wifi.h > @@ -26,9 +26,9 @@ > ------------------------------------------------------------------------------*/ > > struct AC_param { > - unsigned char ACI_AIFSN; > - unsigned char CW; > - unsigned short TXOP_limit; > + u8 ACI_AIFSN; > + u8 CW; > + __le16 TXOP_limit; > } __packed; > > struct WMM_para_element { > @@ -38,10 +38,10 @@ struct WMM_para_element { > } __packed; > > struct ADDBA_request { > - unsigned char dialog_token; > - unsigned short BA_para_set; > - unsigned short BA_timeout_value; > - unsigned short BA_starting_seqctrl; > + u8 dialog_token; > + __le16 BA_para_set; > + __le16 BA_timeout_value; > + __le16 BA_starting_seqctrl; > } __packed; -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/rtl8723au/include/wifi.h b/drivers/staging/rtl8723au/include/wifi.h index fd3da3b..25d573c 100644 --- a/drivers/staging/rtl8723au/include/wifi.h +++ b/drivers/staging/rtl8723au/include/wifi.h @@ -26,9 +26,9 @@ ------------------------------------------------------------------------------*/ struct AC_param { - unsigned char ACI_AIFSN; - unsigned char CW; - unsigned short TXOP_limit; + u8 ACI_AIFSN; + u8 CW; + __le16 TXOP_limit; } __packed; struct WMM_para_element { @@ -38,10 +38,10 @@ struct WMM_para_element { } __packed; struct ADDBA_request { - unsigned char dialog_token; - unsigned short BA_para_set; - unsigned short BA_timeout_value; - unsigned short BA_starting_seqctrl; + u8 dialog_token; + __le16 BA_para_set; + __le16 BA_timeout_value; + __le16 BA_starting_seqctrl; } __packed;
Some struct fields in wifi.h are meant to be __le16 but were declared as unsigned short. This was reported by sparse: rtw_wlan_util.c:538:24: warning: cast to restricted __le16 rtw_wlan_util.c:1544:29: warning: cast to restricted __le16 rtw_wlan_util.c:1546:25: warning: cast to restricted __le16 This patch updates the types of the fields in `AC_param` and `ADDBA_request` structs to be consistent with relevant structs in include/linux/ieee80211.h. Signed-off-by: Krzysztof Konopko <kris@konagma.com> --- drivers/staging/rtl8723au/include/wifi.h | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)