diff mbox

[1/4] mwifiex: enable -D__CHECK_ENDIAN__ for sparse by default

Message ID 1418817273-22669-1-git-send-email-patila@marvell.com (mailing list archive)
State Not Applicable
Headers show

Commit Message

Avinash Patil Dec. 17, 2014, 11:54 a.m. UTC
Enable the endian checks by default.

Signed-off-by: Avinash Patil <patila@marvell.com>
---
 drivers/net/wireless/mwifiex/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Joe Perches Dec. 17, 2014, 9:41 a.m. UTC | #1
On Wed, 2014-12-17 at 17:24 +0530, Avinash Patil wrote:
> Enable the endian checks by default.
[]
> diff --git a/drivers/net/wireless/mwifiex/Makefile b/drivers/net/wireless/mwifiex/Makefile
[]
> @@ -53,3 +53,5 @@ obj-$(CONFIG_MWIFIEX_PCIE) += mwifiex_pcie.o
>  
>  mwifiex_usb-y += usb.o
>  obj-$(CONFIG_MWIFIEX_USB) += mwifiex_usb.o
> +
> +ccflags-y += -D__CHECK_ENDIAN__ -DDEBUG

I think the -DDEBUG should not be there.

This also forces all the dev_dbg / wiphy_dbg
statement to always be emitted.


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Avinash Patil Dec. 17, 2014, 10:30 a.m. UTC | #2
Thanks for review, Joe.

I will send v2 with -DDEBUG removed.

Thanks,
Avinash
diff mbox

Patch

diff --git a/drivers/net/wireless/mwifiex/Makefile b/drivers/net/wireless/mwifiex/Makefile
index 9487d72..5a8ecad 100644
--- a/drivers/net/wireless/mwifiex/Makefile
+++ b/drivers/net/wireless/mwifiex/Makefile
@@ -53,3 +53,5 @@  obj-$(CONFIG_MWIFIEX_PCIE) += mwifiex_pcie.o
 
 mwifiex_usb-y += usb.o
 obj-$(CONFIG_MWIFIEX_USB) += mwifiex_usb.o
+
+ccflags-y += -D__CHECK_ENDIAN__ -DDEBUG