| Message ID | 1250822966.5248.6.camel@shinel (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, Aug 20, 2009 at 10:49 PM, Shine Liu<shinel@foxmail.com> wrote: > I think we should call em28xx_ir_init(dev) when disable_ir is true. > Following patch will fix the bug. > > Cheers, > > Shine Yeah, this looks reasonable. I must have just accidentally cut the code when I refactored the onboard IR support (as opposed to external i2c IR). In reality I really should take another pass over how the IR registers are configured since currently we rely on the XCLK field definition in the board configuration to setup the IR, which prevents you from switching remote control modes between NEC/RC5/RC6, etc. Reviewed-by: Devin Heitmueller <dheitmueller@kernellabs.com> Thanks, Devin
--- a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-14 06:43:34.000000000 +0800 +++ a/drivers/media/video/em28xx/em28xx-cards.c 2009-08-21 10:39:23.000000000 +0800 @@ -2367,7 +2367,9 @@ } em28xx_tuner_setup(dev); - em28xx_ir_init(dev); + + if(!disable_ir) + em28xx_ir_init(dev); }
I think we should call em28xx_ir_init(dev) when disable_ir is true. Following patch will fix the bug. Cheers, Shine Signed-off-by: Shine Liu <shinel@foxmail.com> ----------------------------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html