| Message ID | 1403293903-17696-1-git-send-email-linux@rasmusvillemoes.dk (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On 06/20/2014 12:51 PM, Rasmus Villemoes wrote: > Maybe "else if" was meant, but because of the goto out_unlock, it > doesn't make a difference. Anyway, I chose the "only whitespace" fix. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > fs/btrfs/tree-log.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c > index 9e1f2cd..50af2b9 100644 > --- a/fs/btrfs/tree-log.c > +++ b/fs/btrfs/tree-log.c > @@ -3980,7 +3980,8 @@ again: > if (ret < 0) { > err = ret; > goto out_unlock; > - } if (ret) { > + } > + if (ret) { > ins_nr = 0; > btrfs_release_path(path); > continue; > Nope that's right, thanks, Reviewed-by: Josef Bacik <jbacik@fb.com> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Josef Bacik <jbacik@fb.com> writes: > On 06/20/2014 12:51 PM, Rasmus Villemoes wrote: >> Maybe "else if" was meant, but because of the goto out_unlock, it >> doesn't make a difference. Anyway, I chose the "only whitespace" fix. >> >> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> >> --- >> fs/btrfs/tree-log.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c >> index 9e1f2cd..50af2b9 100644 >> --- a/fs/btrfs/tree-log.c >> +++ b/fs/btrfs/tree-log.c >> @@ -3980,7 +3980,8 @@ again: >> if (ret < 0) { >> err = ret; >> goto out_unlock; >> - } if (ret) { >> + } >> + if (ret) { >> ins_nr = 0; >> btrfs_release_path(path); >> continue; >> > > Nope that's right, thanks, > > Reviewed-by: Josef Bacik <jbacik@fb.com> Was this picked up? I don't see it upstream. Thanks, Rasmus -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c index 9e1f2cd..50af2b9 100644 --- a/fs/btrfs/tree-log.c +++ b/fs/btrfs/tree-log.c @@ -3980,7 +3980,8 @@ again: if (ret < 0) { err = ret; goto out_unlock; - } if (ret) { + } + if (ret) { ins_nr = 0; btrfs_release_path(path); continue;
Maybe "else if" was meant, but because of the goto out_unlock, it doesn't make a difference. Anyway, I chose the "only whitespace" fix. Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> --- fs/btrfs/tree-log.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)