| Message ID | 1408818808-18850-7-git-send-email-Julia.Lawall@lip6.fr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > --- > The patches in this series do not depend on each other. > > This changes the semantics of the code and is not tested. Hence I think you should change the subject of the patch, so it's obvious some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". > drivers/video/fbdev/sis/init301.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > index a89e3ca..295e0de 100644 > --- a/drivers/video/fbdev/sis/init301.c > +++ b/drivers/video/fbdev/sis/init301.c > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > } else { > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 24 Aug 2014, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: > > --- > > The patches in this series do not depend on each other. > > > > This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Do you want me to resend this patch with the new subject, or just keep it in mind for the future? thanks, julia > > > drivers/video/fbdev/sis/init301.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c > > index a89e3ca..295e0de 100644 > > --- a/drivers/video/fbdev/sis/init301.c > > +++ b/drivers/video/fbdev/sis/init301.c > > @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh > > SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ > > } else { > > SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; > > - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; > > + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > -- > To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Julia, On Sun, Aug 24, 2014 at 8:40 PM, Julia Lawall <julia.lawall@lip6.fr> wrote: >> On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: >> > --- >> > The patches in this series do not depend on each other. >> > >> > This changes the semantics of the code and is not tested. >> >> Hence I think you should change the subject of the patch, so it's obvious >> some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". > > Do you want me to resend this patch with the new subject, or just keep it > in mind for the future? That's up to the fbdev maintainer. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 24/08/14 21:21, Geert Uytterhoeven wrote: > On Sat, Aug 23, 2014 at 8:33 PM, Julia Lawall <Julia.Lawall@lip6.fr> wrote: >> --- >> The patches in this series do not depend on each other. >> >> This changes the semantics of the code and is not tested. > > Hence I think you should change the subject of the patch, so it's obvious > some bug is fixed, e.g. "video: fbdev: sis: Fix double assignment". Well, to me "fix double assignment" sounds the same as "delete double assignment". Looking at the code, I think what's done here is "fix 1280x768 panel timings". I can apply this and do the change to subject, if nobody complains. Tomi
diff --git a/drivers/video/fbdev/sis/init301.c b/drivers/video/fbdev/sis/init301.c index a89e3ca..295e0de 100644 --- a/drivers/video/fbdev/sis/init301.c +++ b/drivers/video/fbdev/sis/init301.c @@ -1714,7 +1714,7 @@ SiS_GetLCDResInfo(struct SiS_Private *SiS_Pr, unsigned short ModeNo, unsigned sh SiS_Pr->PanelVCLKIdx315 = VCLK81_315; /* ? */ } else { SiS_Pr->PanelHT = 1688; SiS_Pr->PanelVT = 802; - SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRS = 112; + SiS_Pr->PanelHRS = 48; SiS_Pr->PanelHRE = 112; SiS_Pr->PanelVRS = 3; SiS_Pr->PanelVRE = 6; SiS_Pr->PanelVCLKIdx300 = VCLK81_300; SiS_Pr->PanelVCLKIdx315 = VCLK81_315;