diff mbox

saa7134: start to investigate the LNA mess on 310i and hvr1110 products

Message ID 1250812164.3249.18.camel@pc07.localdom.local (mailing list archive)
State RFC
Headers show

Commit Message

hermann pitton Aug. 20, 2009, 11:49 p.m. UTC 
There is a great maintenance mess for those devices currently.

All attempts, to get some further information out of those assumed to be
closest to the above manufactures, failed.

Against any previous advice, newer products with an additional LNA,
which needs to be configured correctly, have been added and we can't
make any difference to previous products without LNA.

Even more, the type of LNA configuration, either over tuner gain or some
on the analog IF demodulator, conflicts within this two devices itself.

Since we never had a chance, to see such devices with all details
reported to our lists, but might still be able to make eventually a
difference, to get out of that mess, we should prefer to start exactly
where it started.

Signed-off-by: hermann pitton <hermann-pitton@arcor.de>

diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Thu Aug 20
01:30:58 2009 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Fri Aug 21
01:28:37 2009 +0200
@@ -3242,7 +3242,7 @@
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
-		.tuner_config   = 1,
+		.tuner_config   = 0,
 		.mpeg           = SAA7134_MPEG_DVB,
 		.gpiomask       = 0x000200000,
 		.inputs         = {{
@@ -3346,7 +3346,7 @@
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
-		.tuner_config   = 1,
+		.tuner_config   = 0,
 		.mpeg           = SAA7134_MPEG_DVB,
 		.gpiomask       = 0x0200100,
 		.inputs         = {{
diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c
--- a/linux/drivers/media/video/saa7134/saa7134-dvb.c	Thu Aug 20
01:30:58 2009 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c	Fri Aug 21
01:28:37 2009 +0200
@@ -1144,12 +1144,12 @@
 		break;
 	case SAA7134_BOARD_PINNACLE_PCTV_310i:
 		if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config,
-					 &tda827x_cfg_1) < 0)
+					 &tda827x_cfg_0) < 0)
 			goto dettach_frontend;
 		break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
 		if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config,
-					 &tda827x_cfg_1) < 0)
+					 &tda827x_cfg_0) < 0)
 			goto dettach_frontend;
 		break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1150:

Comments

hermann pitton Aug. 23, 2009, 1:54 a.m. UTC | #1 
Am Freitag, den 21.08.2009, 01:49 +0200 schrieb hermann pitton:
> There is a great maintenance mess for those devices currently.
> 
> All attempts, to get some further information out of those assumed to be
> closest to the above manufactures, failed.
> 
> Against any previous advice, newer products with an additional LNA,
> which needs to be configured correctly, have been added and we can't
> make any difference to previous products without LNA.
> 
> Even more, the type of LNA configuration, either over tuner gain or some
> on the analog IF demodulator, conflicts within this two devices itself.
> 
> Since we never had a chance, to see such devices with all details
> reported to our lists, but might still be able to make eventually a
> difference, to get out of that mess, we should prefer to start exactly
> where it started.

Mauro, Douglas,

just mark it as an RFC.

Seems i lose any interest to follow up such further.

Never allow any guys to go out into the wild, ending up with that I have
to read their personal web blogs ..., out of lists.

Cheers,
Hermann


> Signed-off-by: hermann pitton <hermann-pitton@arcor.de>iff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c
> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Thu Aug 20
> 01:30:58 2009 +0000
> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Fri Aug 21
> 01:28:37 2009 +0200
> @@ -3242,7 +3242,7 @@
>  		.radio_type     = UNSET,
>  		.tuner_addr     = ADDR_UNSET,
>  		.radio_addr     = ADDR_UNSET,
> -		.tuner_config   = 1,
> +		.tuner_config   = 0,
>  		.mpeg           = SAA7134_MPEG_DVB,
>  		.gpiomask       = 0x000200000,
>  		.inputs         = {{
> @@ -3346,7 +3346,7 @@
>  		.radio_type     = UNSET,
>  		.tuner_addr     = ADDR_UNSET,
>  		.radio_addr     = ADDR_UNSET,
> -		.tuner_config   = 1,
> +		.tuner_config   = 0,
>  		.mpeg           = SAA7134_MPEG_DVB,
>  		.gpiomask       = 0x0200100,
>  		.inputs         = {{
> diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c
> --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c	Thu Aug 20
> 01:30:58 2009 +0000
> +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c	Fri Aug 21
> 01:28:37 2009 +0200
> @@ -1144,12 +1144,12 @@
>  		break;
>  	case SAA7134_BOARD_PINNACLE_PCTV_310i:
>  		if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config,
> -					 &tda827x_cfg_1) < 0)
> +					 &tda827x_cfg_0) < 0)
>  			goto dettach_frontend;
>  		break;
>  	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
>  		if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config,
> -					 &tda827x_cfg_1) < 0)
> +					 &tda827x_cfg_0) < 0)
>  			goto dettach_frontend;
>  		break;
>  	case SAA7134_BOARD_HAUPPAUGE_HVR1150:
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Michael Krufky Aug. 24, 2009, 7:56 p.m. UTC | #2 
Hermann,

On Sat, Aug 22, 2009 at 9:54 PM, hermann pitton<hermann-pitton@arcor.de> wrote:
>
> Am Freitag, den 21.08.2009, 01:49 +0200 schrieb hermann pitton:
>> There is a great maintenance mess for those devices currently.
>>
>> All attempts, to get some further information out of those assumed to be
>> closest to the above manufactures, failed.
>>
>> Against any previous advice, newer products with an additional LNA,
>> which needs to be configured correctly, have been added and we can't
>> make any difference to previous products without LNA.
>>
>> Even more, the type of LNA configuration, either over tuner gain or some
>> on the analog IF demodulator, conflicts within this two devices itself.
>>
>> Since we never had a chance, to see such devices with all details
>> reported to our lists, but might still be able to make eventually a
>> difference, to get out of that mess, we should prefer to start exactly
>> where it started.
>
> Mauro, Douglas,
>
> just mark it as an RFC.
>
> Seems i lose any interest to follow up such further.
>
> Never allow any guys to go out into the wild, ending up with that I have
> to read their personal web blogs ..., out of lists.
>
> Cheers,
> Hermann
>
>
>> Signed-off-by: hermann pitton <hermann-pitton@arcor.de>iff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c
>> --- a/linux/drivers/media/video/saa7134/saa7134-cards.c       Thu Aug 20
>> 01:30:58 2009 +0000
>> +++ b/linux/drivers/media/video/saa7134/saa7134-cards.c       Fri Aug 21
>> 01:28:37 2009 +0200
>> @@ -3242,7 +3242,7 @@
>>               .radio_type     = UNSET,
>>               .tuner_addr     = ADDR_UNSET,
>>               .radio_addr     = ADDR_UNSET,
>> -             .tuner_config   = 1,
>> +             .tuner_config   = 0,
>>               .mpeg           = SAA7134_MPEG_DVB,
>>               .gpiomask       = 0x000200000,
>>               .inputs         = {{
>> @@ -3346,7 +3346,7 @@
>>               .radio_type     = UNSET,
>>               .tuner_addr     = ADDR_UNSET,
>>               .radio_addr     = ADDR_UNSET,
>> -             .tuner_config   = 1,
>> +             .tuner_config   = 0,
>>               .mpeg           = SAA7134_MPEG_DVB,
>>               .gpiomask       = 0x0200100,
>>               .inputs         = {{
>> diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c
>> --- a/linux/drivers/media/video/saa7134/saa7134-dvb.c Thu Aug 20
>> 01:30:58 2009 +0000
>> +++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c Fri Aug 21
>> 01:28:37 2009 +0200
>> @@ -1144,12 +1144,12 @@
>>               break;
>>       case SAA7134_BOARD_PINNACLE_PCTV_310i:
>>               if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config,
>> -                                      &tda827x_cfg_1) < 0)
>> +                                      &tda827x_cfg_0) < 0)
>>                       goto dettach_frontend;
>>               break;
>>       case SAA7134_BOARD_HAUPPAUGE_HVR1110:
>>               if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config,
>> -                                      &tda827x_cfg_1) < 0)
>> +                                      &tda827x_cfg_0) < 0)
>>                       goto dettach_frontend;
>>               break;
>>       case SAA7134_BOARD_HAUPPAUGE_HVR1150:
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>


NACK.

Please do not change the LNA configuration for the HVR1110 -- I cannot
speak for the PCTV device, but I looked at the schematics for the
HVR1110 -- the LNA configuration should not be changed.

Regards,

Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-cards.c
--- a/linux/drivers/media/video/saa7134/saa7134-cards.c	Thu Aug 20 01:30:58 2009 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-cards.c	Fri Aug 21 01:28:37 2009 +0200
@@ -3242,7 +3242,7 @@ 
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
-		.tuner_config   = 1,
+		.tuner_config   = 0,
 		.mpeg           = SAA7134_MPEG_DVB,
 		.gpiomask       = 0x000200000,
 		.inputs         = {{
@@ -3346,7 +3346,7 @@ 
 		.radio_type     = UNSET,
 		.tuner_addr     = ADDR_UNSET,
 		.radio_addr     = ADDR_UNSET,
-		.tuner_config   = 1,
+		.tuner_config   = 0,
 		.mpeg           = SAA7134_MPEG_DVB,
 		.gpiomask       = 0x0200100,
 		.inputs         = {{
diff -r d0ec20a376fe linux/drivers/media/video/saa7134/saa7134-dvb.c
--- a/linux/drivers/media/video/saa7134/saa7134-dvb.c	Thu Aug 20 01:30:58 2009 +0000
+++ b/linux/drivers/media/video/saa7134/saa7134-dvb.c	Fri Aug 21 01:28:37 2009 +0200
@@ -1144,12 +1144,12 @@ 
 		break;
 	case SAA7134_BOARD_PINNACLE_PCTV_310i:
 		if (configure_tda827x_fe(dev, &pinnacle_pctv_310i_config,
-					 &tda827x_cfg_1) < 0)
+					 &tda827x_cfg_0) < 0)
 			goto dettach_frontend;
 		break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1110:
 		if (configure_tda827x_fe(dev, &hauppauge_hvr_1110_config,
-					 &tda827x_cfg_1) < 0)
+					 &tda827x_cfg_0) < 0)
 			goto dettach_frontend;
 		break;
 	case SAA7134_BOARD_HAUPPAUGE_HVR1150: