diff mbox

cpufreq: s5pv210: Remove spurious __init annotation

Message ID 1409137227-27080-1-git-send-email-broonie@kernel.org (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Mark Brown Aug. 27, 2014, 11 a.m. UTC
From: Mark Brown <broonie@linaro.org>

Since this is a platform driver and can be probed at any time we can't
annotate funtions in the probe path as __init, the code can't safely be
discarded at the end of kernel init.

Signed-off-by: Mark Brown <broonie@linaro.org>
---
 drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Aug. 27, 2014, 11:04 a.m. UTC | #1
On 27 August 2014 16:30, Mark Brown <broonie@kernel.org> wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Since this is a platform driver and can be probed at any time we can't
> annotate funtions in the probe path as __init, the code can't safely be
> discarded at the end of kernel init.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>  drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> index 9a68225a757e..3f9791f07b8e 100644
> --- a/drivers/cpufreq/s5pv210-cpufreq.c
> +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
>         return val >> 8;
>  }
>
> -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
>  {
>         unsigned long mem_type;
>         int ret;

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki Aug. 27, 2014, 11:52 p.m. UTC | #2
On Wednesday, August 27, 2014 04:34:28 PM Viresh Kumar wrote:
> On 27 August 2014 16:30, Mark Brown <broonie@kernel.org> wrote:
> > From: Mark Brown <broonie@linaro.org>
> >
> > Since this is a platform driver and can be probed at any time we can't
> > annotate funtions in the probe path as __init, the code can't safely be
> > discarded at the end of kernel init.
> >
> > Signed-off-by: Mark Brown <broonie@linaro.org>
> > ---
> >  drivers/cpufreq/s5pv210-cpufreq.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
> > index 9a68225a757e..3f9791f07b8e 100644
> > --- a/drivers/cpufreq/s5pv210-cpufreq.c
> > +++ b/drivers/cpufreq/s5pv210-cpufreq.c
> > @@ -501,7 +501,7 @@ static int check_mem_type(void __iomem *dmc_reg)
> >         return val >> 8;
> >  }
> >
> > -static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
> > +static int s5pv210_cpu_init(struct cpufreq_policy *policy)
> >  {
> >         unsigned long mem_type;
> >         int ret;
> 
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

Queued up for 3.17-rc3, thanks!
diff mbox

Patch

diff --git a/drivers/cpufreq/s5pv210-cpufreq.c b/drivers/cpufreq/s5pv210-cpufreq.c
index 9a68225a757e..3f9791f07b8e 100644
--- a/drivers/cpufreq/s5pv210-cpufreq.c
+++ b/drivers/cpufreq/s5pv210-cpufreq.c
@@ -501,7 +501,7 @@  static int check_mem_type(void __iomem *dmc_reg)
 	return val >> 8;
 }
 
-static int __init s5pv210_cpu_init(struct cpufreq_policy *policy)
+static int s5pv210_cpu_init(struct cpufreq_policy *policy)
 {
 	unsigned long mem_type;
 	int ret;