| Message ID | 1409212920-28526-6-git-send-email-gautam.vivek@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
2014-08-28 10:02 GMT+02:00 Vivek Gautam: > This USB 3.0 PHY controller is also present on Exynos7 > platform, so adding the dependency on ARCH_EXYNOS7 for this driver. > +++ b/drivers/phy/Kconfig > @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 > > config PHY_EXYNOS5_USBDRD > tristate "Exynos5 SoC series USB DRD PHY driver" > - depends on ARCH_EXYNOS5 && OF > + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF shouldn't that prompt and its help text be updated to mention also Exynos7?
On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi <dforsi@gmail.com> wrote: > 2014-08-28 10:02 GMT+02:00 Vivek Gautam: > >> This USB 3.0 PHY controller is also present on Exynos7 >> platform, so adding the dependency on ARCH_EXYNOS7 for this driver. > >> +++ b/drivers/phy/Kconfig >> @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 >> >> config PHY_EXYNOS5_USBDRD >> tristate "Exynos5 SoC series USB DRD PHY driver" >> - depends on ARCH_EXYNOS5 && OF >> + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF > > shouldn't that prompt and its help text be updated to mention also Exynos7? Right, even that has to be updated accordingly. Will update the same in next version of the patch. Thanks for pointing this.
On Mon, Sep 01, 2014 at 01:30:21PM +0530, Vivek Gautam wrote: > On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi <dforsi@gmail.com> wrote: > > 2014-08-28 10:02 GMT+02:00 Vivek Gautam: > > > >> This USB 3.0 PHY controller is also present on Exynos7 > >> platform, so adding the dependency on ARCH_EXYNOS7 for this driver. > > > >> +++ b/drivers/phy/Kconfig > >> @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 > >> > >> config PHY_EXYNOS5_USBDRD > >> tristate "Exynos5 SoC series USB DRD PHY driver" > >> - depends on ARCH_EXYNOS5 && OF > >> + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF > > > > shouldn't that prompt and its help text be updated to mention also Exynos7? > > Right, even that has to be updated accordingly. Will update the same in next > version of the patch. Thanks for pointing this. I would rather change that to ARCH_EXYNOS, unless Kishon doesn't like that idea. The thing is that this will likely need to be patches for exynos8, 9, 10, 11... cheers
On Tue, Sep 2, 2014 at 8:07 PM, Felipe Balbi <balbi@ti.com> wrote: > On Mon, Sep 01, 2014 at 01:30:21PM +0530, Vivek Gautam wrote: >> On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi <dforsi@gmail.com> wrote: >> > 2014-08-28 10:02 GMT+02:00 Vivek Gautam: >> > >> >> This USB 3.0 PHY controller is also present on Exynos7 >> >> platform, so adding the dependency on ARCH_EXYNOS7 for this driver. >> > >> >> +++ b/drivers/phy/Kconfig >> >> @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 >> >> >> >> config PHY_EXYNOS5_USBDRD >> >> tristate "Exynos5 SoC series USB DRD PHY driver" >> >> - depends on ARCH_EXYNOS5 && OF >> >> + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF >> > >> > shouldn't that prompt and its help text be updated to mention also Exynos7? >> >> Right, even that has to be updated accordingly. Will update the same in next >> version of the patch. Thanks for pointing this. > > I would rather change that to ARCH_EXYNOS, unless Kishon doesn't like > that idea. The thing is that this will likely need to be patches for > exynos8, 9, 10, 11... Yes, after we have the 2nd version of Exynos7 support patches, it makes more sense to keep dependency on ARCH_EXYNOS.
On Wed, Sep 03, 2014 at 09:32:14AM +0530, Vivek Gautam wrote: > On Tue, Sep 2, 2014 at 8:07 PM, Felipe Balbi <balbi@ti.com> wrote: > > On Mon, Sep 01, 2014 at 01:30:21PM +0530, Vivek Gautam wrote: > >> On Thu, Aug 28, 2014 at 8:36 PM, Daniele Forsi <dforsi@gmail.com> wrote: > >> > 2014-08-28 10:02 GMT+02:00 Vivek Gautam: > >> > > >> >> This USB 3.0 PHY controller is also present on Exynos7 > >> >> platform, so adding the dependency on ARCH_EXYNOS7 for this driver. > >> > > >> >> +++ b/drivers/phy/Kconfig > >> >> @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 > >> >> > >> >> config PHY_EXYNOS5_USBDRD > >> >> tristate "Exynos5 SoC series USB DRD PHY driver" > >> >> - depends on ARCH_EXYNOS5 && OF > >> >> + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF > >> > > >> > shouldn't that prompt and its help text be updated to mention also Exynos7? > >> > >> Right, even that has to be updated accordingly. Will update the same in next > >> version of the patch. Thanks for pointing this. > > > > I would rather change that to ARCH_EXYNOS, unless Kishon doesn't like > > that idea. The thing is that this will likely need to be patches for > > exynos8, 9, 10, 11... > > Yes, after we have the 2nd version of Exynos7 support patches, it makes > more sense to keep dependency on ARCH_EXYNOS. thank you, that'll help new silicon wakeup; one less thing to patch :-p
diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 0dd7427..c3bc380 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -186,7 +186,7 @@ config PHY_EXYNOS5250_USB2 config PHY_EXYNOS5_USBDRD tristate "Exynos5 SoC series USB DRD PHY driver" - depends on ARCH_EXYNOS5 && OF + depends on (ARCH_EXYNOS5 || ARCH_EXYNOS7) && OF depends on HAS_IOMEM depends on USB_DWC3_EXYNOS select GENERIC_PHY
This USB 3.0 PHY controller is also present on Exynos7 platform, so adding the dependency on ARCH_EXYNOS7 for this driver. Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com> --- drivers/phy/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)