| Message ID | 1409132660-1898-5-git-send-email-ch.naveen@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi, On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: > From: Alim Akhtar <alim.akhtar@samsung.com> > > This patch adds the necessary Kconfig entries to enable > support for the ARMv8 based Exynos7 SoC. > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> > Cc: Rob Herring <robh@kernel.org> > Cc: Catalin Marinas <catalin.marinas@arm.com> > --- > arch/arm64/Kconfig | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index fd4e81a..d555558 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer" > > menu "Platform selection" > > +config ARCH_EXYNOS7 > + bool "ARMv8 based SAMSUNG EXYNOS7" > + select HAVE_S3C2410_WATCHDOG if WATCHDOG > + select CLKSRC_OF This seems to be implied by ARM_ARCH_TIMER in the core arm64 Kconfig, so I'm not sure this is necessary. > + select COMMON_CLK_SAMSUNG > + select GPIOLIB You select ARCH_REQUIRE_GPIOLIB below, so is this necessary? > + select PINCTRL > + select PINCTRL_EXYNOS > + select RTC_CLASS > + select HAVE_S3C_RTC > + select GENERIC_GPIO > + select ARCH_REQUIRE_GPIOLIB > + select HAVE_CLK Isn't this selected already through the core arm64 Kconfig? It looks like we have COMMON_CLK, which selects CLKDEV_LOOKUP, which selects HAVE_CLK. > + select HAVE_SMP I may have missed something, but I didn't see any SMP support in this series. Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 27, 2014 at 12:09:28PM +0100, Mark Rutland wrote: > On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: > > + select HAVE_SMP > > I may have missed something, but I didn't see any SMP support in this > series. We don't even have HAVE_SMP defined for arm64 (just SMP, which is on in defconfig). In theory we don't need any specific SMP support for a new SoC as long as it uses a standard booting protocol (e.g. PSCI). But for whatever reason, I only received about four patches in this series, so can't see the rest.
On Wed, Aug 27, 2014 at 03:50:21PM +0100, Catalin Marinas wrote: > On Wed, Aug 27, 2014 at 12:09:28PM +0100, Mark Rutland wrote: > > On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: > > > + select HAVE_SMP > > > > I may have missed something, but I didn't see any SMP support in this > > series. > > We don't even have HAVE_SMP defined for arm64 (just SMP, which is on in > defconfig). > > In theory we don't need any specific SMP support for a new SoC as long > as it uses a standard booting protocol (e.g. PSCI). But for whatever > reason, I only received about four patches in this series, so can't see > the rest. Seems like about 9 of them made it to the list for me. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mark, On 27 August 2014 16:39, Mark Rutland <mark.rutland@arm.com> wrote: > Hi, > > On Wed, Aug 27, 2014 at 10:44:20AM +0100, Naveen Krishna Chatradhi wrote: >> From: Alim Akhtar <alim.akhtar@samsung.com> >> >> This patch adds the necessary Kconfig entries to enable >> support for the ARMv8 based Exynos7 SoC. >> >> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> >> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com> >> Cc: Rob Herring <robh@kernel.org> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> --- >> arch/arm64/Kconfig | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig >> index fd4e81a..d555558 100644 >> --- a/arch/arm64/Kconfig >> +++ b/arch/arm64/Kconfig >> @@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer" >> >> menu "Platform selection" >> >> +config ARCH_EXYNOS7 >> + bool "ARMv8 based SAMSUNG EXYNOS7" >> + select HAVE_S3C2410_WATCHDOG if WATCHDOG >> + select CLKSRC_OF > > This seems to be implied by ARM_ARCH_TIMER in the core arm64 Kconfig, so > I'm not sure this is necessary. Ok. > >> + select COMMON_CLK_SAMSUNG >> + select GPIOLIB > > You select ARCH_REQUIRE_GPIOLIB below, so is this necessary? Yes, this is not required. Will remove. > >> + select PINCTRL >> + select PINCTRL_EXYNOS >> + select RTC_CLASS >> + select HAVE_S3C_RTC >> + select GENERIC_GPIO >> + select ARCH_REQUIRE_GPIOLIB >> + select HAVE_CLK > > Isn't this selected already through the core arm64 Kconfig? > > It looks like we have COMMON_CLK, which selects CLKDEV_LOOKUP, which > selects HAVE_CLK. Ok. > >> + select HAVE_SMP > > I may have missed something, but I didn't see any SMP support in this > series. As Catalin suggested, will remove this. > > Thanks, > Mark. Thanks for your comments.
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index fd4e81a..d555558 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -134,6 +134,23 @@ source "kernel/Kconfig.freezer" menu "Platform selection" +config ARCH_EXYNOS7 + bool "ARMv8 based SAMSUNG EXYNOS7" + select HAVE_S3C2410_WATCHDOG if WATCHDOG + select CLKSRC_OF + select COMMON_CLK_SAMSUNG + select GPIOLIB + select PINCTRL + select PINCTRL_EXYNOS + select RTC_CLASS + select HAVE_S3C_RTC + select GENERIC_GPIO + select ARCH_REQUIRE_GPIOLIB + select HAVE_CLK + select HAVE_SMP + help + This enables support for SAMSUNG exynos7 SoC family + config ARCH_VEXPRESS bool "ARMv8 software model (Versatile Express)" select ARCH_REQUIRE_GPIOLIB