diff mbox

[1/5] tests/kms_psr_sink_crc: moving usleep around.

Message ID 1409870579-17282-1-git-send-email-rodrigo.vivi@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Rodrigo Vivi Sept. 4, 2014, 10:42 p.m. UTC
Lets just do this small sleep to allow human eyes to see what is happening,
but let's avoid any kind of interference on the actual test.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 tests/kms_psr_sink_crc.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Rodrigo Vivi Sept. 4, 2014, 10:53 p.m. UTC | #1
First of all sorry for the huge amount of emails.
I don't know what happened with my git send-email and my slow server...

Well, this series is one alternative for the debug using igt_core debug
helpers.
But I'm not confident igt_debug_wait and igt_dry_run are the best way to do
that.

So please let me know what you think or if you have better suggestions to
proceed with this debug.

Thanks



On Thu, Sep 4, 2014 at 3:42 PM, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:

> Lets just do this small sleep to allow human eyes to see what is happening,
> but let's avoid any kind of interference on the actual test.
>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  tests/kms_psr_sink_crc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
> index 0917a7f..bbe18f0 100644
> --- a/tests/kms_psr_sink_crc.c
> +++ b/tests/kms_psr_sink_crc.c
> @@ -327,6 +327,11 @@ static void get_sink_crc(data_t *data, char *crc) {
>         igt_require(ret > 0);
>
>         fclose(file);
> +
> +       /* The important value was already taken.
> +        * Now give a time for human eyes
> +        */
> +       usleep(300000);
>  }
>
>  static void test_crc(data_t *data)
> @@ -342,7 +347,6 @@ static void test_crc(data_t *data)
>                                              1, 1) == 0);
>         }
>
> -       usleep(300000);
>         igt_assert(wait_psr_entry(data, 10));
>         get_sink_crc(data, ref_crc);
>
> --
> 1.9.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
diff mbox

Patch

diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index 0917a7f..bbe18f0 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/kms_psr_sink_crc.c
@@ -327,6 +327,11 @@  static void get_sink_crc(data_t *data, char *crc) {
 	igt_require(ret > 0);
 
 	fclose(file);
+
+	/* The important value was already taken.
+	 * Now give a time for human eyes
+	 */
+	usleep(300000);
 }
 
 static void test_crc(data_t *data)
@@ -342,7 +347,6 @@  static void test_crc(data_t *data)
 					     1, 1) == 0);
 	}
 
-	usleep(300000);
 	igt_assert(wait_psr_entry(data, 10));
 	get_sink_crc(data, ref_crc);