| Message ID | c522bdd8972633e0eb481ffc5ebb7da98b190fa7.1410273306.git.m.chehab@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Sep 9, 2014 at 3:38 PM, Mauro Carvalho Chehab <m.chehab@samsung.com> wrote: > When vpif is compiled as module, those errors happen: > > ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_display.ko] undefined! > ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_capture.ko] undefined! > > That's because vpif_lock symbol is not exported. > Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com> Regards, --Prabhakar Lad > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com> > > diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c > index cd08e5248387..3dad5bd7fe0a 100644 > --- a/drivers/media/platform/davinci/vpif.c > +++ b/drivers/media/platform/davinci/vpif.c > @@ -38,6 +38,7 @@ MODULE_LICENSE("GPL"); > #define VPIF_CH3_MAX_MODES 2 > > spinlock_t vpif_lock; > +EXPORT_SYMBOL_GPL(vpif_lock); > > void __iomem *vpif_base; > EXPORT_SYMBOL_GPL(vpif_base); > -- > 1.9.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c index cd08e5248387..3dad5bd7fe0a 100644 --- a/drivers/media/platform/davinci/vpif.c +++ b/drivers/media/platform/davinci/vpif.c @@ -38,6 +38,7 @@ MODULE_LICENSE("GPL"); #define VPIF_CH3_MAX_MODES 2 spinlock_t vpif_lock; +EXPORT_SYMBOL_GPL(vpif_lock); void __iomem *vpif_base; EXPORT_SYMBOL_GPL(vpif_base);
When vpif is compiled as module, those errors happen: ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_display.ko] undefined! ERROR: "vpif_lock" [drivers/media/platform/davinci/vpif_capture.ko] undefined! That's because vpif_lock symbol is not exported. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>