| Message ID | 1410342112-13264-5-git-send-email-thomas.petazzoni@free-electrons.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 10 September 2014 15:11, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > The cpufreq-dt driver tries to get a regulator for each CPU. This > regulator is optional, but when not present, a scary message "failed > to get cpuX regulator" is displayed. Since the regulator is really > optional, we cannot sanely display any useful message, so this commit > simply gets rid of this problematic message. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > --- > drivers/cpufreq/cpufreq-dt.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c > index 35d396e..8060022 100644 > --- a/drivers/cpufreq/cpufreq-dt.c > +++ b/drivers/cpufreq/cpufreq-dt.c > @@ -149,9 +149,6 @@ try_again: > reg = reg_cpu; > goto try_again; > } > - > - dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n", > - cpu, PTR_ERR(cpu_reg)); What about converting it to dev_dbg() instead? -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/cpufreq-dt.c b/drivers/cpufreq/cpufreq-dt.c index 35d396e..8060022 100644 --- a/drivers/cpufreq/cpufreq-dt.c +++ b/drivers/cpufreq/cpufreq-dt.c @@ -149,9 +149,6 @@ try_again: reg = reg_cpu; goto try_again; } - - dev_warn(cpu_dev, "failed to get cpu%d regulator: %ld\n", - cpu, PTR_ERR(cpu_reg)); } cpu_clk = clk_get(cpu_dev, NULL);
The cpufreq-dt driver tries to get a regulator for each CPU. This regulator is optional, but when not present, a scary message "failed to get cpuX regulator" is displayed. Since the regulator is really optional, we cannot sanely display any useful message, so this commit simply gets rid of this problematic message. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/cpufreq/cpufreq-dt.c | 3 --- 1 file changed, 3 deletions(-)