diff mbox

[RESEND] ARM: DTS: correct the capability string for mmc0

Message ID 1410857409-24767-1-git-send-email-gautam.vivek@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vivek Gautam Sept. 16, 2014, 8:50 a.m. UTC
From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>

MMC capability for HS200 is parsed in mmc/core/host.c as
dts string "mmc-hs200-1_8v".

This patch corrects the dts string for Exynos5420 based peach-pit
and Exynos5800 based peach-pi boards.

Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
---

Hi Kukjin,

As commented by Doug earlier for this patch, the two patches required
  -- mmc: dw_mmc: Make sure we don't get stuck when we get an error
  -- mmc: dw_mmc: change to use recommended reset procedure
are now merged in upstream.
So you can go ahead and pick this change.

 arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
 arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Doug Anderson Sept. 16, 2014, 3:58 p.m. UTC | #1
Vivek,

On Tue, Sep 16, 2014 at 1:50 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>
> MMC capability for HS200 is parsed in mmc/core/host.c as
> dts string "mmc-hs200-1_8v".
>
> This patch corrects the dts string for Exynos5420 based peach-pit
> and Exynos5800 based peach-pi boards.
>
> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> ---
>
> Hi Kukjin,
>
> As commented by Doug earlier for this patch, the two patches required
>   -- mmc: dw_mmc: Make sure we don't get stuck when we get an error
>   -- mmc: dw_mmc: change to use recommended reset procedure
> are now merged in upstream.
> So you can go ahead and pick this change.
>
>  arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
>  arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Doug Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kgene@kernel.org Sept. 17, 2014, 12:09 p.m. UTC | #2
Doug Anderson wrote:
> 
> Vivek,
> 
Hi,

> On Tue, Sep 16, 2014 at 1:50 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> > From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
> >
> > MMC capability for HS200 is parsed in mmc/core/host.c as
> > dts string "mmc-hs200-1_8v".
> >
> > This patch corrects the dts string for Exynos5420 based peach-pit
> > and Exynos5800 based peach-pi boards.
> >
> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>

In this case, Vivek's sign is required here.

> > ---
> >
> > Hi Kukjin,
> >
> > As commented by Doug earlier for this patch, the two patches required
> >   -- mmc: dw_mmc: Make sure we don't get stuck when we get an error
> >   -- mmc: dw_mmc: change to use recommended reset procedure
> > are now merged in upstream.
> > So you can go ahead and pick this change.
> >
> >  arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
> >  arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Doug Anderson <dianders@chromium.org>

Thanks, I will take this patch once Vivek replies his sign on this patch.

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vivek Gautam Sept. 17, 2014, 12:13 p.m. UTC | #3
Hi Kukjin,


On Wed, Sep 17, 2014 at 5:39 PM, Kukjin Kim <kgene@kernel.org> wrote:
> Doug Anderson wrote:
>>
>> Vivek,
>>
> Hi,
>
>> On Tue, Sep 16, 2014 at 1:50 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
>> > From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> >
>> > MMC capability for HS200 is parsed in mmc/core/host.c as
>> > dts string "mmc-hs200-1_8v".
>> >
>> > This patch corrects the dts string for Exynos5420 based peach-pit
>> > and Exynos5800 based peach-pi boards.
>> >
>> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>
> In this case, Vivek's sign is required here.

Ok, i will resend it with my Signed-off

>
>> > ---
>> >
>> > Hi Kukjin,
>> >
>> > As commented by Doug earlier for this patch, the two patches required
>> >   -- mmc: dw_mmc: Make sure we don't get stuck when we get an error
>> >   -- mmc: dw_mmc: change to use recommended reset procedure
>> > are now merged in upstream.
>> > So you can go ahead and pick this change.
>> >
>> >  arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
>> >  arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
> Thanks, I will take this patch once Vivek replies his sign on this patch.
>
> - Kukjin
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
Vivek Gautam Sept. 17, 2014, 12:19 p.m. UTC | #4
On Wed, Sep 17, 2014 at 5:43 PM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
> Hi Kukjin,
>
>
> On Wed, Sep 17, 2014 at 5:39 PM, Kukjin Kim <kgene@kernel.org> wrote:
>> Doug Anderson wrote:
>>>
>>> Vivek,
>>>
>> Hi,
>>
>>> On Tue, Sep 16, 2014 at 1:50 AM, Vivek Gautam <gautam.vivek@samsung.com> wrote:
>>> > From: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>> >
>>> > MMC capability for HS200 is parsed in mmc/core/host.c as
>>> > dts string "mmc-hs200-1_8v".
>>> >
>>> > This patch corrects the dts string for Exynos5420 based peach-pit
>>> > and Exynos5800 based peach-pi boards.
>>> >
>>> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>>
>> In this case, Vivek's sign is required here.
>
> Ok, i will resend it with my Signed-off.
>
>>
>>> > ---
>>> >
>>> > Hi Kukjin,
>>> >
>>> > As commented by Doug earlier for this patch, the two patches required
>>> >   -- mmc: dw_mmc: Make sure we don't get stuck when we get an error
>>> >   -- mmc: dw_mmc: change to use recommended reset procedure
>>> > are now merged in upstream.
>>> > So you can go ahead and pick this change.
>>> >
>>> >  arch/arm/boot/dts/exynos5420-peach-pit.dts |    2 +-
>>> >  arch/arm/boot/dts/exynos5800-peach-pi.dts  |    2 +-
>>> >  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Reviewed-by: Doug Anderson <dianders@chromium.org>
>>
>> Thanks, I will take this patch once Vivek replies his sign on this patch.

As suggested, giving  my signed-off here:
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts
index 9a23382..e52ed04 100644
--- a/arch/arm/boot/dts/exynos5420-peach-pit.dts
+++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts
@@ -560,7 +560,7 @@ 
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	cap-mmc-highspeed;
 	non-removable;
 	card-detect-delay = <200>;
diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts
index 1d31c81..8616fbd 100644
--- a/arch/arm/boot/dts/exynos5800-peach-pi.dts
+++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts
@@ -548,7 +548,7 @@ 
 	status = "okay";
 	num-slots = <1>;
 	broken-cd;
-	caps2-mmc-hs200-1_8v;
+	mmc-hs200-1_8v;
 	cap-mmc-highspeed;
 	non-removable;
 	card-detect-delay = <200>;