diff mbox

[2/3] ACPI: EC: use BURST mode only for MSI notebooks

Message ID 20090828192944.19961.76281.stgit@thinkpad (mailing list archive)
State Accepted
Headers show

Commit Message

Alexey Starikovskiy Aug. 28, 2009, 7:29 p.m. UTC
Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/ec.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)



--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Len Brown Aug. 29, 2009, 6:40 p.m. UTC | #1
applied to ec branch in acpi-test for 2.6.32

The patch needs a check-in comment before it goes upstream, however.

thanks,
Len Brown, Intel Open Source Technology Center

On Fri, 28 Aug 2009, Alexey Starikovskiy wrote:

> Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
> ---
> 
>  drivers/acpi/ec.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
> index 78f8380..829e62e 100644
> --- a/drivers/acpi/ec.c
> +++ b/drivers/acpi/ec.c
> @@ -627,7 +627,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
>  	if (bits != 8 && acpi_strict)
>  		return AE_BAD_PARAMETER;
>  
> -	acpi_ec_burst_enable(ec);
> +	if (EC_FLAGS_MSI)
> +		acpi_ec_burst_enable(ec);
>  
>  	if (function == ACPI_READ) {
>  		result = acpi_ec_read(ec, address, &temp);
> @@ -648,7 +649,8 @@ acpi_ec_space_handler(u32 function, acpi_physical_address address,
>  		}
>  	}
>  
> -	acpi_ec_burst_disable(ec);
> +	if (EC_FLAGS_MSI)
> +		acpi_ec_burst_disable(ec);
>  
>  	switch (result) {
>  	case -EINVAL:
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/acpi/ec.c b/drivers/acpi/ec.c
index 78f8380..829e62e 100644
--- a/drivers/acpi/ec.c
+++ b/drivers/acpi/ec.c
@@ -627,7 +627,8 @@  acpi_ec_space_handler(u32 function, acpi_physical_address address,
 	if (bits != 8 && acpi_strict)
 		return AE_BAD_PARAMETER;
 
-	acpi_ec_burst_enable(ec);
+	if (EC_FLAGS_MSI)
+		acpi_ec_burst_enable(ec);
 
 	if (function == ACPI_READ) {
 		result = acpi_ec_read(ec, address, &temp);
@@ -648,7 +649,8 @@  acpi_ec_space_handler(u32 function, acpi_physical_address address,
 		}
 	}
 
-	acpi_ec_burst_disable(ec);
+	if (EC_FLAGS_MSI)
+		acpi_ec_burst_disable(ec);
 
 	switch (result) {
 	case -EINVAL: