diff mbox

[media] tc90522: declare tc90522_functionality as static

Message ID 5b2f265c143c9e8ee35b035de7d35bb69871fd84.1411502537.git.mchehab@osg.samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Mauro Carvalho Chehab Sept. 23, 2014, 8:02 p.m. UTC
drivers/media/dvb-frontends/tc90522.c:706:5: warning: symbol 'tc90522_functionality' was not declared. Should it be static?
drivers/media/dvb-frontends/tc90522.c:706:5: warning: no previous prototype for 'tc90522_functionality' [-Wmissing-prototypes]
 u32 tc90522_functionality(struct i2c_adapter *adap)
     ^

Cc: Akihiro Tsukada <tskd08@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>

Comments

Akihiro TSUKADA Sept. 24, 2014, 4:13 a.m. UTC | #1
Sorry to bother you with those build warnings.
Somehow I didn't see them when I built the modules myself on 64bit box.
maybe since I forgot to test all-y config (and 32bit build),
the gcc cmd did not include [-Wmissing-prototypes].

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c
index f4760dd998c3..cdd9808c322c 100644
--- a/drivers/media/dvb-frontends/tc90522.c
+++ b/drivers/media/dvb-frontends/tc90522.c
@@ -703,7 +703,7 @@  tc90522_master_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
 	return (ret == j) ? num : ret;
 }
 
-u32 tc90522_functionality(struct i2c_adapter *adap)
+static u32 tc90522_functionality(struct i2c_adapter *adap)
 {
 	return I2C_FUNC_I2C;
 }