| Message ID | 1410753372-10912-1-git-send-email-yidi.lin@canonical.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Monday, September 15, 2014 11:56:12 AM Edward Lin wrote: > The wireless hotkey of those machines does not work with Win8 OSI. > Due to insufficient documentation for the driver implementation, > blacklist those machines as a workaround. > > "audo wake on after shutdown" bug on Dell Inspiron 7737 is fixed by BIOS[1]. > But this machine still suffers the hotkey issue. So keep the quirk for the > wireless hotkey issue. > > [1]: > http://www.dell.com/support/home/us/en/19/Drivers/DriversDetails?driverId=MJWNX > > Signed-off-by: Edward Lin <yidi.lin@canonical.com> Queued up for 3.18, thanks! > --- > drivers/acpi/blacklist.c | 36 ++++++++++++++++++++++++++++++++++-- > 1 file changed, 34 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c > index 36eb42e..ed122e1 100644 > --- a/drivers/acpi/blacklist.c > +++ b/drivers/acpi/blacklist.c > @@ -247,8 +247,8 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > }, > > /* > - * These machines will power on immediately after shutdown when > - * reporting the Windows 2012 OSI. > + * The wireless hotkey does not work on those machines when > + * returning true for _OSI("Windows 2012") > */ > { > .callback = dmi_disable_osi_win8, > @@ -258,6 +258,38 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { > DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7737"), > }, > }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "Dell Inspiron 7537", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7537"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "Dell Inspiron 5437", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5437"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "Dell Inspiron 3437", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3437"), > + }, > + }, > + { > + .callback = dmi_disable_osi_win8, > + .ident = "Dell Vostro 3446", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3446"), > + }, > + }, > > /* > * BIOS invocation of _OSI(Linux) is almost always a BIOS bug. >
diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c index 36eb42e..ed122e1 100644 --- a/drivers/acpi/blacklist.c +++ b/drivers/acpi/blacklist.c @@ -247,8 +247,8 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { }, /* - * These machines will power on immediately after shutdown when - * reporting the Windows 2012 OSI. + * The wireless hotkey does not work on those machines when + * returning true for _OSI("Windows 2012") */ { .callback = dmi_disable_osi_win8, @@ -258,6 +258,38 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = { DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7737"), }, }, + { + .callback = dmi_disable_osi_win8, + .ident = "Dell Inspiron 7537", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 7537"), + }, + }, + { + .callback = dmi_disable_osi_win8, + .ident = "Dell Inspiron 5437", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 5437"), + }, + }, + { + .callback = dmi_disable_osi_win8, + .ident = "Dell Inspiron 3437", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Inspiron 3437"), + }, + }, + { + .callback = dmi_disable_osi_win8, + .ident = "Dell Vostro 3446", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 3446"), + }, + }, /* * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
The wireless hotkey of those machines does not work with Win8 OSI. Due to insufficient documentation for the driver implementation, blacklist those machines as a workaround. "audo wake on after shutdown" bug on Dell Inspiron 7737 is fixed by BIOS[1]. But this machine still suffers the hotkey issue. So keep the quirk for the wireless hotkey issue. [1]: http://www.dell.com/support/home/us/en/19/Drivers/DriversDetails?driverId=MJWNX Signed-off-by: Edward Lin <yidi.lin@canonical.com> --- drivers/acpi/blacklist.c | 36 ++++++++++++++++++++++++++++++++++-- 1 file changed, 34 insertions(+), 2 deletions(-)