| Message ID | Pine.LNX.4.64.0909021429000.6326@axis700.grange (mailing list archive) |
|---|---|
| State | RFC |
| Headers | show |
From: linux-media-owner@vger.kernel.org [mailto:linux-media- owner@vger.kernel.org] On Behalf Of Guennadi Liakhovetski Sent: Wednesday, September 02, 2009 7:34 AM > > The 16-bit monochrome fourcc code has been previously abused for a 10-bit > format, add a new 10-bit code instead. Also add missing 8- and 10-bit > Bayer > fourcc codes for completeness. > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > --- > > Indeed, this is not directly related to the image-bus API, but I'd like to > have these codes available for completeness and also to stop abusing > 16-bit codes for 10-bit formats. > > include/linux/videodev2.h | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h > index 9d9a615..ffea559 100644 > --- a/include/linux/videodev2.h > +++ b/include/linux/videodev2.h > @@ -293,6 +293,7 @@ struct v4l2_pix_format { > > /* Grey formats */ > #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 > Greyscale */ > +#define V4L2_PIX_FMT_Y10 v4l2_fourcc('Y', '1', '0', ' ') /* 10 > Greyscale */ > #define V4L2_PIX_FMT_Y16 v4l2_fourcc('Y', '1', '6', ' ') /* 16 > Greyscale */ > > /* Palette formats */ > @@ -328,7 +329,11 @@ struct v4l2_pix_format { > #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 > BGBG.. GRGR.. */ > #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 > GBGB.. RGRG.. */ > #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 > GRGR.. BGBG.. */ > -#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10bit raw > bayer */ > +#define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 > RGRG.. GBGB.. */ > +#define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 > BGBG.. GRGR.. */ > +#define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 > GBGB.. RGRG.. */ > +#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 > GRGR.. BGBG.. */ > +#define V4L2_PIX_FMT_SRGGB10 v4l2_fourcc('R', 'G', '1', '0') /* 10 > RGRG.. GBGB.. */ I tried adding these same RAW Bayer 10-bit codes, but I missed documentation changes. (Perhaphs you should do the same) Actually, you responded on that thread :) http://www.spinics.net/lists/linux-media/msg08882.html I had to postpone that patch, since I'm currently being dragged to some internal high priority issues. But if you can do it, I'm ok with that :) Regards, Sergio > /* 10bit raw bayer DPCM compressed to 8 bits */ > #define V4L2_PIX_FMT_SGRBG10DPCM8 v4l2_fourcc('B', 'D', '1', '0') > /* > -- > 1.6.2.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2 Sep 2009, Aguirre Rodriguez, Sergio Alberto wrote: > > > From: linux-media-owner@vger.kernel.org [mailto:linux-media- > owner@vger.kernel.org] On Behalf Of Guennadi Liakhovetski > Sent: Wednesday, September 02, 2009 7:34 AM > > > > The 16-bit monochrome fourcc code has been previously abused for a 10-bit > > format, add a new 10-bit code instead. Also add missing 8- and 10-bit > > Bayer > > fourcc codes for completeness. > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > --- > > > > Indeed, this is not directly related to the image-bus API, but I'd like to > > have these codes available for completeness and also to stop abusing > > 16-bit codes for 10-bit formats. > > > > include/linux/videodev2.h | 7 ++++++- > > 1 files changed, 6 insertions(+), 1 deletions(-) > > > > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h > > index 9d9a615..ffea559 100644 > > --- a/include/linux/videodev2.h > > +++ b/include/linux/videodev2.h > > @@ -293,6 +293,7 @@ struct v4l2_pix_format { > > > > /* Grey formats */ > > #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 > > Greyscale */ > > +#define V4L2_PIX_FMT_Y10 v4l2_fourcc('Y', '1', '0', ' ') /* 10 > > Greyscale */ > > #define V4L2_PIX_FMT_Y16 v4l2_fourcc('Y', '1', '6', ' ') /* 16 > > Greyscale */ > > > > /* Palette formats */ > > @@ -328,7 +329,11 @@ struct v4l2_pix_format { > > #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 > > BGBG.. GRGR.. */ > > #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 > > GBGB.. RGRG.. */ > > #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 > > GRGR.. BGBG.. */ > > -#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10bit raw > > bayer */ > > +#define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 > > RGRG.. GBGB.. */ > > +#define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 > > BGBG.. GRGR.. */ > > +#define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 > > GBGB.. RGRG.. */ > > +#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 > > GRGR.. BGBG.. */ > > +#define V4L2_PIX_FMT_SRGGB10 v4l2_fourcc('R', 'G', '1', '0') /* 10 > > RGRG.. GBGB.. */ > > I tried adding these same RAW Bayer 10-bit codes, but I missed > documentation changes. (Perhaphs you should do the same) Indeed, I forgot about it, sorry:-( I can mention in a next revision, that you posted an earlier version of this patch, and will add documentation as Hans commented on your patch. Thanks Guennadi > Actually, you responded on that thread :) > http://www.spinics.net/lists/linux-media/msg08882.html > > I had to postpone that patch, since I'm currently being dragged to some > internal high priority issues. But if you can do it, I'm ok with that :) > > Regards, > Sergio > > > /* 10bit raw bayer DPCM compressed to 8 bits */ > > #define V4L2_PIX_FMT_SGRBG10DPCM8 v4l2_fourcc('B', 'D', '1', '0') > > /* > > -- > > 1.6.2.4 --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> -----Original Message----- > From: Guennadi Liakhovetski [mailto:g.liakhovetski@gmx.de] > Sent: Wednesday, September 02, 2009 8:41 AM > To: Aguirre Rodriguez, Sergio Alberto > Cc: Linux Media Mailing List; Hans Verkuil; Paulius Zaleckas; Robert > Jarzmik; Kuninori Morimoto; Laurent Pinchart; Karicheri, Muralidharan > Subject: RE: [PATCH 1/3] v4l: Add a 10-bit monochrome and missing 8- and > 10-bit Bayer fourcc codes > > On Wed, 2 Sep 2009, Aguirre Rodriguez, Sergio Alberto wrote: > > > > > > > From: linux-media-owner@vger.kernel.org [mailto:linux-media- > > owner@vger.kernel.org] On Behalf Of Guennadi Liakhovetski > > Sent: Wednesday, September 02, 2009 7:34 AM > > > > > > The 16-bit monochrome fourcc code has been previously abused for a 10- > bit > > > format, add a new 10-bit code instead. Also add missing 8- and 10-bit > > > Bayer > > > fourcc codes for completeness. > > > > > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> > > > --- > > > > > > Indeed, this is not directly related to the image-bus API, but I'd > like to > > > have these codes available for completeness and also to stop abusing > > > 16-bit codes for 10-bit formats. > > > > > > include/linux/videodev2.h | 7 ++++++- > > > 1 files changed, 6 insertions(+), 1 deletions(-) > > > > > > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h > > > index 9d9a615..ffea559 100644 > > > --- a/include/linux/videodev2.h > > > +++ b/include/linux/videodev2.h > > > @@ -293,6 +293,7 @@ struct v4l2_pix_format { > > > > > > /* Grey formats */ > > > #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 > > > Greyscale */ > > > +#define V4L2_PIX_FMT_Y10 v4l2_fourcc('Y', '1', '0', ' ') /* 10 > > > Greyscale */ > > > #define V4L2_PIX_FMT_Y16 v4l2_fourcc('Y', '1', '6', ' ') /* 16 > > > Greyscale */ > > > > > > /* Palette formats */ > > > @@ -328,7 +329,11 @@ struct v4l2_pix_format { > > > #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 > > > BGBG.. GRGR.. */ > > > #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 > > > GBGB.. RGRG.. */ > > > #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 > > > GRGR.. BGBG.. */ > > > -#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10bit > raw > > > bayer */ > > > +#define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 > > > RGRG.. GBGB.. */ > > > +#define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 > > > BGBG.. GRGR.. */ > > > +#define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 > > > GBGB.. RGRG.. */ > > > +#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 > > > GRGR.. BGBG.. */ > > > +#define V4L2_PIX_FMT_SRGGB10 v4l2_fourcc('R', 'G', '1', '0') /* 10 > > > RGRG.. GBGB.. */ > > > > I tried adding these same RAW Bayer 10-bit codes, but I missed > > documentation changes. (Perhaphs you should do the same) > > Indeed, I forgot about it, sorry:-( I can mention in a next revision, that > you posted an earlier version of this patch, and will add documentation as > Hans commented on your patch. Hey, no problem. For me its better if you can do that for me :) I'll add my Signed-off-by in the next revision of this patch (if you want to, of course). Regards, Sergio > > Thanks > Guennadi > > > Actually, you responded on that thread :) > > http://www.spinics.net/lists/linux-media/msg08882.html > > > > I had to postpone that patch, since I'm currently being dragged to some > > internal high priority issues. But if you can do it, I'm ok with that :) > > > > Regards, > > Sergio > > > > > /* 10bit raw bayer DPCM compressed to 8 bits */ > > > #define V4L2_PIX_FMT_SGRBG10DPCM8 v4l2_fourcc('B', 'D', '1', '0') > > > /* > > > -- > > > 1.6.2.4 > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h index 9d9a615..ffea559 100644 --- a/include/linux/videodev2.h +++ b/include/linux/videodev2.h @@ -293,6 +293,7 @@ struct v4l2_pix_format { /* Grey formats */ #define V4L2_PIX_FMT_GREY v4l2_fourcc('G', 'R', 'E', 'Y') /* 8 Greyscale */ +#define V4L2_PIX_FMT_Y10 v4l2_fourcc('Y', '1', '0', ' ') /* 10 Greyscale */ #define V4L2_PIX_FMT_Y16 v4l2_fourcc('Y', '1', '6', ' ') /* 16 Greyscale */ /* Palette formats */ @@ -328,7 +329,11 @@ struct v4l2_pix_format { #define V4L2_PIX_FMT_SBGGR8 v4l2_fourcc('B', 'A', '8', '1') /* 8 BGBG.. GRGR.. */ #define V4L2_PIX_FMT_SGBRG8 v4l2_fourcc('G', 'B', 'R', 'G') /* 8 GBGB.. RGRG.. */ #define V4L2_PIX_FMT_SGRBG8 v4l2_fourcc('G', 'R', 'B', 'G') /* 8 GRGR.. BGBG.. */ -#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10bit raw bayer */ +#define V4L2_PIX_FMT_SRGGB8 v4l2_fourcc('R', 'G', 'G', 'B') /* 8 RGRG.. GBGB.. */ +#define V4L2_PIX_FMT_SBGGR10 v4l2_fourcc('B', 'G', '1', '0') /* 10 BGBG.. GRGR.. */ +#define V4L2_PIX_FMT_SGBRG10 v4l2_fourcc('G', 'B', '1', '0') /* 10 GBGB.. RGRG.. */ +#define V4L2_PIX_FMT_SGRBG10 v4l2_fourcc('B', 'A', '1', '0') /* 10 GRGR.. BGBG.. */ +#define V4L2_PIX_FMT_SRGGB10 v4l2_fourcc('R', 'G', '1', '0') /* 10 RGRG.. GBGB.. */ /* 10bit raw bayer DPCM compressed to 8 bits */ #define V4L2_PIX_FMT_SGRBG10DPCM8 v4l2_fourcc('B', 'D', '1', '0') /*
The 16-bit monochrome fourcc code has been previously abused for a 10-bit format, add a new 10-bit code instead. Also add missing 8- and 10-bit Bayer fourcc codes for completeness. Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de> --- Indeed, this is not directly related to the image-bus API, but I'd like to have these codes available for completeness and also to stop abusing 16-bit codes for 10-bit formats. include/linux/videodev2.h | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)