| Message ID | 1411992293-7729-2-git-send-email-zhang.lyra@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Monday 29 September 2014 20:04:48 zhang.lyra@gmail.com wrote: > diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt > index 7705477..a0bb1d1 100644 > --- a/Documentation/devicetree/bindings/serial/of-serial.txt > +++ b/Documentation/devicetree/bindings/serial/of-serial.txt > @@ -14,6 +14,7 @@ Required properties: > - "altr,16550-FIFO32" > - "altr,16550-FIFO64" > - "altr,16550-FIFO128" > + - "sprd,serial" > - "serial" if the port type is unknown. > - reg : offset and length of the register set for the device. > - interrupts : should contain uart interrupt. > This file is really only for 8250 compatible UART implementations, please add a new file with a proper binding for your serial port. It would be nice if you could rename this file to 8250.txt to avoid confusing the next person. Please also add the "sprd" prefix to Documentation/devicetree/bindings/vendor-prefixes.txt Arnd
On Mon, Sep 29, 2014 at 01:04:48PM +0100, zhang.lyra@gmail.com wrote: > From: "chunyan.zhang" <chunyan.zhang@spreadtrum.com> > > Adds the device-tree documentation for Spreadtrum's serial. > > Signed-off-by: chunyan.zhang <chunyan.zhang@spreadtrum.com> > --- > .../devicetree/bindings/serial/of-serial.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt > index 7705477..a0bb1d1 100644 > --- a/Documentation/devicetree/bindings/serial/of-serial.txt > +++ b/Documentation/devicetree/bindings/serial/of-serial.txt > @@ -14,6 +14,7 @@ Required properties: > - "altr,16550-FIFO32" > - "altr,16550-FIFO64" > - "altr,16550-FIFO128" > + - "sprd,serial" Is there not a more specific name? I'd imagine you might build a different uart in future. I didn't spot "sprd" in vendor-prefixes.txt in mainline. Is there a patch adding that? Mark. > - "serial" if the port type is unknown. > - reg : offset and length of the register set for the device. > - interrupts : should contain uart interrupt. > -- > 1.7.9.5 > >
On 2014?10?01? 19:21, Mark Rutland wrote: >> diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt >> >index 7705477..a0bb1d1 100644 >> >--- a/Documentation/devicetree/bindings/serial/of-serial.txt >> >+++ b/Documentation/devicetree/bindings/serial/of-serial.txt >> >@@ -14,6 +14,7 @@ Required properties: >> > - "altr,16550-FIFO32" >> > - "altr,16550-FIFO64" >> > - "altr,16550-FIFO128" >> >+ - "sprd,serial" > Is there not a more specific name? I'd imagine you might build a > different uart in future. AFAIK, sprd's uart is re-used the same ip core in ARM 32bit chip. so it is neither 16550 or pl011 compatible. > > I didn't spot "sprd" in vendor-prefixes.txt in mainline. Is there a > patch adding that? sorry for missing it. we'll add it at patch V2. thanks for reviewing! :) > > Mark. >
diff --git a/Documentation/devicetree/bindings/serial/of-serial.txt b/Documentation/devicetree/bindings/serial/of-serial.txt index 7705477..a0bb1d1 100644 --- a/Documentation/devicetree/bindings/serial/of-serial.txt +++ b/Documentation/devicetree/bindings/serial/of-serial.txt @@ -14,6 +14,7 @@ Required properties: - "altr,16550-FIFO32" - "altr,16550-FIFO64" - "altr,16550-FIFO128" + - "sprd,serial" - "serial" if the port type is unknown. - reg : offset and length of the register set for the device. - interrupts : should contain uart interrupt.