diff mbox

[6/10] omap mailbox: remove unnecessary arg for omap_mbox_msg_send

Message ID B85A65D85D7EB246BE421B3FB0FBB59301DD6108F0@dbde02.ent.ti.com (mailing list archive)
State Superseded, archived
Headers show

Commit Message

C.A, Subramaniam Sept. 4, 2009, 11:48 a.m. UTC 
From 4e4fbfa64b2b77ec6f1140178770a70ff6f8caed Mon Sep 17 00:00:00 2001
From: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Date: Wed, 2 Sep 2009 20:14:24 +0530
Subject: [PATCH 6/10] omap mailbox: remove unnecessary arg for omap_mbox_msg_send

Signed-off-by: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
---
 arch/arm/plat-omap/include/mach/mailbox.h |    2 +-
 arch/arm/plat-omap/mailbox.c              |    3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Russell King Sept. 7, 2009, 3:02 p.m. UTC | #1 
On Fri, Sep 04, 2009 at 05:18:04PM +0530, C.A, Subramaniam wrote:
> @@ -114,7 +114,6 @@ int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg, void* arg)
>  	}
>  
>  	tx_data->msg = msg;
> -	tx_data->arg = arg;

What about also removing 'arg' from struct omap_msg_tx_data ?
C.A, Subramaniam Sept. 7, 2009, 3:32 p.m. UTC | #2 
Hi Russell,
'arg' is used later in Patch 10, as part of the tasklet implementation, for writing messages to the mailbox. Should I be removing it in patch 6 and introduce it only for the tasklet implementation?

Thank you and regards
Subbu 

> -----Original Message-----
> From: Russell King [mailto:rmk@arm.linux.org.uk] 
> Sent: Monday, September 07, 2009 8:33 PM
> To: C.A, Subramaniam
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; 
> Hiroshi.DOYU@nokia.com; Kanigeri, Hari; Gupta, Ramesh
> Subject: Re: [PATCH 6/10] omap mailbox: remove unnecessary 
> arg for omap_mbox_msg_send
> 
> On Fri, Sep 04, 2009 at 05:18:04PM +0530, C.A, Subramaniam wrote:
> > @@ -114,7 +114,6 @@ int omap_mbox_msg_send(struct omap_mbox 
> *mbox, mbox_msg_t msg, void* arg)
> >  	}
> >  
> >  	tx_data->msg = msg;
> > -	tx_data->arg = arg;
> 
> What about also removing 'arg' from struct omap_msg_tx_data ?
> 
> --
> Russell King
>  Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
>  maintainer of:
> 
> --
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Santosh Shilimkar Sept. 7, 2009, 3:37 p.m. UTC | #3 
Subbu,
> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org [mailto:linux-omap-
> owner@vger.kernel.org] On Behalf Of C.A, Subramaniam
> Sent: Monday, September 07, 2009 9:03 PM
> To: Russell King
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; Hiroshi.DOYU@nokia.com;
> Kanigeri, Hari; Gupta, Ramesh
> Subject: RE: [PATCH 6/10] omap mailbox: remove unnecessary arg for
> omap_mbox_msg_send
> 
> Hi Russell,
> 'arg' is used later in Patch 10, as part of the tasklet implementation,
> for writing messages to the mailbox. Should I be removing it in patch 6
> and introduce it only for the tasklet implementation?
> 

 Avoid top posting !!
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
C.A, Subramaniam Sept. 7, 2009, 3:44 p.m. UTC | #4 
Santhosh,

> -----Original Message-----
> From: Shilimkar, Santosh 
> Sent: Monday, September 07, 2009 9:08 PM
> To: C.A, Subramaniam; Russell King
> Cc: linux-omap@vger.kernel.org; tony@atomide.com; 
> Hiroshi.DOYU@nokia.com; Kanigeri, Hari; Gupta, Ramesh
> Subject: RE: [PATCH 6/10] omap mailbox: remove unnecessary 
> arg for omap_mbox_msg_send
> 
> Subbu,
> > -----Original Message-----
> > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- 
> > owner@vger.kernel.org] On Behalf Of C.A, Subramaniam
> > Sent: Monday, September 07, 2009 9:03 PM
> > To: Russell King
> > Cc: linux-omap@vger.kernel.org; tony@atomide.com; 
> > Hiroshi.DOYU@nokia.com; Kanigeri, Hari; Gupta, Ramesh
> > Subject: RE: [PATCH 6/10] omap mailbox: remove unnecessary arg for 
> > omap_mbox_msg_send
> > 
> > Hi Russell,
> > 'arg' is used later in Patch 10, as part of the tasklet 
> > implementation, for writing messages to the mailbox. Should I be 
> > removing it in patch 6 and introduce it only for the 
> tasklet implementation?
> > 
> 
>  Avoid top posting !!
> 
Thank you for pointing that out. Sorry for the confusion!

Thank you and Regards
Subbu--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/plat-omap/include/mach/mailbox.h b/arch/arm/plat-omap/include/mach/mailbox.h
index 319306a..8260a3f 100644
--- a/arch/arm/plat-omap/include/mach/mailbox.h
+++ b/arch/arm/plat-omap/include/mach/mailbox.h
@@ -63,7 +63,7 @@  struct omap_mbox {
 	void			(*err_notify)(void);
 };
 
-int omap_mbox_msg_send(struct omap_mbox *, mbox_msg_t msg, void *);
+int omap_mbox_msg_send(struct omap_mbox *, mbox_msg_t msg);
 void omap_mbox_init_seq(struct omap_mbox *);
 
 struct omap_mbox *omap_mbox_get(const char *);
diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index 8a6d087..b7c0d5f 100644
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -97,7 +97,7 @@  static void omap_msg_tx_end_io(struct request *rq, int error)
 	__blk_put_request(rq->q, rq);
 }
 
-int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg, void* arg)
+int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg)
 {
 	struct omap_msg_tx_data *tx_data;
 	struct request *rq;
@@ -114,7 +114,6 @@  int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg, void* arg)
 	}
 
 	tx_data->msg = msg;
-	tx_data->arg = arg;
 	rq->end_io = omap_msg_tx_end_io;
 	blk_insert_request(q, rq, 0, tx_data);