| Message ID | 1414325129-16570-1-git-send-email-tskd08@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 10/26/2014 02:05 PM, tskd08@gmail.com wrote: > From: Akihiro Tsukada <tskd08@gmail.com> > > Reported by David Binderman ^^ See Documentation/SubmittingPatches Antti > --- > drivers/media/dvb-frontends/tc90522.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c > index d9905fb..bca81ef 100644 > --- a/drivers/media/dvb-frontends/tc90522.c > +++ b/drivers/media/dvb-frontends/tc90522.c > @@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe) > u8 v; > > c->isdbt_partial_reception = val[0] & 0x01; > - c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01; > + c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40; > > /* layer A */ > v = (val[2] & 0x78) >> 3; >
>> Reported by David Binderman > > ^^ See Documentation/SubmittingPatches Though I knew that Reported-by: tag should not be used, I wrote it just to express my appreciation for his report, and did not mean to attach the tag. But I admit that it is confusing, so I'd like to beg Mauro to do me the kindness to delete the line when this patch is committed. (or I'll re-send the patch if it is necessary.) regards, akihiro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote: >>> Reported by David Binderman >> >> ^^ See Documentation/SubmittingPatches > > Though I knew that Reported-by: tag should not be used, > I wrote it just to express my appreciation for his report, > and did not mean to attach the tag. > But I admit that it is confusing, > so I'd like to beg Mauro to do me the kindness > to delete the line when this patch is committed. > (or I'll re-send the patch if it is necessary.) Main reason I picked it up, was that tag was formally bad. regards Antti
Em Sun, 26 Oct 2014 18:27:28 +0200 Antti Palosaari <crope@iki.fi> escreveu: > > > On 10/26/2014 03:58 PM, Akihiro TSUKADA wrote: > >>> Reported by David Binderman > >> > >> ^^ See Documentation/SubmittingPatches > > > > Though I knew that Reported-by: tag should not be used, > > I wrote it just to express my appreciation for his report, > > and did not mean to attach the tag. > > But I admit that it is confusing, > > so I'd like to beg Mauro to do me the kindness > > to delete the line when this patch is committed. > > (or I'll re-send the patch if it is necessary.) > > Main reason I picked it up, was that tag was formally bad. Yeah, the tag should be Reported-by: and should have the email of the person who reported the issue. But that's not the only thing you forgot... there's no SOB on this patch ;) Please resend. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I already posted v2 to this ML, but it was at top-level, not in-reply-to this thread. Sorry for the confusing posts. v2 of this patch: https://patchwork.linuxtv.org/patch/26652/ and the other two patches https://patchwork.linuxtv.org/patch/26651/ https://patchwork.linuxtv.org/patch/26653/ regards, Akihiro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c index d9905fb..bca81ef 100644 --- a/drivers/media/dvb-frontends/tc90522.c +++ b/drivers/media/dvb-frontends/tc90522.c @@ -363,7 +363,7 @@ static int tc90522t_get_frontend(struct dvb_frontend *fe) u8 v; c->isdbt_partial_reception = val[0] & 0x01; - c->isdbt_sb_mode = (val[0] & 0xc0) == 0x01; + c->isdbt_sb_mode = (val[0] & 0xc0) == 0x40; /* layer A */ v = (val[2] & 0x78) >> 3;
From: Akihiro Tsukada <tskd08@gmail.com> Reported by David Binderman --- drivers/media/dvb-frontends/tc90522.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)