| Message ID | 1408253089-9487-1-git-send-email-olli.salonen@iki.fi (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Olli, Em Sun, 17 Aug 2014 08:24:49 +0300 Olli Salonen <olli.salonen@iki.fi> escreveu: > Set the property for delivery system also in case of SYS_ATSC. This > behaviour is observed in the sniffs taken with Hauppauge HVR-955Q > Windows driver. > > Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > --- > drivers/media/tuners/si2157.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c > index 6c53edb..3b86d59 100644 > --- a/drivers/media/tuners/si2157.c > +++ b/drivers/media/tuners/si2157.c > @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) > bandwidth = 0x0f; > > switch (c->delivery_system) { > + case SYS_ATSC: > + delivery_system = 0x00; > + break; Did you check if it uses the same delivery system also for clear-QAM? If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch upstream: http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Mauro, No, for ClearQAM the delivery_system should be set to 0x10 and this patch does not include that. At the time of submission of that patch I only had the trace from the ATSC case. ATSC & ClearQAM USB sniffs here: http://trsqr.net/olli/hvr955q/ Cheers, -olli On 29 October 2014 11:08, Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote: > Hi Olli, > > Em Sun, 17 Aug 2014 08:24:49 +0300 > Olli Salonen <olli.salonen@iki.fi> escreveu: > >> Set the property for delivery system also in case of SYS_ATSC. This >> behaviour is observed in the sniffs taken with Hauppauge HVR-955Q >> Windows driver. >> >> Signed-off-by: Olli Salonen <olli.salonen@iki.fi> >> --- >> drivers/media/tuners/si2157.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c >> index 6c53edb..3b86d59 100644 >> --- a/drivers/media/tuners/si2157.c >> +++ b/drivers/media/tuners/si2157.c >> @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) >> bandwidth = 0x0f; >> >> switch (c->delivery_system) { >> + case SYS_ATSC: >> + delivery_system = 0x00; >> + break; > > Did you check if it uses the same delivery system also for clear-QAM? > > If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. > > Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch > upstream: > http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a > > Regards, > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Thu, 30 Oct 2014 08:04:29 +0200 Olli Salonen <olli.salonen@iki.fi> escreveu: > Hi Mauro, > > No, for ClearQAM the delivery_system should be set to 0x10 and this > patch does not include that. At the time of submission of that patch I > only had the trace from the ATSC case. Ah, ok. Are you planning to submit a patch for it, and the patches adding support for HVR-955Q? > > ATSC & ClearQAM USB sniffs here: > http://trsqr.net/olli/hvr955q/ Thanks! Regards, Mauro > > Cheers, > -olli > > On 29 October 2014 11:08, Mauro Carvalho Chehab <mchehab@osg.samsung.com> wrote: > > Hi Olli, > > > > Em Sun, 17 Aug 2014 08:24:49 +0300 > > Olli Salonen <olli.salonen@iki.fi> escreveu: > > > >> Set the property for delivery system also in case of SYS_ATSC. This > >> behaviour is observed in the sniffs taken with Hauppauge HVR-955Q > >> Windows driver. > >> > >> Signed-off-by: Olli Salonen <olli.salonen@iki.fi> > >> --- > >> drivers/media/tuners/si2157.c | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c > >> index 6c53edb..3b86d59 100644 > >> --- a/drivers/media/tuners/si2157.c > >> +++ b/drivers/media/tuners/si2157.c > >> @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) > >> bandwidth = 0x0f; > >> > >> switch (c->delivery_system) { > >> + case SYS_ATSC: > >> + delivery_system = 0x00; > >> + break; > > > > Did you check if it uses the same delivery system also for clear-QAM? > > > > If so, this patch is missing SYS_DVBC_ANNEX_B inside this case. > > > > Ah, FYI, I merged the demod used on HVR-955Q at a separate topic branch > > upstream: > > http://git.linuxtv.org/cgit.cgi/media_tree.git/log/?h=lgdt3306a > > > > Regards, > > Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote: > Ah, ok. Are you planning to submit a patch for it, and the patches adding > support for HVR-955Q? I can submit a patch for that, no problem. However, I'm not working with HVR-955Q at the moment. I don't have access to ATSC/ClearQAM signal. If someone is working with that, I can put you in contact with someone who is interested in that device and is able to test. Cheers, -olli -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Olli, Em Thu, 30 Oct 2014 12:32:33 +0200 Olli Salonen <olli.salonen@iki.fi> escreveu: > On Thu, 30 Oct 2014, Mauro Carvalho Chehab wrote: > > > Ah, ok. Are you planning to submit a patch for it, and the patches adding > > support for HVR-955Q? > > I can submit a patch for that, no problem. Yes, please do that. > However, I'm not working with > HVR-955Q at the moment. I don't have access to ATSC/ClearQAM signal. Ah, ok. I have it here and I have ATSC/ClearQAM here, so I can do the patches. I was just wanting to know if someone else is doing it already. > If someone is working with that, I can put you in contact with someone > who is interested in that device and is able to test. Regards, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/tuners/si2157.c b/drivers/media/tuners/si2157.c index 6c53edb..3b86d59 100644 --- a/drivers/media/tuners/si2157.c +++ b/drivers/media/tuners/si2157.c @@ -239,6 +239,9 @@ static int si2157_set_params(struct dvb_frontend *fe) bandwidth = 0x0f; switch (c->delivery_system) { + case SYS_ATSC: + delivery_system = 0x00; + break; case SYS_DVBT: case SYS_DVBT2: /* it seems DVB-T and DVB-T2 both are 0x20 here */ delivery_system = 0x20;
Set the property for delivery system also in case of SYS_ATSC. This behaviour is observed in the sniffs taken with Hauppauge HVR-955Q Windows driver. Signed-off-by: Olli Salonen <olli.salonen@iki.fi> --- drivers/media/tuners/si2157.c | 3 +++ 1 file changed, 3 insertions(+)