| Message ID | 1414663725-2195-2-git-send-email-ray.huang@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > It enables hibernation if the function is set in coreConsultant. > > Suggested-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Huang Rui <ray.huang@amd.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > Something went wrong with the Signed-off-by lines here. You should never add someone else's Signed-off-by below yours. I took a brief look at the entire series and the patches all look good to me, but you have made the same mistake with the Signed-off-by multiple times. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > It enables hibernation if the function is set in coreConsultant. > > > > Suggested-by: Felipe Balbi <balbi@ti.com> > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > > Something went wrong with the Signed-off-by lines here. > You should never add someone else's Signed-off-by below yours. > > I took a brief look at the entire series and the patches all look good > to me, but you have made the same mistake with the Signed-off-by > multiple times. > Actually, this patch is applied at testing branch, so Felipe added his Signed-off-by. Please see: http://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=testing/next&id=5c9669f92c9441d134f7776274e9afb71c246acc I just update some comment description in V4. Thanks, Rui -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > It enables hibernation if the function is set in coreConsultant. > > > > Suggested-by: Felipe Balbi <balbi@ti.com> > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > > Something went wrong with the Signed-off-by lines here. > You should never add someone else's Signed-off-by below yours. > > I took a brief look at the entire series and the patches all look good > to me, but you have made the same mistake with the Signed-off-by > multiple times. there are no mistakes, I just asked Huang to resend what I had on my testing/next because it had not been sent to devicetree mailing list.
On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: > On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > > It enables hibernation if the function is set in coreConsultant. > > > > > > Suggested-by: Felipe Balbi <balbi@ti.com> > > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > > > > > Something went wrong with the Signed-off-by lines here. > > You should never add someone else's Signed-off-by below yours. > > > > I took a brief look at the entire series and the patches all look good > > to me, but you have made the same mistake with the Signed-off-by > > multiple times. > > there are no mistakes, I just asked Huang to resend what I had on my > testing/next because it had not been sent to devicetree mailing list. > It's definitely a tricky question what the right Signed-off-by chain is in this case, I guess strictly speaking it could have been Suggested-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Huang Rui <ray.huang@amd.com> Signed-off-by: Felipe Balbi <balbi@ti.com> Signed-off-by: Huang Rui <ray.huang@amd.com> which could correctly track where the patches went, but it's also somewhat silly. I would probably just have dropped the second Signed-off-by, so that the last S-o-b in the patch matches the "From", as we expect. It's definitely good to know that Huang Rui was not faking your Signed-off-by but that you had actually provided it yourself. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Oct 30, 2014 at 03:14:17PM +0100, Arnd Bergmann wrote: > On Thursday 30 October 2014 09:08:32 Felipe Balbi wrote: > > On Thu, Oct 30, 2014 at 12:35:56PM +0100, Arnd Bergmann wrote: > > > On Thursday 30 October 2014 18:08:26 Huang Rui wrote: > > > > It enables hibernation if the function is set in coreConsultant. > > > > > > > > Suggested-by: Felipe Balbi <balbi@ti.com> > > > > Signed-off-by: Huang Rui <ray.huang@amd.com> > > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > > > > > > > > Something went wrong with the Signed-off-by lines here. > > > You should never add someone else's Signed-off-by below yours. > > > > > > I took a brief look at the entire series and the patches all look good > > > to me, but you have made the same mistake with the Signed-off-by > > > multiple times. > > > > there are no mistakes, I just asked Huang to resend what I had on my > > testing/next because it had not been sent to devicetree mailing list. > > > > It's definitely a tricky question what the right Signed-off-by > chain is in this case, I guess strictly speaking it could have > been > > Suggested-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Huang Rui <ray.huang@amd.com> > Signed-off-by: Felipe Balbi <balbi@ti.com> > Signed-off-by: Huang Rui <ray.huang@amd.com> > > which could correctly track where the patches went, but it's also > somewhat silly. somewhat ? You don't need to be so black and white.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index fa396fc..5a47482 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -447,8 +447,14 @@ static int dwc3_core_init(struct dwc3 *dwc) reg &= ~DWC3_GCTL_DSBLCLKGTNG; break; case DWC3_GHWPARAMS1_EN_PWROPT_HIB: - /* enable hibernation here */ dwc->nr_scratch = DWC3_GHWPARAMS4_HIBER_SCRATCHBUFS(hwparams4); + /* + * Enable hibernation here. + * + * Enabling this bit so that host-mode hibernation will + * work, device-mode hibernation is not implemented yet. + */ + reg |= DWC3_GCTL_GBLHIBERNATIONEN; break; default: dev_dbg(dwc->dev, "No power optimization available\n");