[v2,1/1] ARM: exynos_defconfig: Enable options for display panel support

Commit Message

Javier Martinez Canillas Aug. 25, 2014, 8:45 a.m. UTC

Many Exynos devices have a display panel. Most of them just have
a simple panel while others have more complex configurations that
requires an embedded DisplayPort (eDP) to LVDS bridges.

This patch enables the following features to be built in the kernel
image to suport both setups:

- Direct Rendering Manager (DRM)
- DRM bridge registration and lookup framework
- Parade ps8622/ps8625 eDP/LVDS bridge
- NXP ptn3460 eDP/LVDS bridge
- Exynos Fully Interactive Mobile Display controller (FIMD)
- Panel registration and lookup framework
- Simple panels
- Backlight & LCD device support

Signed-off-by: Javier Martinez Canillas <[e-mail]>
Tested-by: Kevin Hilman <[e-mail]>
---

Changes since v1:
 - Forgot to enable ptn3460 eDP/LVDS bridge config option
   which is used for some boards (e.g: Exynos5250 Snow).

 arch/arm/configs/exynos_defconfig | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Bartlomiej Zolnierkiewicz Aug. 25, 2014, 11:43 a.m. UTC | #1

Hi,

On Monday, August 25, 2014 10:45:36 AM Javier Martinez Canillas wrote:
> Many Exynos devices have a display panel. Most of them just have
> a simple panel while others have more complex configurations that
> requires an embedded DisplayPort (eDP) to LVDS bridges.
> 
> This patch enables the following features to be built in the kernel
> image to suport both setups:
> 
> - Direct Rendering Manager (DRM)
> - DRM bridge registration and lookup framework
> - Parade ps8622/ps8625 eDP/LVDS bridge
> - NXP ptn3460 eDP/LVDS bridge
> - Exynos Fully Interactive Mobile Display controller (FIMD)
> - Panel registration and lookup framework
> - Simple panels
> - Backlight & LCD device support
> 
> Signed-off-by: Javier Martinez Canillas <[e-mail]>
> Tested-by: Kevin Hilman <[e-mail]>

Could you please also do corresponding update to multi_v7_defconfig?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

> ---
> 
> Changes since v1:
>  - Forgot to enable ptn3460 eDP/LVDS bridge config option
>    which is used for some boards (e.g: Exynos5250 Snow).
> 
>  arch/arm/configs/exynos_defconfig | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 676c744..d6d1f7c 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -101,11 +101,26 @@ CONFIG_REGULATOR_S2MPA01=y
>  CONFIG_REGULATOR_S2MPS11=y
>  CONFIG_REGULATOR_S5M8767=y
>  CONFIG_REGULATOR_TPS65090=y
> +CONFIG_DRM=y
> +CONFIG_DRM_BRIDGE=y
> +CONFIG_DRM_PTN3460=y
> +CONFIG_DRM_PS8622=y
> +CONFIG_DRM_EXYNOS=y
> +CONFIG_DRM_EXYNOS_FIMD=y
> +CONFIG_DRM_EXYNOS_DP=y
> +CONFIG_DRM_PANEL=y
> +CONFIG_DRM_PANEL_SIMPLE=y
>  CONFIG_FB=y
>  CONFIG_FB_MODE_HELPERS=y
>  CONFIG_FB_SIMPLE=y
>  CONFIG_EXYNOS_VIDEO=y
>  CONFIG_EXYNOS_MIPI_DSI=y
> +CONFIG_BACKLIGHT_LCD_SUPPORT=y
> +CONFIG_LCD_CLASS_DEVICE=y
> +CONFIG_LCD_PLATFORM=y
> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
> +CONFIG_BACKLIGHT_GENERIC=y
> +CONFIG_BACKLIGHT_PWM=y
>  CONFIG_FRAMEBUFFER_CONSOLE=y
>  CONFIG_FONTS=y
>  CONFIG_FONT_7x14=y

Javier Martinez Canillas Aug. 25, 2014, 11:49 a.m. UTC | #2

Hello Bartlomiej,

On 08/25/2014 01:43 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Monday, August 25, 2014 10:45:36 AM Javier Martinez Canillas wrote:
>> Many Exynos devices have a display panel. Most of them just have
>> a simple panel while others have more complex configurations that
>> requires an embedded DisplayPort (eDP) to LVDS bridges.
>> 
>> This patch enables the following features to be built in the kernel
>> image to suport both setups:
>> 
>> - Direct Rendering Manager (DRM)
>> - DRM bridge registration and lookup framework
>> - Parade ps8622/ps8625 eDP/LVDS bridge
>> - NXP ptn3460 eDP/LVDS bridge
>> - Exynos Fully Interactive Mobile Display controller (FIMD)
>> - Panel registration and lookup framework
>> - Simple panels
>> - Backlight & LCD device support
>> 
>> Signed-off-by: Javier Martinez Canillas <[e-mail]>
>> Tested-by: Kevin Hilman <[e-mail]>
> 
> Could you please also do corresponding update to multi_v7_defconfig?
> 

Sure, I'll do once the PTN3460 and PS8622 bridge drivers get merged since
this patch depends on those and I would prefer to not have so many
in-flight patches with dependencies.

I just posted this patch before these two drivers landed because I noticed
that many people were wasting time figuring out the correct set of options
in order to have display working.

> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 
>> ---

Best regards,
Javier

Andreas Färber Aug. 25, 2014, 11:49 a.m. UTC | #3

Hi,

Am 25.08.2014 13:43, schrieb Bartlomiej Zolnierkiewicz:
> On Monday, August 25, 2014 10:45:36 AM Javier Martinez Canillas wrote:
>> Many Exynos devices have a display panel. Most of them just have
>> a simple panel while others have more complex configurations that
>> requires an embedded DisplayPort (eDP) to LVDS bridges.
>>
>> This patch enables the following features to be built in the kernel
>> image to suport both setups:
>>
>> - Direct Rendering Manager (DRM)
>> - DRM bridge registration and lookup framework
>> - Parade ps8622/ps8625 eDP/LVDS bridge
>> - NXP ptn3460 eDP/LVDS bridge
>> - Exynos Fully Interactive Mobile Display controller (FIMD)
>> - Panel registration and lookup framework
>> - Simple panels
>> - Backlight & LCD device support
>>
>> Signed-off-by: Javier Martinez Canillas <[e-mail]>
>> Tested-by: Kevin Hilman <[e-mail]>
> 
> Could you please also do corresponding update to multi_v7_defconfig?

As was mentioned in v1 (but now below), some of these options depend on
patches yet to be respun and be accepted into drm, so I would consider
this an RFC patch and suggest to wait with multi_v7.

It could of course be split, as CONFIG_DRM_EXYNOS* and backlight parts
are certainly okay.

Regards,
Andreas

> 
> Best regards,
> --
> Bartlomiej Zolnierkiewicz
> Samsung R&D Institute Poland
> Samsung Electronics
> 
>> ---
>>
>> Changes since v1:
>>  - Forgot to enable ptn3460 eDP/LVDS bridge config option
>>    which is used for some boards (e.g: Exynos5250 Snow).
>>
>>  arch/arm/configs/exynos_defconfig | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>> index 676c744..d6d1f7c 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -101,11 +101,26 @@ CONFIG_REGULATOR_S2MPA01=y
>>  CONFIG_REGULATOR_S2MPS11=y
>>  CONFIG_REGULATOR_S5M8767=y
>>  CONFIG_REGULATOR_TPS65090=y
>> +CONFIG_DRM=y
>> +CONFIG_DRM_BRIDGE=y
>> +CONFIG_DRM_PTN3460=y
>> +CONFIG_DRM_PS8622=y
>> +CONFIG_DRM_EXYNOS=y
>> +CONFIG_DRM_EXYNOS_FIMD=y
>> +CONFIG_DRM_EXYNOS_DP=y
>> +CONFIG_DRM_PANEL=y
>> +CONFIG_DRM_PANEL_SIMPLE=y
>>  CONFIG_FB=y
>>  CONFIG_FB_MODE_HELPERS=y
>>  CONFIG_FB_SIMPLE=y
>>  CONFIG_EXYNOS_VIDEO=y
>>  CONFIG_EXYNOS_MIPI_DSI=y
>> +CONFIG_BACKLIGHT_LCD_SUPPORT=y
>> +CONFIG_LCD_CLASS_DEVICE=y
>> +CONFIG_LCD_PLATFORM=y
>> +CONFIG_BACKLIGHT_CLASS_DEVICE=y
>> +CONFIG_BACKLIGHT_GENERIC=y
>> +CONFIG_BACKLIGHT_PWM=y
>>  CONFIG_FRAMEBUFFER_CONSOLE=y
>>  CONFIG_FONTS=y
>>  CONFIG_FONT_7x14=y
>

Javier Martinez Canillas Aug. 25, 2014, 11:54 a.m. UTC | #4

Hello Andreas,

On 08/25/2014 01:49 PM, Andreas Färber wrote:
>> 
>> Could you please also do corresponding update to multi_v7_defconfig?
> 
> As was mentioned in v1 (but now below), some of these options depend on

Sorry for missing the mention about the dependencies on v2...

> patches yet to be respun and be accepted into drm, so I would consider
> this an RFC patch and suggest to wait with multi_v7.
> 

Agreed, I just sent an email to Bartlomiej saying the same.

> It could of course be split, as CONFIG_DRM_EXYNOS* and backlight parts
> are certainly okay.
>

Also agreed.

> Regards,
> Andreas

Best regards,
Javier

Javier Martinez Canillas Oct. 31, 2014, 11:42 p.m. UTC | #5

Hello Kukjin,

On Mon, Aug 25, 2014 at 10:45 AM, Javier Martinez Canillas
<[e-mail]> wrote:
> Many Exynos devices have a display panel. Most of them just have
> a simple panel while others have more complex configurations that
> requires an embedded DisplayPort (eDP) to LVDS bridges.
>
> This patch enables the following features to be built in the kernel
> image to suport both setups:
>
> - Direct Rendering Manager (DRM)
> - DRM bridge registration and lookup framework
> - Parade ps8622/ps8625 eDP/LVDS bridge
> - NXP ptn3460 eDP/LVDS bridge
> - Exynos Fully Interactive Mobile Display controller (FIMD)
> - Panel registration and lookup framework
> - Simple panels
> - Backlight & LCD device support
>
> Signed-off-by: Javier Martinez Canillas <[e-mail]>
> Tested-by: Kevin Hilman <[e-mail]>
> ---

This patch is needed to have display working on many Exynos boards.

$subject enables the config option for the ps8622/ps8625 eDP/LVDS
bridge driver but this has not landed in mainline yet. Ajay will
re-spin a new revision of his series that adds this driver though,
after addressing some issues pointed out on a previous version.

The Kconfig symbol name (DRM_PS8622) won't change though so maybe is
not crazy to pick the patch as is since CONFIG_DRM_PS8622 will have to
be enabled later when the bridge driver lands. Or do you want me to
re-spin $subject removing that option?

Best regards,
Javier

[e-mail] Nov. 8, 2014, 9:46 a.m. UTC | #6

Javier Martinez Canillas wrote:
> 
> Hello Kukjin,
> 
Hi,

> On Mon, Aug 25, 2014 at 10:45 AM, Javier Martinez Canillas
> <[e-mail]> wrote:
> > Many Exynos devices have a display panel. Most of them just have
> > a simple panel while others have more complex configurations that
> > requires an embedded DisplayPort (eDP) to LVDS bridges.
> >
> > This patch enables the following features to be built in the kernel
> > image to suport both setups:
> >
> > - Direct Rendering Manager (DRM)
> > - DRM bridge registration and lookup framework
> > - Parade ps8622/ps8625 eDP/LVDS bridge
> > - NXP ptn3460 eDP/LVDS bridge
> > - Exynos Fully Interactive Mobile Display controller (FIMD)
> > - Panel registration and lookup framework
> > - Simple panels
> > - Backlight & LCD device support
> >
> > Signed-off-by: Javier Martinez Canillas <[e-mail]>
> > Tested-by: Kevin Hilman <[e-mail]>
> > ---
> 
> This patch is needed to have display working on many Exynos boards.
> 
OK, I'll apply this into samsung tree in this weekend.

Thanks for your gentle reminder.

- Kukjin

> $subject enables the config option for the ps8622/ps8625 eDP/LVDS
> bridge driver but this has not landed in mainline yet. Ajay will
> re-spin a new revision of his series that adds this driver though,
> after addressing some issues pointed out on a previous version.
> 
> The Kconfig symbol name (DRM_PS8622) won't change though so maybe is
> not crazy to pick the patch as is since CONFIG_DRM_PS8622 will have to
> be enabled later when the bridge driver lands. Or do you want me to
> re-spin $subject removing that option?
> 
> Best regards,
> Javier

Patch

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 676c744..d6d1f7c 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -101,11 +101,26 @@  CONFIG_REGULATOR_S2MPA01=y
 CONFIG_REGULATOR_S2MPS11=y
 CONFIG_REGULATOR_S5M8767=y
 CONFIG_REGULATOR_TPS65090=y
+CONFIG_DRM=y
+CONFIG_DRM_BRIDGE=y
+CONFIG_DRM_PTN3460=y
+CONFIG_DRM_PS8622=y
+CONFIG_DRM_EXYNOS=y
+CONFIG_DRM_EXYNOS_FIMD=y
+CONFIG_DRM_EXYNOS_DP=y
+CONFIG_DRM_PANEL=y
+CONFIG_DRM_PANEL_SIMPLE=y
 CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_FB_SIMPLE=y
 CONFIG_EXYNOS_VIDEO=y
 CONFIG_EXYNOS_MIPI_DSI=y
+CONFIG_BACKLIGHT_LCD_SUPPORT=y
+CONFIG_LCD_CLASS_DEVICE=y
+CONFIG_LCD_PLATFORM=y
+CONFIG_BACKLIGHT_CLASS_DEVICE=y
+CONFIG_BACKLIGHT_GENERIC=y
+CONFIG_BACKLIGHT_PWM=y
 CONFIG_FRAMEBUFFER_CONSOLE=y
 CONFIG_FONTS=y
 CONFIG_FONT_7x14=y