| Message ID | 1398657227-20721-2-git-send-email-b32955@freescale.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
On Monday, April 28, 2014 at 05:53:38 AM, Huang Shijie wrote: > For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. > The dummy cycles is actually 8 for SPI fast/dual/quad read. > > This patch makes preparations for the DDR quad read, it fixes the wrong > dummy value for both the spi-nor.c and m25p80.c. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > This ia actually v3. Acked-by: Marek Vasut <marex@denx.de> Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Apr 28, 2014 at 11:53:38AM +0800, Huang Shijie wrote: > For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. > The dummy cycles is actually 8 for SPI fast/dual/quad read. > > This patch makes preparations for the DDR quad read, it fixes the wrong dummy > value for both the spi-nor.c and m25p80.c. > > Signed-off-by: Huang Shijie <b32955@freescale.com> > --- > This ia actually v3. Don't know why this got left behind. Applied to l2-mtd.git. Brian -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c index 1557d8f..3a1d9e0 100644 --- a/drivers/mtd/devices/m25p80.c +++ b/drivers/mtd/devices/m25p80.c @@ -128,9 +128,12 @@ static int m25p80_read(struct spi_nor *nor, loff_t from, size_t len, struct spi_device *spi = flash->spi; struct spi_transfer t[2]; struct spi_message m; - int dummy = nor->read_dummy; + unsigned int dummy = nor->read_dummy; int ret; + /* convert the dummy cycles to the number of bytes */ + dummy /= 8; + /* Wait till previous write/erase is done. */ ret = nor->wait_till_ready(nor); if (ret) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index f76f3fc..1a12f81 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++ b/drivers/mtd/spi-nor/spi-nor.c @@ -77,7 +77,7 @@ static inline int spi_nor_read_dummy_cycles(struct spi_nor *nor) case SPI_NOR_FAST: case SPI_NOR_DUAL: case SPI_NOR_QUAD: - return 1; + return 8; case SPI_NOR_NORMAL: return 0; }
For the DDR Quad read, the dummy cycles maybe 3 or 6 which is less then 8. The dummy cycles is actually 8 for SPI fast/dual/quad read. This patch makes preparations for the DDR quad read, it fixes the wrong dummy value for both the spi-nor.c and m25p80.c. Signed-off-by: Huang Shijie <b32955@freescale.com> --- This ia actually v3. --- drivers/mtd/devices/m25p80.c | 5 ++++- drivers/mtd/spi-nor/spi-nor.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-)