| Message ID | a44efc1fb0144cca9d0c4851cc51db25@BL2FFO11FD024.protection.gbl (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/13/2014 07:58 AM, Kedareswara rao Appana wrote: > When accessing the priv structure use container_of instead of dev_get_drvdata. Why? > Enable the clocks in the suspend before accessing the registers of the CAN. > > Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > --- > drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- > 1 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c > index 5e8b560..63ef645 100644 > --- a/drivers/net/can/xilinx_can.c > +++ b/drivers/net/can/xilinx_can.c > @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { > */ > static int __maybe_unused xcan_suspend(struct device *dev) > { > - struct platform_device *pdev = dev_get_drvdata(dev); > + struct platform_device *pdev = container_of(dev, > + struct platform_device, dev); > struct net_device *ndev = platform_get_drvdata(pdev); > struct xcan_priv *priv = netdev_priv(ndev); > + int ret; > > if (netif_running(ndev)) { > netif_stop_queue(ndev); > netif_device_detach(ndev); > } > > + ret = clk_prepare_enable(priv->can_clk); > + if (ret) { > + dev_err(dev, "unable to enable device clock\n"); > + return ret; > + } > + > + ret = clk_prepare_enable(priv->bus_clk); > + if (ret) { > + dev_err(dev, "unable to enable bus clock\n"); > + clk_disable_unprepare(priv->can_clk); > + return ret; > + } Now you have clock imbalance. Per suspend/resume cycle the clocks are enabled twice, but disabled only once. > + > priv->write_reg(priv, XCAN_MSR_OFFSET, XCAN_MSR_SLEEP_MASK); > priv->can.state = CAN_STATE_SLEEPING; > > @@ -999,7 +1014,8 @@ static int __maybe_unused xcan_suspend(struct device *dev) > */ > static int __maybe_unused xcan_resume(struct device *dev) > { > - struct platform_device *pdev = dev_get_drvdata(dev); > + struct platform_device *pdev = container_of(dev, > + struct platform_device, dev); > struct net_device *ndev = platform_get_drvdata(pdev); > struct xcan_priv *priv = netdev_priv(ndev); > int ret; > Marc
On 11/13/2014 11:15 AM, Marc Kleine-Budde wrote: > On 11/13/2014 07:58 AM, Kedareswara rao Appana wrote: >> When accessing the priv structure use container_of instead of dev_get_drvdata. > > Why? The drvdata here is the struct net_device, not the platform device. Please state this in the commit message. If I understand the code correct, you can make use of the existing helper function to_platform_device(): http://lxr.free-electrons.com/source/include/linux/platform_device.h#L42 > >> Enable the clocks in the suspend before accessing the registers of the CAN. >> >> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> >> --- >> drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- >> 1 files changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c >> index 5e8b560..63ef645 100644 >> --- a/drivers/net/can/xilinx_can.c >> +++ b/drivers/net/can/xilinx_can.c >> @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { >> */ >> static int __maybe_unused xcan_suspend(struct device *dev) >> { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> + int ret; >> >> if (netif_running(ndev)) { >> netif_stop_queue(ndev); >> netif_device_detach(ndev); >> } >> >> + ret = clk_prepare_enable(priv->can_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable device clock\n"); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(priv->bus_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable bus clock\n"); >> + clk_disable_unprepare(priv->can_clk); >> + return ret; >> + } > > Now you have clock imbalance. Per suspend/resume cycle the clocks are > enabled twice, but disabled only once. > >> + >> priv->write_reg(priv, XCAN_MSR_OFFSET, XCAN_MSR_SLEEP_MASK); >> priv->can.state = CAN_STATE_SLEEPING; >> >> @@ -999,7 +1014,8 @@ static int __maybe_unused xcan_suspend(struct device *dev) >> */ >> static int __maybe_unused xcan_resume(struct device *dev) >> { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> int ret; Marc
Hi Marc, -----Original Message----- From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] Sent: Thursday, November 13, 2014 4:16 PM To: Appana Durga Kedareswara Rao; wg@grandegger.com; Michal Simek; Soren Brinkmann; grant.likely@linaro.org; robh+dt@kernel.org Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Appana Durga Kedareswara Rao Subject: Re: [PATCH] can: Fix bug in suspend/resume On 11/13/2014 11:15 AM, Marc Kleine-Budde wrote: > On 11/13/2014 07:58 AM, Kedareswara rao Appana wrote: >> When accessing the priv structure use container_of instead of dev_get_drvdata. > > Why? The drvdata here is the struct net_device, not the platform device. Please state this in the commit message. If I understand the code correct, you can make use of the existing helper function to_platform_device(): http://lxr.free-electrons.com/source/include/linux/platform_device.h#L42 Thanks for the suggestion. Will use this macro(to_platform_device) . > >> Enable the clocks in the suspend before accessing the registers of the CAN. >> >> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> >> --- >> drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- >> 1 files changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/can/xilinx_can.c >> b/drivers/net/can/xilinx_can.c index 5e8b560..63ef645 100644 >> --- a/drivers/net/can/xilinx_can.c >> +++ b/drivers/net/can/xilinx_can.c >> @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { >> */ >> static int __maybe_unused xcan_suspend(struct device *dev) { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> + int ret; >> >> if (netif_running(ndev)) { >> netif_stop_queue(ndev); >> netif_device_detach(ndev); >> } >> >> + ret = clk_prepare_enable(priv->can_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable device clock\n"); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(priv->bus_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable bus clock\n"); >> + clk_disable_unprepare(priv->can_clk); >> + return ret; >> + } > > Now you have clock imbalance. Per suspend/resume cycle the clocks are > enabled twice, but disabled only once. > The clocks are getting disabled and un prepared at the end of the probe. In the resume the driver is doing register write. In order to do that register write I have to again enable and prepare the clocks. Regards, Kedar. >> + >> priv->write_reg(priv, XCAN_MSR_OFFSET, XCAN_MSR_SLEEP_MASK); >> priv->can.state = CAN_STATE_SLEEPING; >> >> @@ -999,7 +1014,8 @@ static int __maybe_unused xcan_suspend(struct device *dev) >> */ >> static int __maybe_unused xcan_resume(struct device *dev) { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> int ret; Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Hi Marc, -----Original Message----- From: Appana Durga Kedareswara Rao Sent: Thursday, November 13, 2014 4:28 PM To: 'Marc Kleine-Budde'; wg@grandegger.com; Michal Simek; Soren Brinkmann; grant.likely@linaro.org; robh+dt@kernel.org Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org Subject: RE: [PATCH] can: Fix bug in suspend/resume Hi Marc, -----Original Message----- From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] Sent: Thursday, November 13, 2014 4:16 PM To: Appana Durga Kedareswara Rao; wg@grandegger.com; Michal Simek; Soren Brinkmann; grant.likely@linaro.org; robh+dt@kernel.org Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Appana Durga Kedareswara Rao Subject: Re: [PATCH] can: Fix bug in suspend/resume On 11/13/2014 11:15 AM, Marc Kleine-Budde wrote: > On 11/13/2014 07:58 AM, Kedareswara rao Appana wrote: >> When accessing the priv structure use container_of instead of dev_get_drvdata. > > Why? The drvdata here is the struct net_device, not the platform device. Please state this in the commit message. If I understand the code correct, you can make use of the existing helper function to_platform_device(): http://lxr.free-electrons.com/source/include/linux/platform_device.h#L42 Thanks for the suggestion. Will use this macro(to_platform_device) . > >> Enable the clocks in the suspend before accessing the registers of the CAN. >> >> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> >> --- >> drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- >> 1 files changed, 18 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/can/xilinx_can.c >> b/drivers/net/can/xilinx_can.c index 5e8b560..63ef645 100644 >> --- a/drivers/net/can/xilinx_can.c >> +++ b/drivers/net/can/xilinx_can.c >> @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { >> */ >> static int __maybe_unused xcan_suspend(struct device *dev) { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> + int ret; >> >> if (netif_running(ndev)) { >> netif_stop_queue(ndev); >> netif_device_detach(ndev); >> } >> >> + ret = clk_prepare_enable(priv->can_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable device clock\n"); >> + return ret; >> + } >> + >> + ret = clk_prepare_enable(priv->bus_clk); >> + if (ret) { >> + dev_err(dev, "unable to enable bus clock\n"); >> + clk_disable_unprepare(priv->can_clk); >> + return ret; >> + } > > Now you have clock imbalance. Per suspend/resume cycle the clocks are > enabled twice, but disabled only once. > The clocks are getting disabled and un prepared at the end of the probe. In the resume the driver is doing register write. Sorry spell mistake not in resume in the suspend I am doing a register write. In order to do that register write I have to again enable and prepare the clocks. Regards, Kedar. Regards, Kedar. >> + >> priv->write_reg(priv, XCAN_MSR_OFFSET, XCAN_MSR_SLEEP_MASK); >> priv->can.state = CAN_STATE_SLEEPING; >> >> @@ -999,7 +1014,8 @@ static int __maybe_unused xcan_suspend(struct device *dev) >> */ >> static int __maybe_unused xcan_resume(struct device *dev) { >> - struct platform_device *pdev = dev_get_drvdata(dev); >> + struct platform_device *pdev = container_of(dev, >> + struct platform_device, dev); >> struct net_device *ndev = platform_get_drvdata(pdev); >> struct xcan_priv *priv = netdev_priv(ndev); >> int ret; Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Hi, Appana Durga Kedareswara Rao wrote: > Hi Marc, > > -----Original Message----- > From: Marc Kleine-Budde [mailto:mkl@pengutronix.de] > Sent: Thursday, November 13, 2014 4:16 PM > To: Appana Durga Kedareswara Rao; wg@grandegger.com; Michal Simek; Soren Brinkmann; grant.likely@linaro.org; robh+dt@kernel.org > Cc: linux-can@vger.kernel.org; netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Appana Durga Kedareswara Rao > Subject: Re: [PATCH] can: Fix bug in suspend/resume > > On 11/13/2014 11:15 AM, Marc Kleine-Budde wrote: > > On 11/13/2014 07:58 AM, Kedareswara rao Appana wrote: > >> When accessing the priv structure use container_of instead of dev_get_drvdata. > > > > Why? > > The drvdata here is the struct net_device, not the platform device. > Please state this in the commit message. > > If I understand the code correct, you can make use of the existing helper function to_platform_device(): > > http://lxr.free-electrons.com/source/include/linux/platform_device.h#L42 > > Thanks for the suggestion. > Will use this macro(to_platform_device) . > > > > >> Enable the clocks in the suspend before accessing the registers of the CAN. > >> > >> Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> > >> --- > >> drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- > >> 1 files changed, 18 insertions(+), 2 deletions(-) > >> > >> diff --git a/drivers/net/can/xilinx_can.c > >> b/drivers/net/can/xilinx_can.c index 5e8b560..63ef645 100644 > >> --- a/drivers/net/can/xilinx_can.c > >> +++ b/drivers/net/can/xilinx_can.c > >> @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { > >> */ > >> static int __maybe_unused xcan_suspend(struct device *dev) { > >> - struct platform_device *pdev = dev_get_drvdata(dev); > >> + struct platform_device *pdev = container_of(dev, > >> + struct platform_device, dev); > >> struct net_device *ndev = platform_get_drvdata(pdev); > >> struct xcan_priv *priv = netdev_priv(ndev); > Why not simply: struct net_device *ndev = dev_get_drvdata(dev); There is no need for a struct platform_device* at all. Lothar Waßmann
On 11/13/2014 12:32 PM, Lothar Waßmann wrote: >>>> static int __maybe_unused xcan_suspend(struct device *dev) { >>>> - struct platform_device *pdev = dev_get_drvdata(dev); >>>> + struct platform_device *pdev = container_of(dev, >>>> + struct platform_device, dev); >>>> struct net_device *ndev = platform_get_drvdata(pdev); >>>> struct xcan_priv *priv = netdev_priv(ndev); >> > Why not simply: > struct net_device *ndev = dev_get_drvdata(dev); > > There is no need for a struct platform_device* at all. ACK Marc
diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index 5e8b560..63ef645 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -972,15 +972,30 @@ static const struct net_device_ops xcan_netdev_ops = { */ static int __maybe_unused xcan_suspend(struct device *dev) { - struct platform_device *pdev = dev_get_drvdata(dev); + struct platform_device *pdev = container_of(dev, + struct platform_device, dev); struct net_device *ndev = platform_get_drvdata(pdev); struct xcan_priv *priv = netdev_priv(ndev); + int ret; if (netif_running(ndev)) { netif_stop_queue(ndev); netif_device_detach(ndev); } + ret = clk_prepare_enable(priv->can_clk); + if (ret) { + dev_err(dev, "unable to enable device clock\n"); + return ret; + } + + ret = clk_prepare_enable(priv->bus_clk); + if (ret) { + dev_err(dev, "unable to enable bus clock\n"); + clk_disable_unprepare(priv->can_clk); + return ret; + } + priv->write_reg(priv, XCAN_MSR_OFFSET, XCAN_MSR_SLEEP_MASK); priv->can.state = CAN_STATE_SLEEPING; @@ -999,7 +1014,8 @@ static int __maybe_unused xcan_suspend(struct device *dev) */ static int __maybe_unused xcan_resume(struct device *dev) { - struct platform_device *pdev = dev_get_drvdata(dev); + struct platform_device *pdev = container_of(dev, + struct platform_device, dev); struct net_device *ndev = platform_get_drvdata(pdev); struct xcan_priv *priv = netdev_priv(ndev); int ret;
When accessing the priv structure use container_of instead of dev_get_drvdata. Enable the clocks in the suspend before accessing the registers of the CAN. Signed-off-by: Kedareswara rao Appana <appanad@xilinx.com> --- drivers/net/can/xilinx_can.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-)