diff mbox

[1/2] ARM: dts: Fix bootup issue on smdk5250

Message ID 1416312509-11530-1-git-send-email-yadi.brar@samsung.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yadwinder Singh Brar Nov. 18, 2014, 12:08 p.m. UTC
With default config on smdk5250 latest tree throws below message :

[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue

and hangs randomly because it reads wrong temperature value.

I can't figure out any direct relation between LDO10 and TMU from board
schematics which I have. So making LDO10 always-on to fix issue for now.

Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Comments

Pankaj Dubey Nov. 20, 2014, 4:01 a.m. UTC | #1
Hi,

On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> With default config on smdk5250 latest tree throws below message :
>
> [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
> [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
>
> and hangs randomly because it reads wrong temperature value.
>
> I can't figure out any direct relation between LDO10 and TMU from board
> schematics which I have. So making LDO10 always-on to fix issue for now.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>

Tested this on SMDK5250 board, system boot is fine now, hence

Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>

> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index bc27cc2..95b5b51 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -190,6 +190,7 @@
>   				regulator-name = "P1.8V_LDO_OUT10";
>   				regulator-min-microvolt = <1800000>;
>   				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
>   			};
>
>   			ldo11_reg: LDO11 {
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
kgene@kernel.org Nov. 22, 2014, 3:25 a.m. UTC | #2
Pankaj Dubey wrote:
> 
> Hi,
> 
Hi,

Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client
can't filter wrong ;)

> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> > With default config on smdk5250 latest tree throws below message :
> >
> > [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
> > [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
> >
> > and hangs randomly because it reads wrong temperature value.
> >
> > I can't figure out any direct relation between LDO10 and TMU from board
> > schematics which I have. So making LDO10 always-on to fix issue for now.
> >
Hmm...strange, I also can't see any relations now...but I need to contact to
hardware guy before applying this, this fixes the problem though.

Thanks,
Kukjin

> > Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> >
> 
> Tested this on SMDK5250 board, system boot is fine now, hence
> 
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> 
> > ---
> > arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
> >   1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > index bc27cc2..95b5b51 100644
> > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > @@ -190,6 +190,7 @@
> >   				regulator-name = "P1.8V_LDO_OUT10";
> >   				regulator-min-microvolt = <1800000>;
> >   				regulator-max-microvolt = <1800000>;
> > +				regulator-always-on;
> >   			};
> >
> >   			ldo11_reg: LDO11 {
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Yadwinder Singh Brar Nov. 25, 2014, 1:16 p.m. UTC | #3
Hi Kukjin,

> Subject: RE: [1/2] ARM: dts: Fix bootup issue on smdk5250
> 
> Pankaj Dubey wrote:
> >
> > Hi,
> >
> Hi,
> 
> Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail
> client can't filter wrong ;)
> 

Sure, but I think your mail client had played some trick, as patches
were posted with [PATCH */2] prefix.

> > On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> > > With default config on smdk5250 latest tree throws below message :
> > >
> > > [    2.226049] thermal thermal_zone0: critical temperature
> reached(224 C),shutting down
> > > [    2.227840] reboot: Failed to start orderly shutdown: forcing
> the issue
> > >
> > > and hangs randomly because it reads wrong temperature value.
> > >
> > > I can't figure out any direct relation between LDO10 and TMU from
> > > board schematics which I have. So making LDO10 always-on to fix
> issue for now.
> > >
> Hmm...strange, I also can't see any relations now...but I need to
> contact to hardware guy before applying this, this fixes the problem
> though.
> 

Ok, sure it will be good know actual relation from hardware guy.

Meanwhile can we get another patch[1] merged which was posted along
with patch just because both patches were on same file. Otherwise
there is no dependency between them and can be applied independently.

Best Regards,
Yadwinder

[1] : http://www.spinics.net/lists/linux-samsung-soc/msg39107.html

> Thanks,
> Kukjin
> 
> > > Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> > >
> >
> > Tested this on SMDK5250 board, system boot is fine now, hence
> >
> > Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >
> > > ---
> > > arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
> > >   1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > index bc27cc2..95b5b51 100644
> > > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > @@ -190,6 +190,7 @@
> > >   				regulator-name = "P1.8V_LDO_OUT10";
> > >   				regulator-min-microvolt = <1800000>;
> > >   				regulator-max-microvolt = <1800000>;
> > > +				regulator-always-on;
> > >   			};
> > >
> > >   			ldo11_reg: LDO11 {
> > >

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Pankaj Dubey April 28, 2015, 11:05 a.m. UTC | #4
Hi Kukjin,

On Saturday 22 November 2014 08:55 AM, Kukjin Kim wrote:
> Pankaj Dubey wrote:
>>
>> Hi,
>>
> Hi,
>
> Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client
> can't filter wrong ;)
>
>> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>>> With default config on smdk5250 latest tree throws below message :
>>>
>>> [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
>>> [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
>>>
>>> and hangs randomly because it reads wrong temperature value.
>>>
>>> I can't figure out any direct relation between LDO10 and TMU from board
>>> schematics which I have. So making LDO10 always-on to fix issue for now.
>>>
> Hmm...strange, I also can't see any relations now...but I need to contact to
> hardware guy before applying this, this fixes the problem though.
>

By any chance you got time to check with HW engineer, as issue is there 
without this patch, SMDK5250 fails to boot and hangs.

Thanks,
Pankaj Dubey

> Thanks,
> Kukjin
>
>>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>>>
>>
>> Tested this on SMDK5250 board, system boot is fine now, hence
>>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>>> ---
>>> arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> index bc27cc2..95b5b51 100644
>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> @@ -190,6 +190,7 @@
>>>    				regulator-name = "P1.8V_LDO_OUT10";
>>>    				regulator-min-microvolt = <1800000>;
>>>    				regulator-max-microvolt = <1800000>;
>>> +				regulator-always-on;
>>>    			};
>>>
>>>    			ldo11_reg: LDO11 {
>>>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index bc27cc2..95b5b51 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -190,6 +190,7 @@ 
 				regulator-name = "P1.8V_LDO_OUT10";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
 			};
 
 			ldo11_reg: LDO11 {