| Message ID | 1416857108-2618-1-git-send-email-xerofoify@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/24/2014 08:25 PM, Nicholas Krause wrote: > Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH > due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits > of the bus width and not just the lower or higher 16 depending on the machine's bit > order. > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > --- > drivers/block/xsysace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c > index c4328d9..1b807ed 100644 > --- a/drivers/block/xsysace.c > +++ b/drivers/block/xsysace.c > @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) > static int ace_probe(struct platform_device *dev) > { > resource_size_t physaddr = 0; > - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ > + int bus_width = ACE_BUS_WIDTH_16; > u32 id = dev->id; > int irq = 0; > int i; > Reviewed-by: Michal Simek <michal.simek@xilinx.com> Thanks, Michal
On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote: > On 11/24/2014 08:25 PM, Nicholas Krause wrote: > > Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH > > due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits > > of the bus width and not just the lower or higher 16 depending on the machine's bit > > order. > > > > Signed-off-by: Nicholas Krause <xerofoify@gmail.com> > > --- > > drivers/block/xsysace.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c > > index c4328d9..1b807ed 100644 > > --- a/drivers/block/xsysace.c > > +++ b/drivers/block/xsysace.c > > @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) > > static int ace_probe(struct platform_device *dev) > > { > > resource_size_t physaddr = 0; > > - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ > > + int bus_width = ACE_BUS_WIDTH_16; > > u32 id = dev->id; > > int irq = 0; > > int i; > > > > Reviewed-by: Michal Simek <michal.simek@xilinx.com> I find the commit message rather misleading, but the change is OK. Sören
Soren, If you want me to change it I would be glad, I wasn't sure what to write to be honest but if you have a better message in mind please let me known. Cheers Nick On 14-11-24 02:33 PM, Sören Brinkmann wrote: > On Mon, 2014-11-24 at 08:31PM +0100, Michal Simek wrote: >> On 11/24/2014 08:25 PM, Nicholas Krause wrote: >>> Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH >>> due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits >>> of the bus width and not just the lower or higher 16 depending on the machine's bit >>> order. >>> >>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com> >>> --- >>> drivers/block/xsysace.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c >>> index c4328d9..1b807ed 100644 >>> --- a/drivers/block/xsysace.c >>> +++ b/drivers/block/xsysace.c >>> @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) >>> static int ace_probe(struct platform_device *dev) >>> { >>> resource_size_t physaddr = 0; >>> - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ >>> + int bus_width = ACE_BUS_WIDTH_16; >>> u32 id = dev->id; >>> int irq = 0; >>> int i; >>> >> >> Reviewed-by: Michal Simek <michal.simek@xilinx.com> > > I find the commit message rather misleading, but the change is OK. > > Sören >
diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c index c4328d9..1b807ed 100644 --- a/drivers/block/xsysace.c +++ b/drivers/block/xsysace.c @@ -1152,7 +1152,7 @@ static void ace_free(struct device *dev) static int ace_probe(struct platform_device *dev) { resource_size_t physaddr = 0; - int bus_width = ACE_BUS_WIDTH_16; /* FIXME: should not be hard coded */ + int bus_width = ACE_BUS_WIDTH_16; u32 id = dev->id; int irq = 0; int i;
Removes unneeded FIXME message related to using a hard coded value for ACE_BUS_WIDTH due to it needing to be 8 bits, this is wrong as this function here needs all 16 bits of the bus width and not just the lower or higher 16 depending on the machine's bit order. Signed-off-by: Nicholas Krause <xerofoify@gmail.com> --- drivers/block/xsysace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)