| Message ID | 20090919091644.0219cfba@pedra.chehab.org (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Mauro On Sat, 19 Sep 2009, Mauro Carvalho Chehab wrote: > Em Sat, 19 Sep 2009 01:06:02 -0300 > Mauro Carvalho Chehab <mchehab@infradead.org> escreveu: > > > Hi Guennadi, > > > > I'm about to send our pull request. > > > > While doing my last checks, I noticed a difference between our tree and > > upstream. I'm not sure what happens. Could you please check? > > > > The enclosed patch is the diff from upstream to -hg. > > Ok, I discovered the cause of the conflict: > git patch 6d1386c6b8db54ac8d94c01194e0c27cd538532b were applied before the > soc_camera conversion to v4l dev/subdev. > > I've applied the patch on our development tree. Still, we have a few diffs, > probably meaning that I solved it at the wrong way at git. No, please, don't change anything in our trees. Pual should have pushed his tree after v4l to Linus, but he has done it before. The idea is we should push our tree as is and then solve the conflict on merge. That should be easy. But if you start patching the v4l tree, that can make things much more complicated. BTW, your patch below is not the correct fix. Thanks Guennadi > > Please let me know what would be the proper way to fix it: by keeping > clk_enable/clk_disable (so reverting part of Magnus changes), > or by using, instead pm_runtime_get_sync/pm_runtime_put_sync. > > I guess the latter is the proper fix, but, as both use API's that are sh > specific, the better is if you could point me the right way. > > Cheers, > Mauro. > > diff -upr oldtree/drivers/media/video/sh_mobile_ceu_camera.c /home/v4l/tokernel/wrk/linux-next/drivers/media/video/sh_mobile_ceu_camera.c > --- oldtree/drivers/media/video/sh_mobile_ceu_camera.c 2009-09-19 09:08:13.000000000 -0300 > +++ /home/v4l/tokernel/wrk/linux-next/drivers/media/video/sh_mobile_ceu_camera.c 2009-09-19 01:35:28.000000000 -0300 > @@ -404,7 +404,7 @@ static int sh_mobile_ceu_add_device(stru > "SuperH Mobile CEU driver attached to camera %d\n", > icd->devnum); > > - pm_runtime_get_sync(ici->dev); > + clk_enable(pcdev->clk); > > ceu_write(pcdev, CAPSR, 1 << 16); /* reset */ > while (ceu_read(pcdev, CSTSR) & 1) > @@ -438,7 +438,7 @@ static void sh_mobile_ceu_remove_device( > } > spin_unlock_irqrestore(&pcdev->lock, flags); > > - pm_runtime_put_sync(ici->dev); > + clk_disable(pcdev->clk); > > dev_info(icd->dev.parent, > "SuperH Mobile CEU driver detached from camera %d\n", > > > > > > > Cheers, > Mauro > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Em Sun, 20 Sep 2009 10:57:34 +0200 (CEST) Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu: > Hi Mauro > > On Sat, 19 Sep 2009, Mauro Carvalho Chehab wrote: > > > Em Sat, 19 Sep 2009 01:06:02 -0300 > > Mauro Carvalho Chehab <mchehab@infradead.org> escreveu: > > > > > Hi Guennadi, > > > > > > I'm about to send our pull request. > > > > > > While doing my last checks, I noticed a difference between our tree and > > > upstream. I'm not sure what happens. Could you please check? > > > > > > The enclosed patch is the diff from upstream to -hg. > > > > Ok, I discovered the cause of the conflict: > > git patch 6d1386c6b8db54ac8d94c01194e0c27cd538532b were applied before the > > soc_camera conversion to v4l dev/subdev. > > > > I've applied the patch on our development tree. Still, we have a few diffs, > > probably meaning that I solved it at the wrong way at git. > > No, please, don't change anything in our trees. Pual should have pushed > his tree after v4l to Linus, but he has done it before. The idea is we > should push our tree as is and then solve the conflict on merge. That > should be easy. But if you start patching the v4l tree, that can make > things much more complicated. BTW, your patch below is not the correct > fix. That patch bellow is the diff between -hg tree and what we have at -git, after the conflict solve. If it is wrong, it shows that the conflict were solved in a wrong direction. Both your and Magnus patch touched at the same context lines of the code, making the resolution not trivial. If that patch is not correct, we need to apply it on our tree and write a patch fixing it. The fix patch should be then added at another git push request. Cheers, Mauro -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 20 Sep 2009, Mauro Carvalho Chehab wrote: > Em Sun, 20 Sep 2009 10:57:34 +0200 (CEST) > Guennadi Liakhovetski <g.liakhovetski@gmx.de> escreveu: > > > Hi Mauro > > > > On Sat, 19 Sep 2009, Mauro Carvalho Chehab wrote: > > > > > Em Sat, 19 Sep 2009 01:06:02 -0300 > > > Mauro Carvalho Chehab <mchehab@infradead.org> escreveu: > > > > > > > Hi Guennadi, > > > > > > > > I'm about to send our pull request. > > > > > > > > While doing my last checks, I noticed a difference between our tree and > > > > upstream. I'm not sure what happens. Could you please check? > > > > > > > > The enclosed patch is the diff from upstream to -hg. > > > > > > Ok, I discovered the cause of the conflict: > > > git patch 6d1386c6b8db54ac8d94c01194e0c27cd538532b were applied before the > > > soc_camera conversion to v4l dev/subdev. > > > > > > I've applied the patch on our development tree. Still, we have a few diffs, > > > probably meaning that I solved it at the wrong way at git. > > > > No, please, don't change anything in our trees. Pual should have pushed > > his tree after v4l to Linus, but he has done it before. The idea is we > > should push our tree as is and then solve the conflict on merge. That > > should be easy. But if you start patching the v4l tree, that can make > > things much more complicated. BTW, your patch below is not the correct > > fix. > > That patch bellow is the diff between -hg tree and what we have at -git, after the > conflict solve. If it is wrong, it shows that the conflict were solved in a wrong > direction. Both your and Magnus patch touched at the same context lines of the > code, making the resolution not trivial. > > If that patch is not correct, we need to apply it on our tree and write a patch > fixing it. The fix patch should be then added at another git push request. Paul Mundt (added to CC), the maintainer of the sh Linux port is aware of the problem and has a correct fix, and will take care of it, he also suggested, that we should just push our current state, have I understood it right, Paul? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff -upr oldtree/drivers/media/video/sh_mobile_ceu_camera.c /home/v4l/tokernel/wrk/linux-next/drivers/media/video/sh_mobile_ceu_camera.c --- oldtree/drivers/media/video/sh_mobile_ceu_camera.c 2009-09-19 09:08:13.000000000 -0300 +++ /home/v4l/tokernel/wrk/linux-next/drivers/media/video/sh_mobile_ceu_camera.c 2009-09-19 01:35:28.000000000 -0300 @@ -404,7 +404,7 @@ static int sh_mobile_ceu_add_device(stru "SuperH Mobile CEU driver attached to camera %d\n", icd->devnum); - pm_runtime_get_sync(ici->dev); + clk_enable(pcdev->clk); ceu_write(pcdev, CAPSR, 1 << 16); /* reset */ while (ceu_read(pcdev, CSTSR) & 1) @@ -438,7 +438,7 @@ static void sh_mobile_ceu_remove_device( } spin_unlock_irqrestore(&pcdev->lock, flags); - pm_runtime_put_sync(ici->dev); + clk_disable(pcdev->clk); dev_info(icd->dev.parent, "SuperH Mobile CEU driver detached from camera %d\n",