| Message ID | 1416905668-23029-1-git-send-email-josh.wu@atmel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Josh, On 25/11/14 09:54, Josh Wu wrote: > Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. > The definitions are sorted by alphabet order. > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > --- > include/media/v4l2-image-sizes.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h > index 10daf92..c70c917 100644 > --- a/include/media/v4l2-image-sizes.h > +++ b/include/media/v4l2-image-sizes.h > @@ -25,10 +25,19 @@ > #define QVGA_WIDTH 320 > #define QVGA_HEIGHT 240 > > +#define SVGA_WIDTH 800 > +#define SVGA_HEIGHT 680 I think this should be 600. With that fixed, for both patches: Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > #define SXGA_WIDTH 1280 > #define SXGA_HEIGHT 1024 > > #define VGA_WIDTH 640 > #define VGA_HEIGHT 480 > > +#define UXGA_WIDTH 1600 > +#define UXGA_HEIGHT 1200 > + > +#define XGA_WIDTH 1024 > +#define XGA_HEIGHT 768 > + > #endif /* _IMAGE_SIZES_H */ -- Regards, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Josh, On Tue, 25 Nov 2014, Josh Wu wrote: > Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. > The definitions are sorted by alphabet order. > > Signed-off-by: Josh Wu <josh.wu@atmel.com> Thanks for your patches. I'm ok with these two, but the second of them depends on the first one, and the first one wouldn't (normally) be going via the soc-camera tree. Mauro, how would you prefer to handle this? Should I pick up and push to you both of them or postpone #2 until the next merge window? Thanks Guennadi > --- > include/media/v4l2-image-sizes.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h > index 10daf92..c70c917 100644 > --- a/include/media/v4l2-image-sizes.h > +++ b/include/media/v4l2-image-sizes.h > @@ -25,10 +25,19 @@ > #define QVGA_WIDTH 320 > #define QVGA_HEIGHT 240 > > +#define SVGA_WIDTH 800 > +#define SVGA_HEIGHT 680 > + > #define SXGA_WIDTH 1280 > #define SXGA_HEIGHT 1024 > > #define VGA_WIDTH 640 > #define VGA_HEIGHT 480 > > +#define UXGA_WIDTH 1600 > +#define UXGA_HEIGHT 1200 > + > +#define XGA_WIDTH 1024 > +#define XGA_HEIGHT 768 > + > #endif /* _IMAGE_SIZES_H */ > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Sylwester and Mauro On 11/25/2014 6:34 PM, Sylwester Nawrocki wrote: > Hi Josh, > > On 25/11/14 09:54, Josh Wu wrote: >> Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. >> The definitions are sorted by alphabet order. >> >> Signed-off-by: Josh Wu <josh.wu@atmel.com> >> --- >> include/media/v4l2-image-sizes.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h >> index 10daf92..c70c917 100644 >> --- a/include/media/v4l2-image-sizes.h >> +++ b/include/media/v4l2-image-sizes.h >> @@ -25,10 +25,19 @@ >> #define QVGA_WIDTH 320 >> #define QVGA_HEIGHT 240 >> >> +#define SVGA_WIDTH 800 >> +#define SVGA_HEIGHT 680 > I think this should be 600. With that fixed, for both patches: Yes, right, It should be 600. It's my bad with such terrible typo here. Hi, Mauro I saw this patch is already merged in the media_tree. But not changing the SVGA_HEIGHT to 600. Would it possible for you to re-modify this commit in the media_tree to fix the SVGA_HEIGHT as 600? Or need I resend the patch or a fix for this? Sorry for such an inconvinencie. > > Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com> Thanks a again. Best Regards, Josh Wu > >> #define SXGA_WIDTH 1280 >> #define SXGA_HEIGHT 1024 >> >> #define VGA_WIDTH 640 >> #define VGA_HEIGHT 480 >> >> +#define UXGA_WIDTH 1600 >> +#define UXGA_HEIGHT 1200 >> + >> +#define XGA_WIDTH 1024 >> +#define XGA_HEIGHT 768 >> + >> #endif /* _IMAGE_SIZES_H */ > -- > Regards, > Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Guennadi On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: > Hi Josh, > > On Tue, 25 Nov 2014, Josh Wu wrote: > >> Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. >> The definitions are sorted by alphabet order. >> >> Signed-off-by: Josh Wu <josh.wu@atmel.com> > Thanks for your patches. I'm ok with these two, but the second of them > depends on the first one, and the first one wouldn't (normally) be going > via the soc-camera tree. Mauro, how would you prefer to handle this? > Should I pick up and push to you both of them or postpone #2 until the > next merge window? The first patch is already merged in the media_tree. If the soc-camera tree will be merged to the media_tree, then there should have no dependency issue. Am I understanding correct? Best Regards, Josh Wu > > Thanks > Guennadi > >> --- >> include/media/v4l2-image-sizes.h | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h >> index 10daf92..c70c917 100644 >> --- a/include/media/v4l2-image-sizes.h >> +++ b/include/media/v4l2-image-sizes.h >> @@ -25,10 +25,19 @@ >> #define QVGA_WIDTH 320 >> #define QVGA_HEIGHT 240 >> >> +#define SVGA_WIDTH 800 >> +#define SVGA_HEIGHT 680 >> + >> #define SXGA_WIDTH 1280 >> #define SXGA_HEIGHT 1024 >> >> #define VGA_WIDTH 640 >> #define VGA_HEIGHT 480 >> >> +#define UXGA_WIDTH 1600 >> +#define UXGA_HEIGHT 1200 >> + >> +#define XGA_WIDTH 1024 >> +#define XGA_HEIGHT 768 >> + >> #endif /* _IMAGE_SIZES_H */ >> -- >> 1.9.1 >> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Josh, On Thu, 27 Nov 2014, Josh Wu wrote: > Hi, Guennadi > > On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: > > Hi Josh, > > > > On Tue, 25 Nov 2014, Josh Wu wrote: > > > > > Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. > > > The definitions are sorted by alphabet order. > > > > > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > > Thanks for your patches. I'm ok with these two, but the second of them > > depends on the first one, and the first one wouldn't (normally) be going > > via the soc-camera tree. Mauro, how would you prefer to handle this? > > Should I pick up and push to you both of them or postpone #2 until the > > next merge window? > > The first patch is already merged in the media_tree. If the soc-camera tree > will be merged to the media_tree, then there should have no dependency issue. > Am I understanding correct? Yes, then it should be ok! Thanks Guennadi > Best Regards, > Josh Wu > > > > > Thanks > > Guennadi > > > > > --- > > > include/media/v4l2-image-sizes.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/include/media/v4l2-image-sizes.h > > > b/include/media/v4l2-image-sizes.h > > > index 10daf92..c70c917 100644 > > > --- a/include/media/v4l2-image-sizes.h > > > +++ b/include/media/v4l2-image-sizes.h > > > @@ -25,10 +25,19 @@ > > > #define QVGA_WIDTH 320 > > > #define QVGA_HEIGHT 240 > > > +#define SVGA_WIDTH 800 > > > +#define SVGA_HEIGHT 680 > > > + > > > #define SXGA_WIDTH 1280 > > > #define SXGA_HEIGHT 1024 > > > #define VGA_WIDTH 640 > > > #define VGA_HEIGHT 480 > > > +#define UXGA_WIDTH 1600 > > > +#define UXGA_HEIGHT 1200 > > > + > > > +#define XGA_WIDTH 1024 > > > +#define XGA_HEIGHT 768 > > > + > > > #endif /* _IMAGE_SIZES_H */ > > > -- > > > 1.9.1 > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, Guennadi On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote: > Hi Josh, > > On Thu, 27 Nov 2014, Josh Wu wrote: > >> Hi, Guennadi >> >> On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: >>> Hi Josh, >>> >>> On Tue, 25 Nov 2014, Josh Wu wrote: >>> >>>> Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. >>>> The definitions are sorted by alphabet order. >>>> >>>> Signed-off-by: Josh Wu <josh.wu@atmel.com> >>> Thanks for your patches. I'm ok with these two, but the second of them >>> depends on the first one, and the first one wouldn't (normally) be going >>> via the soc-camera tree. Mauro, how would you prefer to handle this? >>> Should I pick up and push to you both of them or postpone #2 until the >>> next merge window? >> The first patch is already merged in the media_tree. If the soc-camera tree >> will be merged to the media_tree, then there should have no dependency issue. >> Am I understanding correct? > Yes, then it should be ok! Just checking the status of this patch. I don't found this patch in media's tree or soc_camera's tree. Could you take this patch in your tree? Best Regards, Josh Wu > > Thanks > Guennadi > >> Best Regards, >> Josh Wu >> >>> Thanks >>> Guennadi >>> >>>> --- >>>> include/media/v4l2-image-sizes.h | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/include/media/v4l2-image-sizes.h >>>> b/include/media/v4l2-image-sizes.h >>>> index 10daf92..c70c917 100644 >>>> --- a/include/media/v4l2-image-sizes.h >>>> +++ b/include/media/v4l2-image-sizes.h >>>> @@ -25,10 +25,19 @@ >>>> #define QVGA_WIDTH 320 >>>> #define QVGA_HEIGHT 240 >>>> +#define SVGA_WIDTH 800 >>>> +#define SVGA_HEIGHT 680 >>>> + >>>> #define SXGA_WIDTH 1280 >>>> #define SXGA_HEIGHT 1024 >>>> #define VGA_WIDTH 640 >>>> #define VGA_HEIGHT 480 >>>> +#define UXGA_WIDTH 1600 >>>> +#define UXGA_HEIGHT 1200 >>>> + >>>> +#define XGA_WIDTH 1024 >>>> +#define XGA_HEIGHT 768 >>>> + >>>> #endif /* _IMAGE_SIZES_H */ >>>> -- >>>> 1.9.1 >>>> -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Josh, On Wed, 28 Jan 2015, Josh Wu wrote: > Hi, Guennadi > > On 11/28/2014 4:13 AM, Guennadi Liakhovetski wrote: > > Hi Josh, > > > > On Thu, 27 Nov 2014, Josh Wu wrote: > > > > > Hi, Guennadi > > > > > > On 11/26/2014 6:23 AM, Guennadi Liakhovetski wrote: > > > > Hi Josh, > > > > > > > > On Tue, 25 Nov 2014, Josh Wu wrote: > > > > > > > > > Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. > > > > > The definitions are sorted by alphabet order. > > > > > > > > > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > > > > Thanks for your patches. I'm ok with these two, but the second of them > > > > depends on the first one, and the first one wouldn't (normally) be going > > > > via the soc-camera tree. Mauro, how would you prefer to handle this? > > > > Should I pick up and push to you both of them or postpone #2 until the > > > > next merge window? > > > The first patch is already merged in the media_tree. If the soc-camera > > > tree > > > will be merged to the media_tree, then there should have no dependency > > > issue. > > > Am I understanding correct? > > Yes, then it should be ok! > > Just checking the status of this patch. I don't found this patch in media's > tree or soc_camera's tree. > Could you take this patch in your tree? uhm, yes, sorry, I'll try to make sure not to miss it with my next pull request. Thanks for a reminder! Regards Guennadi > Best Regards, > Josh Wu > > > > > Thanks > > Guennadi > > > > > Best Regards, > > > Josh Wu > > > > > > > Thanks > > > > Guennadi > > > > > > > > > --- > > > > > include/media/v4l2-image-sizes.h | 9 +++++++++ > > > > > 1 file changed, 9 insertions(+) > > > > > > > > > > diff --git a/include/media/v4l2-image-sizes.h > > > > > b/include/media/v4l2-image-sizes.h > > > > > index 10daf92..c70c917 100644 > > > > > --- a/include/media/v4l2-image-sizes.h > > > > > +++ b/include/media/v4l2-image-sizes.h > > > > > @@ -25,10 +25,19 @@ > > > > > #define QVGA_WIDTH 320 > > > > > #define QVGA_HEIGHT 240 > > > > > +#define SVGA_WIDTH 800 > > > > > +#define SVGA_HEIGHT 680 > > > > > + > > > > > #define SXGA_WIDTH 1280 > > > > > #define SXGA_HEIGHT 1024 > > > > > #define VGA_WIDTH 640 > > > > > #define VGA_HEIGHT 480 > > > > > +#define UXGA_WIDTH 1600 > > > > > +#define UXGA_HEIGHT 1200 > > > > > + > > > > > +#define XGA_WIDTH 1024 > > > > > +#define XGA_HEIGHT 768 > > > > > + > > > > > #endif /* _IMAGE_SIZES_H */ > > > > > -- > > > > > 1.9.1 > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/media/v4l2-image-sizes.h b/include/media/v4l2-image-sizes.h index 10daf92..c70c917 100644 --- a/include/media/v4l2-image-sizes.h +++ b/include/media/v4l2-image-sizes.h @@ -25,10 +25,19 @@ #define QVGA_WIDTH 320 #define QVGA_HEIGHT 240 +#define SVGA_WIDTH 800 +#define SVGA_HEIGHT 680 + #define SXGA_WIDTH 1280 #define SXGA_HEIGHT 1024 #define VGA_WIDTH 640 #define VGA_HEIGHT 480 +#define UXGA_WIDTH 1600 +#define UXGA_HEIGHT 1200 + +#define XGA_WIDTH 1024 +#define XGA_HEIGHT 768 + #endif /* _IMAGE_SIZES_H */
Add SVGA, UXGA and XGA size definitions to v4l2-image-sizes.h. The definitions are sorted by alphabet order. Signed-off-by: Josh Wu <josh.wu@atmel.com> --- include/media/v4l2-image-sizes.h | 9 +++++++++ 1 file changed, 9 insertions(+)