| Message ID | 1411796519-19417-4-git-send-email-pankaj.dubey@samsung.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Pankaj, On 27/09/14 07:41, Pankaj Dubey wrote: > Let's remove unnecessary include of header files from clk.h and add > required one in clk.c > > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> > --- > drivers/clk/samsung/clk.c | 3 ++- > drivers/clk/samsung/clk.h | 4 ---- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c > index 31bf391..952f9ec 100644 > --- a/drivers/clk/samsung/clk.c > +++ b/drivers/clk/samsung/clk.c > @@ -11,7 +11,8 @@ > * clock framework for Samsung platforms. > */ > > -#include <linux/syscore_ops.h> I've dropped this change when applying since it causes a build break: drivers/clk/samsung/clk.c:338:15: error: variable ‘samsung_clk_syscore_ops’ has initializer but incomplete type drivers/clk/samsung/clk.c:339:2: error: unknown field ‘suspend’ specified in initializer drivers/clk/samsung/clk.c:339:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/samsung/clk.c:339:2: warning: (near initialization for ‘samsung_clk_syscore_ops’) [enabled by default] drivers/clk/samsung/clk.c:340:2: error: unknown field ‘resume’ specified in initializer drivers/clk/samsung/clk.c:340:2: warning: excess elements in struct initializer [enabled by default] drivers/clk/samsung/clk.c:340:2: warning: (near initialization for ‘samsung_clk_syscore_ops’) [enabled by default] CC drivers/dma/virt-dma.o drivers/clk/samsung/clk.c: In function ‘samsung_clk_sleep_init’: drivers/clk/samsung/clk.c:359:3: error: implicit declaration of function ‘register_syscore_ops’ [-Werror=implicit-function-declaration] Please make sure there is no build breaks with various configs when sending patches. -- Regards, Sylwester
Hi Sylwester, On Tuesday 02 December 2014 08:53 PM, Sylwester Nawrocki wrote: > Hi Pankaj, > > On 27/09/14 07:41, Pankaj Dubey wrote: >> Let's remove unnecessary include of header files from clk.h and add >> required one in clk.c >> >> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >> --- >> drivers/clk/samsung/clk.c | 3 ++- >> drivers/clk/samsung/clk.h | 4 ---- >> 2 files changed, 2 insertions(+), 5 deletions(-) >> > Please make sure there is no build breaks with various configs when > sending patches. I am sure that I compile tested this before submitting. Looks like following commit [1] needs "linux/syscore-ops.h" in clk.c, before that it was not needed. 1: clk: samsung: Factor out the common code to clk.c [SHA_ID: 16a9013b83b5106c83cf] Anyways, I can see patches are not getting cleanly applied so, just now I resend them [2] after rebasing please have a look. 2: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/40639 Thanks, Pankaj Dubey > > -- > Regards, > Sylwester >
On 03/12/14 12:42, Pankaj Dubey wrote: > Hi Sylwester, > > On Tuesday 02 December 2014 08:53 PM, Sylwester Nawrocki wrote: >> Hi Pankaj, >> >> On 27/09/14 07:41, Pankaj Dubey wrote: >>> Let's remove unnecessary include of header files from clk.h and add >>> required one in clk.c >>> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> >>> --- >>> drivers/clk/samsung/clk.c | 3 ++- >>> drivers/clk/samsung/clk.h | 4 ---- >>> 2 files changed, 2 insertions(+), 5 deletions(-) >>> >> Please make sure there is no build breaks with various configs when >> sending patches. > > I am sure that I compile tested this before submitting. Looks like > following commit [1] needs "linux/syscore-ops.h" in clk.c, before that > it was not needed. > > 1: clk: samsung: Factor out the common code to clk.c [SHA_ID: > 16a9013b83b5106c83cf] OK, my apologies then for not investigating it further. > Anyways, I can see patches are not getting cleanly applied so, just now > I resend them [2] after rebasing please have a look. There is no need to resend, the patches are already applied into my tree git://linuxtv.org/snawrocki/samsung.git for-v3.19/clk-next I will probably send a second pull request for Mike today. Just need to figure out what to do with the patches addressing the dependency of the audio clock controller control registers on the APLL clock. -- Regards, Sylwester
diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c index 31bf391..952f9ec 100644 --- a/drivers/clk/samsung/clk.c +++ b/drivers/clk/samsung/clk.c @@ -11,7 +11,8 @@ * clock framework for Samsung platforms. */ -#include <linux/syscore_ops.h> +#include <linux/of_address.h> + #include "clk.h" void samsung_clk_save(void __iomem *base, diff --git a/drivers/clk/samsung/clk.h b/drivers/clk/samsung/clk.h index a1ece4a..29a5779 100644 --- a/drivers/clk/samsung/clk.h +++ b/drivers/clk/samsung/clk.h @@ -13,12 +13,8 @@ #ifndef __SAMSUNG_CLK_H #define __SAMSUNG_CLK_H -#include <linux/clk.h> #include <linux/clkdev.h> -#include <linux/io.h> #include <linux/clk-provider.h> -#include <linux/of.h> -#include <linux/of_address.h> #include "clk-pll.h" /**
Let's remove unnecessary include of header files from clk.h and add required one in clk.c Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com> --- drivers/clk/samsung/clk.c | 3 ++- drivers/clk/samsung/clk.h | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-)